• Matheus Marchini's avatar
    [error] extend error stack w/ function parameters · 97628eee
    Matheus Marchini authored
    Extend FrameArray to hold weak references to parameters for functions in
    the call stack. The goal here is to provide more metadata for postmortem
    tools (such as llnode), especially in cases of rethrowing (this will be
    particularly useful when using postmortem with promises on Node.js).
    
    Besides postmortem, these changes allow us to print a more detailed
    stack trace for errors with parameters types (or even values), which can
    be useful since JavaScript functions can receive any number of
    parameters of any type, and having a function behave differently
    according to the number of parameters received as well as their types is
    a common pattern on JS libraries and frameworks.
    
    R=bmeurer@google.com, yangguo@google.com
    
    Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61
    Reviewed-on: https://chromium-review.googlesource.com/c/1289489
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58468}
    97628eee
test-heap.cc 229 KB