• Benedikt Meurer's avatar
    [inspector] Make `ArrayBuffer.[[ArrayBufferData]]` deterministic. · 833b3c96
    Benedikt Meurer authored
    Previously the internal `[[ArrayBufferData]]` property for `ArrayBuffer`
    objects reported by the inspector (and used by the DevTools front-end to
    identify `ArrayBuffer`s and `WebAssembly.Memory`s using the same backing
    store) simply contained a hex string representation of the backing store
    pointer. However that unnecessarily leaks internal addresses and more
    importantly is not deterministic, which complicates tests (just blew up
    on layout tests).
    
    This CL introduces an automatically incremented `BackingStore::id()`,
    which is used instead now and is deterministic.
    
    Bug: chromium:1199701, chromium:1163802, chromium:1249961
    Change-Id: I8ee47009cd825cfdbe00230f617c87c90508ab2a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3162144
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76893}
    833b3c96
backing-store.cc 39.7 KB