• Benedikt Meurer's avatar
    [inspector] Make `ArrayBuffer.[[ArrayBufferData]]` deterministic. · 833b3c96
    Benedikt Meurer authored
    Previously the internal `[[ArrayBufferData]]` property for `ArrayBuffer`
    objects reported by the inspector (and used by the DevTools front-end to
    identify `ArrayBuffer`s and `WebAssembly.Memory`s using the same backing
    store) simply contained a hex string representation of the backing store
    pointer. However that unnecessarily leaks internal addresses and more
    importantly is not deterministic, which complicates tests (just blew up
    on layout tests).
    
    This CL introduces an automatically incremented `BackingStore::id()`,
    which is used instead now and is deterministic.
    
    Bug: chromium:1199701, chromium:1163802, chromium:1249961
    Change-Id: I8ee47009cd825cfdbe00230f617c87c90508ab2a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3162144
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76893}
    833b3c96
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...