• Darius M's avatar
    Reland [compiler] Simplify "==0" branches in MachineOperatorReducer · 6b690a6b
    Darius M authored
    This is a reland of 48b443f6.
    
    While fixing the initial CL, we stumbled upon a few bugs that
    we had to fix:
    
     - CommonOperatorReducer and SimplifiedOperatorReducer were applied
       before and after SimplifiedLowering, but always assumed that it
       was before SimplifiedLowering, and thus had the wrong semantics
       for branches in some cases. They now have an added parameter to
       know which semantics of branch they should use.
    
     - The lowering of StaticAssert was wrong and could leave kHeapConstant
       in the assert (instead of machine Booleans).
    
    Original change's description:
    > [compiler] Simplify "==0" branches in MachineOperatorReducer
    >
    > Bug: v8:12484
    > Change-Id: I0667c7464c0dd71338bc199a24a69248a7a0a525
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497303
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Owners-Override: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79379}
    
    Bug: v8:12484
    Change-Id: Ibbf5df96fce5ccb04868dc517539479bf69f5703
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516869Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79528}
    6b690a6b
common-operator.h 28.6 KB