• Darius M's avatar
    Reland [compiler] Simplify "==0" branches in MachineOperatorReducer · 6b690a6b
    Darius M authored
    This is a reland of 48b443f6.
    
    While fixing the initial CL, we stumbled upon a few bugs that
    we had to fix:
    
     - CommonOperatorReducer and SimplifiedOperatorReducer were applied
       before and after SimplifiedLowering, but always assumed that it
       was before SimplifiedLowering, and thus had the wrong semantics
       for branches in some cases. They now have an added parameter to
       know which semantics of branch they should use.
    
     - The lowering of StaticAssert was wrong and could leave kHeapConstant
       in the assert (instead of machine Booleans).
    
    Original change's description:
    > [compiler] Simplify "==0" branches in MachineOperatorReducer
    >
    > Bug: v8:12484
    > Change-Id: I0667c7464c0dd71338bc199a24a69248a7a0a525
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497303
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Owners-Override: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79379}
    
    Bug: v8:12484
    Change-Id: Ibbf5df96fce5ccb04868dc517539479bf69f5703
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516869Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79528}
    6b690a6b
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...