• Dan Elphick's avatar
    Revert "[compiler] Make StateValuesAccess methods inlinable" · 1a4bbc8a
    Dan Elphick authored
    This reverts commit 14d1b9e9.
    
    Reason for revert: Increases RuntimeStats/Group-JavaScript/duration
    
    Original change's description:
    > [compiler] Make StateValuesAccess methods inlinable
    > 
    > This moves several simple StateValuesAccess methods as well as
    > SparseInputMask::InputIterator::IsReal into their header files so they
    > can be more easily inlined. This gives about a 7% improvement to the
    > BackgroundSelectInstructions runtime call stat.
    > 
    > Also marks some methods called by the new methods as V8_PRIVATE_EXPORT
    > so component build test can build.
    > 
    > Bug: v8:10051
    > Change-Id: I3e34977a4fa660d3f4f55fd4f2c0b2370d5d2bc2
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2023559
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66078}
    
    TBR=neis@chromium.org,delphick@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:10051
    Change-Id: I9168b524bc06562906a12a6ec0e948d6f90d4a7d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050387Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66219}
    1a4bbc8a
common-operator.cc 58.6 KB