• Ng Zhi An's avatar
    [wasm-simd][liftoff] Fix i64x2.mul codegen bug · f7ac5a29
    Ng Zhi An authored
    When dst != lhs, we moved lhs to dst, but dst can be == rhs, so we would
    overwrite rhs, and end up comparing lhs with itself, always returning
    false. We handle the different aliasing cases in the macro-assembler
    function I64x2GtS, to simplify the checks in Liftoff a little bit.
    TurboFan does not need to change as it will require dst == lhs when AVX
    is not supported.
    
    Bug: v8:12237
    Change-Id: Icefa6eb79083c003e93dbbd11ccc419aae4b15d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3169312Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76945}
    f7ac5a29
test-run-wasm-simd.cc 140 KB