• Clemens Backes's avatar
    [flags] Print nicer output for flag contradictions · 47824b7f
    Clemens Backes authored
    Normalize flag names, and print boolean flags using the canonical
    "--no-<foo>" syntax.
    
    Before (with fuzzing):
      Cycle in flag implications:
      assert_types -> concurrent_recompilation = 0
      stress_concurrent_inlining -> concurrent_recompilation = 1
    
    After (with fuzzing):
      Cycle in flag implications:
      --assert-types -> --no-concurrent-recompilation
      --stress-concurrent-inlining -> --concurrent-recompilation
    
    Before (no fuzzing):
      Contradictory flag implications from --assert_types and
      --stress_concurrent_inlining for flag concurrent_recompilation
    
    After (no fuzzing):
      Contradictory flag implications from --assert-types and
      --stress-concurrent-inlining for flag --concurrent-recompilation
    
    R=tebbi@chromium.org
    
    Bug: chromium:1336577
    Change-Id: Id82cff4845d845e964c43b922067905b8b378a0d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750935Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81839}
    47824b7f
flags.cc 28.5 KB