• Clemens Backes's avatar
    [flags] Print nicer output for flag contradictions · 47824b7f
    Clemens Backes authored
    Normalize flag names, and print boolean flags using the canonical
    "--no-<foo>" syntax.
    
    Before (with fuzzing):
      Cycle in flag implications:
      assert_types -> concurrent_recompilation = 0
      stress_concurrent_inlining -> concurrent_recompilation = 1
    
    After (with fuzzing):
      Cycle in flag implications:
      --assert-types -> --no-concurrent-recompilation
      --stress-concurrent-inlining -> --concurrent-recompilation
    
    Before (no fuzzing):
      Contradictory flag implications from --assert_types and
      --stress_concurrent_inlining for flag concurrent_recompilation
    
    After (no fuzzing):
      Contradictory flag implications from --assert-types and
      --stress-concurrent-inlining for flag --concurrent-recompilation
    
    R=tebbi@chromium.org
    
    Bug: chromium:1336577
    Change-Id: Id82cff4845d845e964c43b922067905b8b378a0d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750935Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81839}
    47824b7f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...