• Clemens Hammacher's avatar
    Revert "[wasm] Refactor function body decoder" · 425ede39
    Clemens Hammacher authored
    This reverts commit 6b4dc039.
    
    Reason for revert: Mips build failure: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/11749
    
    Original change's description:
    > [wasm] Refactor function body decoder
    > 
    > This refactoring separates graph building from wasm decoding. The
    > WasmGraphBuilder is just a consumer of the decoded information.
    > Decoding without any consumer (i.e. just validation) gets 16% faster by
    > this refactoring, because no TFNode* have to be stored in the value
    > stack, and all dynamic tests to determine whether the graph should be
    > build are gone (measured on AngryBots; before: 110.2 +- 3.3ms, after:
    > 92.2 +- 3.1 ms).
    > 
    > This new design will allow us to also attach other consumers, e.g. a
    > new baseline compiler.
    > 
    > R=​titzer@chromium.org
    > 
    > Bug: v8:6600
    > Change-Id: I4b60f2409d871a16c3c52a37e515bcfb9dbb8f54
    > Reviewed-on: https://chromium-review.googlesource.com/571010
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Ben Titzer <titzer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47671}
    
    TBR=titzer@chromium.org,clemensh@chromium.org
    
    Change-Id: I76a50e355f0390cc53a2da4ceedd8830ca20a9c6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6600
    Reviewed-on: https://chromium-review.googlesource.com/640870Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47672}
    425ede39
function-body-decoder-impl.h 9.67 KB