• Clemens Hammacher's avatar
    Revert "[wasm] Refactor function body decoder" · 425ede39
    Clemens Hammacher authored
    This reverts commit 6b4dc039.
    
    Reason for revert: Mips build failure: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/11749
    
    Original change's description:
    > [wasm] Refactor function body decoder
    > 
    > This refactoring separates graph building from wasm decoding. The
    > WasmGraphBuilder is just a consumer of the decoded information.
    > Decoding without any consumer (i.e. just validation) gets 16% faster by
    > this refactoring, because no TFNode* have to be stored in the value
    > stack, and all dynamic tests to determine whether the graph should be
    > build are gone (measured on AngryBots; before: 110.2 +- 3.3ms, after:
    > 92.2 +- 3.1 ms).
    > 
    > This new design will allow us to also attach other consumers, e.g. a
    > new baseline compiler.
    > 
    > R=​titzer@chromium.org
    > 
    > Bug: v8:6600
    > Change-Id: I4b60f2409d871a16c3c52a37e515bcfb9dbb8f54
    > Reviewed-on: https://chromium-review.googlesource.com/571010
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Ben Titzer <titzer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47671}
    
    TBR=titzer@chromium.org,clemensh@chromium.org
    
    Change-Id: I76a50e355f0390cc53a2da4ceedd8830ca20a9c6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6600
    Reviewed-on: https://chromium-review.googlesource.com/640870Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47672}
    425ede39
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...