• Andreas Haas's avatar
    [wasm] Reset WasmCompiledModule when it contains non-default values · 402f5151
    Andreas Haas authored
    When we use a WasmCompiledModule for a second instance (i.e. the first
    instance has been collected already by the GC), we reset all instance
    specialization data the WasmCompiledModule contains, and then patch in
    the new instance specialization data. However, we guarded the reset of
    memory references, and in the referenced issue the memory references
    were not reset and therefore later patched incorrectly during
    instantiation. With this CL we change the condition and reset now every
    time the current version of a WasmCompiledModule contains non-default
    values.
    
    R=mtrofin@chromium.org
    CC=​mstarzinger@chromium.org
    TEST=mjsunit/regress/regress-crbug-759327
    
    Bug: chromium:759327
    Change-Id: I9a147afd6ad4000b782850dae0b90685759c9dc7
    Reviewed-on: https://chromium-review.googlesource.com/638571
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47665}
    402f5151
wasm-objects.cc 62.4 KB