• Andreas Haas's avatar
    [wasm] Reset WasmCompiledModule when it contains non-default values · 402f5151
    Andreas Haas authored
    When we use a WasmCompiledModule for a second instance (i.e. the first
    instance has been collected already by the GC), we reset all instance
    specialization data the WasmCompiledModule contains, and then patch in
    the new instance specialization data. However, we guarded the reset of
    memory references, and in the referenced issue the memory references
    were not reset and therefore later patched incorrectly during
    instantiation. With this CL we change the condition and reset now every
    time the current version of a WasmCompiledModule contains non-default
    values.
    
    R=mtrofin@chromium.org
    CC=​mstarzinger@chromium.org
    TEST=mjsunit/regress/regress-crbug-759327
    
    Bug: chromium:759327
    Change-Id: I9a147afd6ad4000b782850dae0b90685759c9dc7
    Reviewed-on: https://chromium-review.googlesource.com/638571
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47665}
    402f5151
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...