• Benedikt Meurer's avatar
    [debug] Forcibly instantiate lazy accessor pairs when setting break points. · 3a7ce5de
    Benedikt Meurer authored
    Previously we had some kind of self-healing when calling lazy accessor
    pairs via InvokeApiFunction(), but we also have other paths for calling
    into FunctionTemplateInfos directly, which didn't do this check. Since
    we already walk the heap when installing the DebugBreakTrampoline, and
    compile all uncompiled functions, we can also just forcibly instantiate
    all the lazy accessor pairs at that time and not have to worry about the
    break-at-entry later.
    
    Bug: v8:178, v8:7596, v8:8834
    Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
    Change-Id: I514392cf328fc8ed0b80ad19009f32e20ff850b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565890Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60813}
    3a7ce5de
ic.cc 114 KB