• Benedikt Meurer's avatar
    [debug] Forcibly instantiate lazy accessor pairs when setting break points. · 3a7ce5de
    Benedikt Meurer authored
    Previously we had some kind of self-healing when calling lazy accessor
    pairs via InvokeApiFunction(), but we also have other paths for calling
    into FunctionTemplateInfos directly, which didn't do this check. Since
    we already walk the heap when installing the DebugBreakTrampoline, and
    compile all uncompiled functions, we can also just forcibly instantiate
    all the lazy accessor pairs at that time and not have to worry about the
    break-at-entry later.
    
    Bug: v8:178, v8:7596, v8:8834
    Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
    Change-Id: I514392cf328fc8ed0b80ad19009f32e20ff850b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565890Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60813}
    3a7ce5de
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...