• Jakob Gruber's avatar
    [wasm] Update the stack check and remove WasmStackCheckMatcher · 376c7b61
    Jakob Gruber authored
    The matcher used to be needed to avoid first moving rsp to an
    allocated register for LoadStackPointer. This is no longer the case
    with the new stack check structure based on StackPointerGreaterThan.
    This CL updates the wasm stack check and removes now-unneeded
    matchers.
    
    The generated stack check code remains unchanged from before:
    
    // Load the stack limit through the instance then compare against rsp.
    REX.W movq rcx,[rbp-0x10]
    REX.W movq rcx,[rcx+0x2f]
    REX.W cmpq rsp,[rcx]
    
    // And on ia32:
    mov ecx,[ebp-0x8]
    mov ecx,[ecx+0x17]
    cmp esp,[ecx]
    
    Bug: v8:9534
    Change-Id: I9240ad922d19d498a2661c143b12d629ac14d093
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748733
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63165}
    376c7b61
node-matchers.h 25.4 KB