• Jakob Gruber's avatar
    [wasm] Update the stack check and remove WasmStackCheckMatcher · 376c7b61
    Jakob Gruber authored
    The matcher used to be needed to avoid first moving rsp to an
    allocated register for LoadStackPointer. This is no longer the case
    with the new stack check structure based on StackPointerGreaterThan.
    This CL updates the wasm stack check and removes now-unneeded
    matchers.
    
    The generated stack check code remains unchanged from before:
    
    // Load the stack limit through the instance then compare against rsp.
    REX.W movq rcx,[rbp-0x10]
    REX.W movq rcx,[rcx+0x2f]
    REX.W cmpq rsp,[rcx]
    
    // And on ia32:
    mov ecx,[ebp-0x8]
    mov ecx,[ecx+0x17]
    cmp esp,[ecx]
    
    Bug: v8:9534
    Change-Id: I9240ad922d19d498a2661c143b12d629ac14d093
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748733
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63165}
    376c7b61
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...