• Michael Achenbach's avatar
    [numfuzz] Gracefully ignore contradictory flags · 3212b906
    Michael Achenbach authored
    NumFuzz passes various flags to V8 testing randomly, which can lead to
    various flag contradictions with existing flags. Up to now the system
    ignored the check for contradictions and kept running the test cases,
    leading to false positives.
    
    This change adds a new v8 flag --exit-on-contradictory-flags that
    exists gracefully when a contradiction is detected. On the numfuzz
    side we now filter simple contradictions beforehand.
    
    Measurements showed that ~2% of all numfuzz tests ran into
    contradictions. Around half of them are simple contradictions
    (repetitions and inversions), which are now filtered beforehand.
    The remaining ones (redundant or contradictory implications) are
    now ignored.
    
    Bug: v8:11826
    Change-Id: I9942e203ba9668a097fabe1343dd1365c9da94c1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650746
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarAlmothana Athamneh <almuthanna@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80589}
    3212b906
num_fuzzer.py 8.86 KB