• Michael Achenbach's avatar
    [numfuzz] Gracefully ignore contradictory flags · 3212b906
    Michael Achenbach authored
    NumFuzz passes various flags to V8 testing randomly, which can lead to
    various flag contradictions with existing flags. Up to now the system
    ignored the check for contradictions and kept running the test cases,
    leading to false positives.
    
    This change adds a new v8 flag --exit-on-contradictory-flags that
    exists gracefully when a contradiction is detected. On the numfuzz
    side we now filter simple contradictions beforehand.
    
    Measurements showed that ~2% of all numfuzz tests ran into
    contradictions. Around half of them are simple contradictions
    (repetitions and inversions), which are now filtered beforehand.
    The remaining ones (redundant or contradictory implications) are
    now ignored.
    
    Bug: v8:11826
    Change-Id: I9942e203ba9668a097fabe1343dd1365c9da94c1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650746
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarAlmothana Athamneh <almuthanna@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80589}
    3212b906
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...