• Michael Hablich's avatar
    Revert "[wasm] Add stack guard for logging code" · 6ce63fd8
    Michael Hablich authored
    This reverts commit 067ba2a0.
    
    Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1570208
    
    21:26:22.251 27507   # Fatal error in ../../v8/src/profiler/profile-generator.cc, line 19
    21:26:22.251 27507   # Debug check failed: line > 0 (0 vs. 0).
    21:26:22.251 27507   #
    21:26:22.251 27507   #
    21:26:22.251 27507   #
    21:26:22.252 27507   #FailureMessage Object: 0x7ffe851046a0#0 0x56532cb371f9 base::debug::CollectStackTrace()
    21:26:22.252 27507   #1 0x56532ca70863 base::debug::StackTrace::StackTrace()
    21:26:22.252 27507   #2 0x56532e99610b gin::(anonymous namespace)::PrintStackTrace()
    21:26:22.252 27507   #3 0x56532e989468 V8_Fatal()
    21:26:22.252 27507   #4 0x56532e9891c5 v8::base::(anonymous namespace)::DefaultDcheckHandler()
    21:26:22.252 27507   #5 0x56532b2bb876 v8::internal::SourcePositionTable::SetPosition()
    21:26:22.252 27507   #6 0x56532b2c2268 v8::internal::ProfilerListener::CodeCreateEvent()
    21:26:22.252 27507   #7 0x56532ae25275 v8::internal::(anonymous namespace)::LogFunctionCompilation()
    21:26:22.252 27507   #8 0x56532ae26008 v8::internal::OptimizedCompilationJob::RecordFunctionCompilation()
    21:26:22.252 27507   #9 0x56532ae32a08 v8::internal::Compiler::FinalizeOptimizedCompilationJob()
    21:26:22.252 27507   #10 0x56532ae228eb v8::internal::OptimizingCompileDispatcher::InstallOptimizedFunctions()
    21:26:22.252 27507   #11 0x56532af14e4a v8::internal::StackGuard::HandleInterrupts()
    21:26:22.252 27507   #12 0x56532b35f2ec v8::internal::__RT_impl_Runtime_StackGuard()
    21:26:22.252 27507   #13 0x56532bba6720 <unknown>
    
    Original change's description:
    > [wasm] Add stack guard for logging code
    > 
    > Benchmarks or worker threads might never return to the event queue,
    > hence they will never execute the scheduled foreground task to log
    > compiled and published wasm code.
    > This CL adds a stack guard to log the code, to ensure that we also log
    > it for wasm code that never returns to the event queue.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: v8:9104
    > Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60879}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: I63dc56a41747caf683b14869a2d62017fd0301c1
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9104
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570012Reviewed-by: 's avatarMichael Hablich <hablich@chromium.org>
    Commit-Queue: Michael Hablich <hablich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60890}
    6ce63fd8
execution.h 8.6 KB