• vogelheim's avatar
    Revert of Parser: Make skipping HTML comments optional. (patchset #6 id:140001... · 09ac4f29
    vogelheim authored
    Revert of Parser: Make skipping HTML comments optional. (patchset #6 id:140001 of https://codereview.chromium.org/1801203002/ )
    
    Reason for revert:
    Violates ES6 spec (crbug.com/4850), and implementation was over-eager. Will revert for now.
    
    Original issue's description:
    > Parser: Make skipping HTML comments optional.
    >
    > API change: This adds a new flag skip_html_comments to v8::ScriptOriginOptions. This flag controls whether V8 will attempt to honour HTML-style comments in JS sources.
    >
    > (That is: Gracefully ignore <!-- ... ---> in JS sources, which was a popular technique in the early days of JavaScript, to prevent non-JS-enabled browsers from displaying script sources to uses.)
    >
    > The flag defaults to 'true' when using v8::ScriptOrigin constructor, which preserves the existing behaviour. Embedders which are happy with the existing behaviour will thus not need any changes.
    >
    > BUG=chromium:573887
    > LOG=Y
    >
    > Committed: https://crrev.com/91d344288aa51ed03eaaa1cb3e368ac1e82f0173
    > Cr-Commit-Position: refs/heads/master@{#34904}
    
    TBR=jochen@chromium.org,rossberg@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=chromium:573887, v8:4850
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1817163003
    
    Cr-Commit-Position: refs/heads/master@{#34958}
    09ac4f29
parser.cc 253 KB