• vogelheim's avatar
    Revert of Parser: Make skipping HTML comments optional. (patchset #6 id:140001... · 09ac4f29
    vogelheim authored
    Revert of Parser: Make skipping HTML comments optional. (patchset #6 id:140001 of https://codereview.chromium.org/1801203002/ )
    
    Reason for revert:
    Violates ES6 spec (crbug.com/4850), and implementation was over-eager. Will revert for now.
    
    Original issue's description:
    > Parser: Make skipping HTML comments optional.
    >
    > API change: This adds a new flag skip_html_comments to v8::ScriptOriginOptions. This flag controls whether V8 will attempt to honour HTML-style comments in JS sources.
    >
    > (That is: Gracefully ignore <!-- ... ---> in JS sources, which was a popular technique in the early days of JavaScript, to prevent non-JS-enabled browsers from displaying script sources to uses.)
    >
    > The flag defaults to 'true' when using v8::ScriptOrigin constructor, which preserves the existing behaviour. Embedders which are happy with the existing behaviour will thus not need any changes.
    >
    > BUG=chromium:573887
    > LOG=Y
    >
    > Committed: https://crrev.com/91d344288aa51ed03eaaa1cb3e368ac1e82f0173
    > Cr-Commit-Position: refs/heads/master@{#34904}
    
    TBR=jochen@chromium.org,rossberg@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=chromium:573887, v8:4850
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1817163003
    
    Cr-Commit-Position: refs/heads/master@{#34958}
    09ac4f29
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...