js-typed-lowering-unittest.cc 27.1 KB
Newer Older
1 2 3 4
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

5
#include "src/compiler/js-typed-lowering.h"
6
#include "src/code-factory.h"
7
#include "src/compilation-dependencies.h"
8 9 10 11
#include "src/compiler/access-builder.h"
#include "src/compiler/js-graph.h"
#include "src/compiler/js-operator.h"
#include "src/compiler/machine-operator.h"
12
#include "src/compiler/node-properties.h"
13
#include "src/compiler/operator-properties.h"
14
#include "src/isolate-inl.h"
15 16
#include "test/unittests/compiler/compiler-test-utils.h"
#include "test/unittests/compiler/graph-unittest.h"
17
#include "test/unittests/compiler/node-test-utils.h"
18 19
#include "testing/gmock-support.h"

20
using testing::_;
21
using testing::BitEq;
22
using testing::IsNaN;
23

24 25 26 27 28 29 30 31

namespace v8 {
namespace internal {
namespace compiler {

namespace {

const ExternalArrayType kExternalArrayTypes[] = {
32 33 34
    kExternalUint8Array,   kExternalInt8Array,   kExternalUint16Array,
    kExternalInt16Array,   kExternalUint32Array, kExternalInt32Array,
    kExternalFloat32Array, kExternalFloat64Array};
35

36 37
const size_t kIndices[] = {0, 1, 42, 100, 1024};

38 39 40
Type* const kJSTypes[] = {Type::Undefined(), Type::Null(),   Type::Boolean(),
                          Type::Number(),    Type::String(), Type::Object()};

41
STATIC_ASSERT(LANGUAGE_END == 2);
42
const LanguageMode kLanguageModes[] = {SLOPPY, STRICT};
43 44 45 46

}  // namespace


47
class JSTypedLoweringTest : public TypedGraphTest {
48
 public:
49 50
  JSTypedLoweringTest()
      : TypedGraphTest(3), javascript_(zone()), deps_(isolate(), zone()) {}
51
  ~JSTypedLoweringTest() override {}
52 53 54

 protected:
  Reduction Reduce(Node* node) {
55
    MachineOperatorBuilder machine(zone());
56 57
    SimplifiedOperatorBuilder simplified(zone());
    JSGraph jsgraph(isolate(), graph(), common(), javascript(), &simplified,
58
                    &machine);
59
    // TODO(titzer): mock the GraphReducer here for better unit testing.
60
    GraphReducer graph_reducer(zone(), graph());
61
    JSTypedLowering reducer(&graph_reducer, &deps_,
62 63
                            JSTypedLowering::kDeoptimizationEnabled, &jsgraph,
                            zone());
64 65 66 67 68
    return reducer.Reduce(node);
  }

  Handle<JSArrayBuffer> NewArrayBuffer(void* bytes, size_t byte_length) {
    Handle<JSArrayBuffer> buffer = factory()->NewJSArrayBuffer();
69
    JSArrayBuffer::Setup(buffer, isolate(), true, bytes, byte_length);
70 71 72 73 74 75 76
    return buffer;
  }

  JSOperatorBuilder* javascript() { return &javascript_; }

 private:
  JSOperatorBuilder javascript_;
77
  CompilationDependencies deps_;
78 79 80
};


81 82 83
// -----------------------------------------------------------------------------
// JSToBoolean

84

85 86 87
TEST_F(JSTypedLoweringTest, JSToBooleanWithBoolean) {
  Node* input = Parameter(Type::Boolean(), 0);
  Node* context = Parameter(Type::Any(), 1);
88 89
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
90
  ASSERT_TRUE(r.Changed());
91
  EXPECT_EQ(input, r.replacement());
92 93 94
}


95 96 97
TEST_F(JSTypedLoweringTest, JSToBooleanWithOrderedNumber) {
  Node* input = Parameter(Type::OrderedNumber(), 0);
  Node* context = Parameter(Type::Any(), 1);
98 99
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
100 101 102 103 104
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(),
              IsBooleanNot(IsNumberEqual(input, IsNumberConstant(0.0))));
}

105 106 107 108 109 110
TEST_F(JSTypedLoweringTest, JSToBooleanWithNumber) {
  Node* input = Parameter(Type::Number(), 0);
  Node* context = Parameter(Type::Any(), 1);
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
  ASSERT_TRUE(r.Changed());
111
  EXPECT_THAT(r.replacement(), IsNumberToBoolean(input));
112
}
113

114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
TEST_F(JSTypedLoweringTest, JSToBooleanWithDetectableReceiverOrNull) {
  Node* input = Parameter(Type::DetectableReceiverOrNull(), 0);
  Node* context = Parameter(Type::Any(), 1);
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(),
              IsBooleanNot(IsReferenceEqual(input, IsNullConstant())));
}

TEST_F(JSTypedLoweringTest, JSToBooleanWithReceiverOrNullOrUndefined) {
  Node* input = Parameter(Type::ReceiverOrNullOrUndefined(), 0);
  Node* context = Parameter(Type::Any(), 1);
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(), IsBooleanNot(IsObjectIsUndetectable(input)));
}

133 134 135 136 137 138 139 140 141 142 143
TEST_F(JSTypedLoweringTest, JSToBooleanWithString) {
  Node* input = Parameter(Type::String(), 0);
  Node* context = Parameter(Type::Any(), 1);
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(),
              IsBooleanNot(IsReferenceEqual(
                  input, IsHeapConstant(factory()->empty_string()))));
}

144 145 146
TEST_F(JSTypedLoweringTest, JSToBooleanWithAny) {
  Node* input = Parameter(Type::Any(), 0);
  Node* context = Parameter(Type::Any(), 1);
147 148
  Reduction r = Reduce(graph()->NewNode(
      javascript()->ToBoolean(ToBooleanHint::kAny), input, context));
149
  ASSERT_FALSE(r.Changed());
150 151 152
}


153
// -----------------------------------------------------------------------------
154
// JSToName
155

156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189
TEST_F(JSTypedLoweringTest, JSToNameWithString) {
  Node* const input = Parameter(Type::String(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToName(), input, context,
                                        EmptyFrameState(), effect, control));
  ASSERT_TRUE(r.Changed());
  EXPECT_EQ(input, r.replacement());
}

TEST_F(JSTypedLoweringTest, JSToNameWithSymbol) {
  Node* const input = Parameter(Type::Symbol(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToName(), input, context,
                                        EmptyFrameState(), effect, control));
  ASSERT_TRUE(r.Changed());
  EXPECT_EQ(input, r.replacement());
}

TEST_F(JSTypedLoweringTest, JSToNameWithAny) {
  Node* const input = Parameter(Type::Any(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToName(), input, context,
                                        EmptyFrameState(), effect, control));
  ASSERT_FALSE(r.Changed());
}

// -----------------------------------------------------------------------------
// JSToNumber
190 191 192 193 194 195

TEST_F(JSTypedLoweringTest, JSToNumberWithPlainPrimitive) {
  Node* const input = Parameter(Type::PlainPrimitive(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
196
  Reduction r =
197 198
      Reduce(graph()->NewNode(javascript()->ToNumber(), input, context,
                              EmptyFrameState(), effect, control));
199
  ASSERT_TRUE(r.Changed());
200
  EXPECT_THAT(r.replacement(), IsPlainPrimitiveToNumber(input));
201 202 203
}


204 205 206 207 208 209 210 211 212 213 214 215 216
// -----------------------------------------------------------------------------
// JSToObject


TEST_F(JSTypedLoweringTest, JSToObjectWithAny) {
  Node* const input = Parameter(Type::Any(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const frame_state = EmptyFrameState();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToObject(), input,
                                        context, frame_state, effect, control));
  ASSERT_TRUE(r.Changed());
217
  EXPECT_THAT(r.replacement(), IsPhi(MachineRepresentation::kTagged, _, _, _));
218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233
}


TEST_F(JSTypedLoweringTest, JSToObjectWithReceiver) {
  Node* const input = Parameter(Type::Receiver(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const frame_state = EmptyFrameState();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToObject(), input,
                                        context, frame_state, effect, control));
  ASSERT_TRUE(r.Changed());
  EXPECT_EQ(input, r.replacement());
}


234 235 236 237 238 239 240 241 242 243 244 245 246
// -----------------------------------------------------------------------------
// JSToString


TEST_F(JSTypedLoweringTest, JSToStringWithBoolean) {
  Node* const input = Parameter(Type::Boolean(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const frame_state = EmptyFrameState();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToString(), input,
                                        context, frame_state, effect, control));
  ASSERT_TRUE(r.Changed());
247 248 249 250
  EXPECT_THAT(r.replacement(),
              IsSelect(MachineRepresentation::kTagged, input,
                       IsHeapConstant(factory()->true_string()),
                       IsHeapConstant(factory()->false_string())));
251 252
}

253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
// -----------------------------------------------------------------------------
// JSToPrimitiveToString

TEST_F(JSTypedLoweringTest, JSToPrimitiveToStringWithBoolean) {
  Node* const input = Parameter(Type::Boolean(), 0);
  Node* const context = Parameter(Type::Any(), 1);
  Node* const frame_state = EmptyFrameState();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  Reduction r = Reduce(graph()->NewNode(javascript()->ToString(), input,
                                        context, frame_state, effect, control));
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(),
              IsSelect(MachineRepresentation::kTagged, input,
                       IsHeapConstant(factory()->true_string()),
                       IsHeapConstant(factory()->false_string())));
}
270

271 272 273 274 275 276
// -----------------------------------------------------------------------------
// JSStrictEqual

TEST_F(JSTypedLoweringTest, JSStrictEqualWithTheHole) {
  Node* const the_hole = HeapConstant(factory()->the_hole_value());
  Node* const context = UndefinedConstant();
277 278
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
279 280
  TRACED_FOREACH(Type*, type, kJSTypes) {
    Node* const lhs = Parameter(type);
281 282 283
    Reduction r = Reduce(
        graph()->NewNode(javascript()->StrictEqual(CompareOperationHint::kAny),
                         lhs, the_hole, context, effect, control));
284 285 286 287 288 289
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(r.replacement(), IsFalseConstant());
  }
}


290 291 292 293
TEST_F(JSTypedLoweringTest, JSStrictEqualWithUnique) {
  Node* const lhs = Parameter(Type::Unique(), 0);
  Node* const rhs = Parameter(Type::Unique(), 1);
  Node* const context = Parameter(Type::Any(), 2);
294 295
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
296
  Reduction r = Reduce(
297
      graph()->NewNode(javascript()->StrictEqual(CompareOperationHint::kAny),
298
                       lhs, rhs, context, effect, control));
299
  ASSERT_TRUE(r.Changed());
300
  EXPECT_THAT(r.replacement(), IsReferenceEqual(lhs, rhs));
301 302 303
}


304 305 306 307 308 309 310 311
// -----------------------------------------------------------------------------
// JSShiftLeft

TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndConstant) {
  Node* const lhs = Parameter(Type::Signed32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
312
  TRACED_FORRANGE(double, rhs, 0, 31) {
313
    Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(), lhs,
314 315
                                          NumberConstant(rhs), context,
                                          EmptyFrameState(), effect, control));
316 317 318
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(r.replacement(),
                IsNumberShiftLeft(lhs, IsNumberConstant(BitEq(rhs))));
319 320 321 322 323 324 325 326 327
  }
}

TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndUnsigned32) {
  Node* const lhs = Parameter(Type::Signed32());
  Node* const rhs = Parameter(Type::Unsigned32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
328
  Reduction r =
329
      Reduce(graph()->NewNode(javascript()->ShiftLeft(), lhs, rhs, context,
330
                              EmptyFrameState(), effect, control));
331 332
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(), IsNumberShiftLeft(lhs, rhs));
333 334 335 336 337 338 339 340 341 342 343 344
}


// -----------------------------------------------------------------------------
// JSShiftRight


TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32AndConstant) {
  Node* const lhs = Parameter(Type::Signed32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
345
  TRACED_FORRANGE(double, rhs, 0, 31) {
346
    Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(), lhs,
347 348
                                          NumberConstant(rhs), context,
                                          EmptyFrameState(), effect, control));
349 350 351
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(r.replacement(),
                IsNumberShiftRight(lhs, IsNumberConstant(BitEq(rhs))));
352 353 354 355 356 357 358 359 360 361
  }
}


TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32AndUnsigned32) {
  Node* const lhs = Parameter(Type::Signed32());
  Node* const rhs = Parameter(Type::Unsigned32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
362
  Reduction r =
363
      Reduce(graph()->NewNode(javascript()->ShiftRight(), lhs, rhs, context,
364
                              EmptyFrameState(), effect, control));
365 366
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(), IsNumberShiftRight(lhs, rhs));
367 368 369 370 371 372 373
}


// -----------------------------------------------------------------------------
// JSShiftRightLogical


374 375
TEST_F(JSTypedLoweringTest,
                   JSShiftRightLogicalWithUnsigned32AndConstant) {
376 377 378 379
  Node* const lhs = Parameter(Type::Unsigned32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
380
  TRACED_FORRANGE(double, rhs, 0, 31) {
381
    Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRightLogical(),
382 383
                                          lhs, NumberConstant(rhs), context,
                                          EmptyFrameState(), effect, control));
384 385 386
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(r.replacement(),
                IsNumberShiftRightLogical(lhs, IsNumberConstant(BitEq(rhs))));
387 388 389 390
  }
}


391
TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithUnsigned32AndUnsigned32) {
392 393 394 395 396
  Node* const lhs = Parameter(Type::Unsigned32());
  Node* const rhs = Parameter(Type::Unsigned32());
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
397
  Reduction r =
398
      Reduce(graph()->NewNode(javascript()->ShiftRightLogical(), lhs, rhs,
399
                              context, EmptyFrameState(), effect, control));
400 401
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(), IsNumberShiftRightLogical(lhs, rhs));
402 403 404
}


405 406 407 408 409 410 411 412 413 414
// -----------------------------------------------------------------------------
// JSLoadContext


TEST_F(JSTypedLoweringTest, JSLoadContext) {
  Node* const context = Parameter(Type::Any());
  Node* const effect = graph()->start();
  static bool kBooleans[] = {false, true};
  TRACED_FOREACH(size_t, index, kIndices) {
    TRACED_FOREACH(bool, immutable, kBooleans) {
415 416
      Reduction const r1 = Reduce(graph()->NewNode(
          javascript()->LoadContext(0, index, immutable), context, effect));
417 418 419 420 421
      ASSERT_TRUE(r1.Changed());
      EXPECT_THAT(r1.replacement(),
                  IsLoadField(AccessBuilder::ForContextSlot(index), context,
                              effect, graph()->start()));

422 423
      Reduction const r2 = Reduce(graph()->NewNode(
          javascript()->LoadContext(1, index, immutable), context, effect));
424 425 426 427 428 429
      ASSERT_TRUE(r2.Changed());
      EXPECT_THAT(r2.replacement(),
                  IsLoadField(AccessBuilder::ForContextSlot(index),
                              IsLoadField(AccessBuilder::ForContextSlot(
                                              Context::PREVIOUS_INDEX),
                                          context, effect, graph()->start()),
430
                              _, graph()->start()));
431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448
    }
  }
}


// -----------------------------------------------------------------------------
// JSStoreContext


TEST_F(JSTypedLoweringTest, JSStoreContext) {
  Node* const context = Parameter(Type::Any());
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
  TRACED_FOREACH(size_t, index, kIndices) {
    TRACED_FOREACH(Type*, type, kJSTypes) {
      Node* const value = Parameter(type);

      Reduction const r1 =
449 450
          Reduce(graph()->NewNode(javascript()->StoreContext(0, index), value,
                                  context, effect, control));
451 452 453 454 455 456
      ASSERT_TRUE(r1.Changed());
      EXPECT_THAT(r1.replacement(),
                  IsStoreField(AccessBuilder::ForContextSlot(index), context,
                               value, effect, control));

      Reduction const r2 =
457 458
          Reduce(graph()->NewNode(javascript()->StoreContext(1, index), value,
                                  context, effect, control));
459 460 461 462 463 464
      ASSERT_TRUE(r2.Changed());
      EXPECT_THAT(r2.replacement(),
                  IsStoreField(AccessBuilder::ForContextSlot(index),
                               IsLoadField(AccessBuilder::ForContextSlot(
                                               Context::PREVIOUS_INDEX),
                                           context, effect, graph()->start()),
465
                               value, _, control));
466 467 468 469 470
    }
  }
}


471 472 473 474 475 476
// -----------------------------------------------------------------------------
// JSLoadProperty


TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArray) {
  const size_t kLength = 17;
477
  double backing_store[kLength];
478
  Handle<JSArrayBuffer> buffer =
479
      NewArrayBuffer(backing_store, sizeof(backing_store));
480
  VectorSlotPair feedback;
481
  TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {
482 483 484 485 486 487 488 489 490 491
    Handle<JSTypedArray> array =
        factory()->NewJSTypedArray(type, buffer, 0, kLength);
    int const element_size = static_cast<int>(array->element_size());

    Node* key = Parameter(
        Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));
    Node* base = HeapConstant(array);
    Node* context = UndefinedConstant();
    Node* effect = graph()->start();
    Node* control = graph()->start();
492 493 494
    Reduction r =
        Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,
                                context, EmptyFrameState(), effect, control));
495

496 497 498
    Matcher<Node*> offset_matcher =
        element_size == 1
            ? key
499 500
            : IsNumberShiftLeft(key,
                                IsNumberConstant(WhichPowerOf2(element_size)));
501

502 503 504 505
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(
        r.replacement(),
        IsLoadBuffer(BufferAccess(type),
506
                     IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
507 508 509
                     offset_matcher,
                     IsNumberConstant(array->byte_length()->Number()), effect,
                     control));
510 511 512 513 514 515 516 517 518
  }
}


TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArrayWithSafeKey) {
  const size_t kLength = 17;
  double backing_store[kLength];
  Handle<JSArrayBuffer> buffer =
      NewArrayBuffer(backing_store, sizeof(backing_store));
519
  VectorSlotPair feedback;
520
  TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {
521 522 523 524 525 526 527 528 529 530 531 532
    Handle<JSTypedArray> array =
        factory()->NewJSTypedArray(type, buffer, 0, kLength);
    ElementAccess access = AccessBuilder::ForTypedArrayElement(type, true);

    int min = random_number_generator()->NextInt(static_cast<int>(kLength));
    int max = random_number_generator()->NextInt(static_cast<int>(kLength));
    if (min > max) std::swap(min, max);
    Node* key = Parameter(Type::Range(min, max, zone()));
    Node* base = HeapConstant(array);
    Node* context = UndefinedConstant();
    Node* effect = graph()->start();
    Node* control = graph()->start();
533 534 535
    Reduction r =
        Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,
                                context, EmptyFrameState(), effect, control));
536

537 538 539 540
    ASSERT_TRUE(r.Changed());
    EXPECT_THAT(
        r.replacement(),
        IsLoadElement(access,
541
                      IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
542
                      key, effect, control));
543 544 545 546 547 548 549 550 551 552
  }
}


// -----------------------------------------------------------------------------
// JSStoreProperty


TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {
  const size_t kLength = 17;
553
  double backing_store[kLength];
554
  Handle<JSArrayBuffer> buffer =
555
      NewArrayBuffer(backing_store, sizeof(backing_store));
556
  TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {
557
    TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
558
      Handle<JSTypedArray> array =
559
          factory()->NewJSTypedArray(type, buffer, 0, kLength);
560
      int const element_size = static_cast<int>(array->element_size());
561

562
      Node* key = Parameter(
563
          Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));
564
      Node* base = HeapConstant(array);
565 566
      Node* value =
          Parameter(AccessBuilder::ForTypedArrayElement(type, true).type);
567 568 569
      Node* context = UndefinedConstant();
      Node* effect = graph()->start();
      Node* control = graph()->start();
570
      VectorSlotPair feedback;
571
      const Operator* op = javascript()->StoreProperty(language_mode, feedback);
572
      Node* node = graph()->NewNode(op, base, key, value, context,
573
                                    EmptyFrameState(), effect, control);
574 575
      Reduction r = Reduce(node);

576 577 578
      Matcher<Node*> offset_matcher =
          element_size == 1
              ? key
579 580
              : IsNumberShiftLeft(
                    key, IsNumberConstant(WhichPowerOf2(element_size)));
581

582
      ASSERT_TRUE(r.Changed());
583 584
      EXPECT_THAT(
          r.replacement(),
585 586 587 588 589
          IsStoreBuffer(
              BufferAccess(type),
              IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
              offset_matcher, IsNumberConstant(array->byte_length()->Number()),
              value, effect, control));
590 591 592 593
    }
  }
}

594 595 596 597 598 599 600

TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
  const size_t kLength = 17;
  double backing_store[kLength];
  Handle<JSArrayBuffer> buffer =
      NewArrayBuffer(backing_store, sizeof(backing_store));
  TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {
601
    TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
602 603
      Handle<JSTypedArray> array =
          factory()->NewJSTypedArray(type, buffer, 0, kLength);
604
      int const element_size = static_cast<int>(array->element_size());
605

606
      Node* key = Parameter(
607
          Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));
608
      Node* base = HeapConstant(array);
609
      Node* value = Parameter(Type::PlainPrimitive());
610 611 612
      Node* context = UndefinedConstant();
      Node* effect = graph()->start();
      Node* control = graph()->start();
613
      VectorSlotPair feedback;
614
      const Operator* op = javascript()->StoreProperty(language_mode, feedback);
615
      Node* node = graph()->NewNode(op, base, key, value, context,
616
                                    EmptyFrameState(), effect, control);
617 618
      Reduction r = Reduce(node);

619 620 621
      Matcher<Node*> offset_matcher =
          element_size == 1
              ? key
622 623
              : IsNumberShiftLeft(
                    key, IsNumberConstant(WhichPowerOf2(element_size)));
624

625
      Matcher<Node*> value_matcher = IsPlainPrimitiveToNumber(value);
626 627

      ASSERT_TRUE(r.Changed());
628 629
      EXPECT_THAT(
          r.replacement(),
630 631 632 633
          IsStoreBuffer(
              BufferAccess(type),
              IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
              offset_matcher, IsNumberConstant(array->byte_length()->Number()),
634
              value_matcher, effect, control));
635 636 637 638 639 640 641 642 643 644 645
    }
  }
}


TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {
  const size_t kLength = 17;
  double backing_store[kLength];
  Handle<JSArrayBuffer> buffer =
      NewArrayBuffer(backing_store, sizeof(backing_store));
  TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {
646
    TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
647 648 649 650 651 652 653
      Handle<JSTypedArray> array =
          factory()->NewJSTypedArray(type, buffer, 0, kLength);
      ElementAccess access = AccessBuilder::ForTypedArrayElement(type, true);

      int min = random_number_generator()->NextInt(static_cast<int>(kLength));
      int max = random_number_generator()->NextInt(static_cast<int>(kLength));
      if (min > max) std::swap(min, max);
654
      Node* key = Parameter(Type::Range(min, max, zone()));
655 656 657 658 659
      Node* base = HeapConstant(array);
      Node* value = Parameter(access.type);
      Node* context = UndefinedConstant();
      Node* effect = graph()->start();
      Node* control = graph()->start();
660
      VectorSlotPair feedback;
661
      const Operator* op = javascript()->StoreProperty(language_mode, feedback);
662
      Node* node = graph()->NewNode(op, base, key, value, context,
663
                                    EmptyFrameState(), effect, control);
664 665 666 667 668 669
      Reduction r = Reduce(node);

      ASSERT_TRUE(r.Changed());
      EXPECT_THAT(
          r.replacement(),
          IsStoreElement(
670
              access, IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
671
              key, value, effect, control));
672 673 674 675
    }
  }
}

676

677 678 679 680 681 682
// -----------------------------------------------------------------------------
// JSLoadNamed


TEST_F(JSTypedLoweringTest, JSLoadNamedStringLength) {
  VectorSlotPair feedback;
683
  Handle<Name> name = factory()->length_string();
684 685 686 687
  Node* const receiver = Parameter(Type::String(), 0);
  Node* const context = UndefinedConstant();
  Node* const effect = graph()->start();
  Node* const control = graph()->start();
688 689 690
  Reduction const r =
      Reduce(graph()->NewNode(javascript()->LoadNamed(name, feedback), receiver,
                              context, EmptyFrameState(), effect, control));
691 692 693
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(), IsLoadField(AccessBuilder::ForStringLength(),
                                           receiver, effect, control));
694
}
695

696 697 698 699 700 701

// -----------------------------------------------------------------------------
// JSAdd


TEST_F(JSTypedLoweringTest, JSAddWithString) {
702
  BinaryOperationHint const hint = BinaryOperationHint::kAny;
703 704 705 706 707 708
  Node* lhs = Parameter(Type::String(), 0);
  Node* rhs = Parameter(Type::String(), 1);
  Node* context = Parameter(Type::Any(), 2);
  Node* frame_state = EmptyFrameState();
  Node* effect = graph()->start();
  Node* control = graph()->start();
709
  Reduction r = Reduce(graph()->NewNode(javascript()->Add(hint), lhs, rhs,
710 711 712 713 714 715 716 717
                                        context, frame_state, effect, control));
  ASSERT_TRUE(r.Changed());
  EXPECT_THAT(r.replacement(),
              IsCall(_, IsHeapConstant(
                            CodeFactory::StringAdd(
                                isolate(), STRING_ADD_CHECK_NONE, NOT_TENURED)
                                .code()),
                     lhs, rhs, context, frame_state, effect, control));
718 719
}

720 721 722
}  // namespace compiler
}  // namespace internal
}  // namespace v8