Skip to content

F
ffmpeg.wasm-core
Switch branch/tag
  1. 11 Aug, 2019 14 commits
  3. 10 Aug, 2019 7 commits
  5. 09 Aug, 2019 2 commits
    • Olivier Maignial's avatar
      avformat/rtpdec_mpeg4: Fix integer parameters size check in SDP fmtp line · c29d81e7
      Olivier Maignial authored 
      === PROBLEM ===

I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line:
    ffmpeg -v verbose -y -i "rtsp://<ip>/my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4

FFmpeg then fail to record audio and output this logs:
    [rtsp @ 0xcda1f0] The profile-level-id field size is invalid (40)
    [rtsp @ 0xcda1f0] Error parsing AU headers
    ...
    [rtsp @ 0xcda1f0] Could not find codec parameters for stream 1 (Audio: aac, 48000 Hz, 1 channels): unspecified sample format

In SDP provided by my RTSP server I had this fmtp line:
    a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188; sizeLength=13; indexLength=3; indexDeltaLength=3;

In FFmpeg code, I found a check introduced by commit 24130234. It disallows values greater than 32 for fmtp line parameters.
RFC-4566 (SDP: Session Description Protocol) do not give any limit of size on interger parameters given in an fmtp line.

However, In RFC-6416 (RTP Payload Format for MPEG-4 Audio/Visual Streams) give examples of "profile-level-id" values for AAC, up to 55.

=== FIX ===

As each parameter may have its own min and max values
I propose to introduce a range for each parameter.
For this patch I used RFC-3640 and ISO/IEC 14496-1 as reference for validity ranges.

This patch fix my problem and I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: 's avatarOlivier Maignial <olivier.maignial@smile.fr>
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
      c29d81e7
    • Andriy Gelman's avatar
      tools/zmqsend: Avoid mem copy past the end of input buffer · 90e965be
      Andriy Gelman authored 
      This patch avoids a read past the end of the input buffer in memcpy since the size
of the received zmq message is recv_buf_size - 1.
Reviewed-by: 's avatarPaul B Mahol <onemda@gmail.com>
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
      90e965be
  7. 08 Aug, 2019 6 commits
  9. 07 Aug, 2019 2 commits
    • Linjie Fu's avatar
      lavf/vf_vpp_qsv: add support for QSV transpose filter · af3ddd58
      Linjie Fu authored 
      Add transpose support for qsv_vpp with rotate and hflip:
    - rotate: [0, 3] support clockwise rotation of 0, 90, 180, 270;
    - hflip:  [0, 1] support horizontal flip;

Configure with:
{"cclock_hflip","clock","cclock","clock_hflip","reversal","hflip","vflip"}

CMD:
ffmpeg -hwaccel qsv -c:v h264_qsv -i input.h264
    -vf 'format=qsv,vpp_qsv=transpose=clock' -c:v h264_qsv output.h264

ffmpeg -init_hw_device qsv=hw -filter_hw_device hw -c:v h264_qsv -i input.h264
    -vf 'hwupload=extra_hw_frames=64,format=qsv,vpp_qsv=transpose=cclock_hflip'
                            -f rawvideo -pix_fmt nv12 ./transpose.yuv
Signed-off-by: 's avatarLinjie Fu <linjie.fu@intel.com>
Signed-off-by: 's avatarZhong Li <zhong.li@intel.com>
      af3ddd58
    • Ruiling Song's avatar
      avfilter/vf_convolution: add x86 SIMD for filter_3x3() · 98e419cb
      Ruiling Song authored 
      Tested using a simple command (apply edge enhance):
./ffmpeg_g -i ~/Downloads/bbb_sunflower_1080p_30fps_normal.mp4 \
 -vf convolution="0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:5:1:1:1:0:128:128:128" \
 -an -vframes 1000 -f null /dev/null

The fps increase from 151 to 270 on my local machine.
Signed-off-by: 's avatarRuiling Song <ruiling.song@intel.com>
      98e419cb
  11. 06 Aug, 2019 1 commit
  13. 05 Aug, 2019 8 commits