• Olivier Maignial's avatar
    avformat/rtpdec_mpeg4: Fix integer parameters size check in SDP fmtp line · c29d81e7
    Olivier Maignial authored
    === PROBLEM ===
    
    I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line:
        ffmpeg -v verbose -y -i "rtsp://<ip>/my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4
    
    FFmpeg then fail to record audio and output this logs:
        [rtsp @ 0xcda1f0] The profile-level-id field size is invalid (40)
        [rtsp @ 0xcda1f0] Error parsing AU headers
        ...
        [rtsp @ 0xcda1f0] Could not find codec parameters for stream 1 (Audio: aac, 48000 Hz, 1 channels): unspecified sample format
    
    In SDP provided by my RTSP server I had this fmtp line:
        a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188; sizeLength=13; indexLength=3; indexDeltaLength=3;
    
    In FFmpeg code, I found a check introduced by commit 24130234. It disallows values greater than 32 for fmtp line parameters.
    RFC-4566 (SDP: Session Description Protocol) do not give any limit of size on interger parameters given in an fmtp line.
    
    However, In RFC-6416 (RTP Payload Format for MPEG-4 Audio/Visual Streams) give examples of "profile-level-id" values for AAC, up to 55.
    
    === FIX ===
    
    As each parameter may have its own min and max values
    I propose to introduce a range for each parameter.
    For this patch I used RFC-3640 and ISO/IEC 14496-1 as reference for validity ranges.
    
    This patch fix my problem and I now can record my RTSP AAC stream to mp4.
    It has passed the full fate tests suite sucessfully.
    Signed-off-by: 's avatarOlivier Maignial <olivier.maignial@smile.fr>
    Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    c29d81e7
Name
Last commit
Last update
compat Loading commit data...
doc Loading commit data...
ffbuild Loading commit data...
fftools Loading commit data...
libavcodec Loading commit data...
libavdevice Loading commit data...
libavfilter Loading commit data...
libavformat Loading commit data...
libavresample Loading commit data...
libavutil Loading commit data...
libpostproc Loading commit data...
libswresample Loading commit data...
libswscale Loading commit data...
presets Loading commit data...
tests Loading commit data...
tools Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYING.GPLv2 Loading commit data...
COPYING.GPLv3 Loading commit data...
COPYING.LGPLv2.1 Loading commit data...
COPYING.LGPLv3 Loading commit data...
CREDITS Loading commit data...
Changelog Loading commit data...
INSTALL.md Loading commit data...
LICENSE.md Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
RELEASE Loading commit data...
configure Loading commit data...