- 31 May, 2017 7 commits
-
-
Pierre-Antoine Manzagol authored
_CalculateAddedDeps calls into depot tools' scm.py GetOldContents to compare previous and current versions of the DEPS file. GetOldContents attempts to 'git show <sha>:<path>'. The problem on Windows is that path uses '\' but git show seems to want a posix path. Git show therefore doesn't find the file and returns an empty output, leading presubmit to think all the deps are new. Bug:725933 Change-Id: Ifbbfbcba4be466d9be623826818fd191bd2ca525 Reviewed-on: https://chromium-review.googlesource.com/514142 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8d7bd42ec1713294cf6cb36127c96a1f439f9419 Enable unbuffered output for bundled recipes. (benjaminwagner@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I13297698e934ae231178838d2e74e02044646afd Reviewed-on: https://chromium-review.googlesource.com/519824Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Quinten Yearsley authored
This mostly changes simple typos, e.g.: strack->stack assosiated->associated unsettin->unsetting diangose->diagnose desciption->description commment->comment This CL also changes some docstrings and capitalizes some printed messages. Change-Id: I758b47f069a6de2d0d94a76ff85587bdc51c9daf Reviewed-on: https://chromium-review.googlesource.com/519614 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Quinten Yearsley authored
For a bit of context, see the TODO in the code -- I think that the original intent of that TODO was that we to make the way that CQ dry runs are triggered consistent, and also make the behavior of dry runs consistent across different commands. Change-Id: I80dfc31ade302a6af7fa84011e2871d416ea9c96 Reviewed-on: https://chromium-review.googlesource.com/518930 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/84a695b241eb61b3b6d1a0fa9d63ef572d26cdbd [loader] Make recipe engine support examples/ module subdir (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifedefe752fc745708ea367e2a978b5511732d12a Reviewed-on: https://chromium-review.googlesource.com/519683Reviewed-by:
-
Paweł Hajdan, Jr authored
Some recipes interacting with older revisions (e.g. bisect) will need this. Bug: 570091 Change-Id: I38e5ffa2db1a9bfae3667f015f00977c32ebe51e Reviewed-on: https://chromium-review.googlesource.com/519407 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Francois Doray authored
`git cl split` splits a branch into smaller branches and uploads CLs. Change-Id: Ic41cdabdd6241008ff48766e31a8d9d07995f2b0 Reviewed-on: https://chromium-review.googlesource.com/439706 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 30 May, 2017 2 commits
-
-
Bruce Dawson authored
VS 2017 Preview installs to a different directory from VS 2017 RTM, so the packaging script needs to be updated to handle this. It does this by using vswhere.exe so that any VS 2017 install can be found automatically. If there are multiple installs then it is not well defined which one will be found, so make sure you don't have multiple installs. The other change is to more robustly find the many directory paths which contain embedded version numbers. Previously these were hard-coded for VS 2017 RTM but this quickly gets tedious so now glob.glob is used to find the matching directories. This will intentionally fail if there is any ambiguity. R=scottmg@chromium.org BUG=683729 Change-Id: I02f7ae7589e271d6d9897f899e0730d7163f76ef Reviewed-on: https://chromium-review.googlesource.com/516442 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 727685, 570091 Change-Id: I97a99d15930c1662c0ecfacd3755af27b282f686 Reviewed-on: https://chromium-review.googlesource.com/517800Reviewed-by:
Paul Hobbs <phobbs@google.com> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 29 May, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
This is a follow-up after https://chromium-review.googlesource.com/c/517049/ Bug: 727334, 570091 Change-Id: I49f9ad07f1b79cba547d88e93b2d2064c33e1f4b Reviewed-on: https://chromium-review.googlesource.com/518125Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib3296a201bdcbd4ec350ee0e98112a89e388fd61 Reviewed-on: https://chromium-review.googlesource.com/517049Reviewed-by:
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509451 Please pass --disable-syntax-validation as an escape hatch. Bug: 570091 Change-Id: Ia9812506347685c31907225837ed50a0510952ee Reviewed-on: https://chromium-review.googlesource.com/517950Reviewed-by:
-
- 27 May, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5da7e1fbc1f0e8b14d0ac6c1dc770ce9ca39d6ac Remove "Recipe Roll Downstream Tester" builder (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I34ed90f4533863c47790b642daf0fb6222f07069 Reviewed-on: https://chromium-review.googlesource.com/517862Reviewed-by:
-
Robert Iannucci authored
TBR=dnj@chromium.org, nodir@chromium.org Bug: Change-Id: I4f1dada9e4aa395e796c93a0a54e0b6899ac6597 Reviewed-on: https://chromium-review.googlesource.com/517235Reviewed-by:
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 662654 Change-Id: I18898cb426ccbb895a82410dc61910a8b8e48f14 Reviewed-on: https://chromium-review.googlesource.com/517664 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
- 25 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This should make error messages more friendly and easier to address. Bug: 570091 Change-Id: Id43d6ecdc5521b07fbe684b6fdbcc09f6fbc6448 Reviewed-on: https://chromium-review.googlesource.com/513907Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 24 May, 2017 2 commits
-
-
Dan Jacques authored
Several boilerplate batch files include a provision to prepend "depot_tools" to PATH prior to running those tools. This undermines the utility of PATH overrides, since these tools specifically force their "depot_tools" sub-paths to be used regardless of environment. The origin of this behavior is likely limited to a specific fix for a specific problem, but was then perpetuated by the copy/paste of boilerplate bootstrap code as more bootstraps were added. This is important in upcoming configurations, where core tools such as Python and Git will be overridden via PATH on the bots. Cygwin users who depended on this behavior should just add "depot_tools" to their PATH in the appropriate location (i.e. in their .bashrc). BUG=chromium:714293, chromium:724902 TEST=None Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537 Reviewed-on: https://chromium-review.googlesource.com/510290 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
If the repo is a btrfs subvolume, take a snapshot instead of using "cp --reflink". Taking a snapshot is much faster, and uses less disk space for metadata. Bug: 721585 Change-Id: I97753dc30d46ff56d84d65f8d815c19d09cf104b Reviewed-on: https://chromium-review.googlesource.com/513586Reviewed-by:
-
- 23 May, 2017 13 commits
-
-
Aaron Gable authored
The private mode is a better fit for how we want private (e.g. security-critical) changes to be reviewed. Draft was simply a placeholder until private was ready for use, which it now is. Bug: 721880, 722627 Change-Id: Ib7b76c555437f4ddc7ab2b0e7ce5a9f9ee8be825 Reviewed-on: https://chromium-review.googlesource.com/513243 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrew Bonventre <andybons@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
When the repo is copied in copy-on-write mode, print informative messages afterwards to help users. Also, skip "git clean" step in copy-on-write mode. Bug: 721585, 723856 Change-Id: I3235398c960d59a4cf44cfe7dffc79ed008a5190 Reviewed-on: https://chromium-review.googlesource.com/512262Reviewed-by:
-
Paweł Hajdan, Jr authored
- allow None in deps_os values (for chromeos buildspecs) - allow string formatting (%) in expressions (for dart) - allow empty lists/dicts (for build slaves) - allow target_os (for internal android) Bug: 570091, 722206, 725422 Change-Id: I7f3d822a1c4aac16fddd96ef2f9f365e05b2d0e8 Reviewed-on: https://chromium-review.googlesource.com/512724Reviewed-by:
-
Paweł Hajdan, Jr authored
This relands the safe portion of outage-causing https://chromium-review.googlesource.com/c/509451/ Landing this simple CL will allow pre-emptively adding escape hatch to critical places (such as update_scripts) to make relanding validation safer. Bug: 570091 Change-Id: I4d963bd9b140b7b6bca35d4d5e41768bc1a3d7e0 Reviewed-on: https://chromium-review.googlesource.com/512744 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509693 This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I0d83b537b57d0b9ca65c7101d13e0ad6c1642a29 Reviewed-on: https://chromium-review.googlesource.com/512842Reviewed-by:
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509614 This feature seems to be unused, and removing it will simplify handling hooks a little bit. Bug: 661382 Change-Id: I7f02b34fc399c78bef76420df19a93105ab098ac Reviewed-on: https://chromium-review.googlesource.com/512644Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 568e5919. Reason for revert: maybe caused outage Original change's description: > gclient validate: allow None in deps_os values > > Bug: 722206 > Change-Id: I15024670e481c166ca34a2ec8dac93c739684121 > Reviewed-on: https://chromium-review.googlesource.com/509537 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 722206 Change-Id: Ia0f3825d204e65575020d108873dee82da47a1e6 Reviewed-on: https://chromium-review.googlesource.com/512345Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 3e6d7c1c. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for $matching_files in hooks > > This feature seems to be unused, and removing it will > simplify handling hooks a little bit. > > Bug: 661382 > Change-Id: I89f28dedb7f59cd475b176cfb1f023094520d6b7 > Reviewed-on: https://chromium-review.googlesource.com/509614 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I47fe26e7381682b5b428a3775bf27a551c57d5e6 Reviewed-on: https://chromium-review.googlesource.com/512344Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit bf72b593. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for From() > > This feature appears unused, and removing it will simplify the codebase. > > Bug: 661382 > Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 > Reviewed-on: https://chromium-review.googlesource.com/509693 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I4db9554a0a3a64a3a69908560b6da2a9963518f2 Reviewed-on: https://chromium-review.googlesource.com/512343Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 8db72efd. Reason for revert: maybe caused outage. Original change's description: > gclient: enable syntax validation by default > > Please pass --disable-syntax-validation as an escape hatch. > > Bug: 570091 > Change-Id: Iceadc0d2fc54ca68e775c3bc7590f4329ddb4951 > Reviewed-on: https://chromium-review.googlesource.com/509451 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 570091 Change-Id: I5b91653839f09a29c4c633fba91b23260ba96761 Reviewed-on: https://chromium-review.googlesource.com/512342Reviewed-by:
-
Paweł Hajdan, Jr authored
Please pass --disable-syntax-validation as an escape hatch. Bug: 570091 Change-Id: Iceadc0d2fc54ca68e775c3bc7590f4329ddb4951 Reviewed-on: https://chromium-review.googlesource.com/509451 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 Reviewed-on: https://chromium-review.googlesource.com/509693 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
This feature seems to be unused, and removing it will simplify handling hooks a little bit. Bug: 661382 Change-Id: I89f28dedb7f59cd475b176cfb1f023094520d6b7 Reviewed-on: https://chromium-review.googlesource.com/509614Reviewed-by:
-
- 22 May, 2017 5 commits
-
-
Paweł Hajdan, Jr authored
Bug: 722206 Change-Id: I15024670e481c166ca34a2ec8dac93c739684121 Reviewed-on: https://chromium-review.googlesource.com/509537Reviewed-by:
-
Aaron Gable authored
To encourage folks to upload to Gerrit. Bug: 685321 Change-Id: I849ed53f95a2205959237fe825ffe41e349ff8c7 Reviewed-on: https://chromium-review.googlesource.com/510963Reviewed-by:
-
Aaron Gable authored
This information is redundant when using Gerrit, and is well known to anyone still using Rietveld. Change-Id: I03119a84edb67fd20fbe5e2a8e0f0975e69558ed Reviewed-on: https://chromium-review.googlesource.com/510923Reviewed-by:
-
Dan Jacques authored
Currently, the "cipd" recipe module allows a package to be created by adding directories to a PackageDefinition via "add_dir". However, there is no current way to add the entirety of a root directory to a package. The PackageDefinition will generate a relative path of "''", which CIPD will reject as empty. Make it so that if the user supplies the root directory as the directory to add to the package, it properly includes it as ".". BUG=None TEST=local - Ran recipe with this modification, seems to work R=iannucci@chromium.org, nodir@chromium.org, vadimsh@chromium.org Change-Id: Ib5c72038cf153776808f084db835c60f61fd9044 Reviewed-on: https://chromium-review.googlesource.com/510309Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
Aaron Gable authored
We usually only retry on server errors. But most 404s that clients will recieve are due to replication lag, not due to querying an issue that truly doesn't exist. This CL lets gerrit_util (which is used primarily by git-cl) to retry on 404s to help fight errors due to replication lag. R=tandrii@chromium.org Bug: 717197 Change-Id: I26dbbf6c4895a13f7d57e4be3c23450111c949bc Reviewed-on: https://chromium-review.googlesource.com/510000Reviewed-by:
-
- 19 May, 2017 2 commits
-
-
Aaron Gable authored
This gives PRESUBMIT equal support for all the gerrit-style footers that we're migrating to. R=iannucci@chromium.org, tandrii@chromium.org Bug: 710327,710803 Change-Id: I64b8f39ef923d90ebda7dd191b83d1a7cc87c776 Reviewed-on: https://chromium-review.googlesource.com/506551Reviewed-by:
-
Dan Jacques authored
All known repositories have been switched to "recipe_engine/url". BUG=None TEST=None R=iannucci@chromium.org Change-Id: Ibed376b916f59b5d7142aa2ffd210919079a0862 Reviewed-on: https://chromium-review.googlesource.com/508163Reviewed-by:
-
- 18 May, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This is based on https://codereview.chromium.org/2474543002/ Bug: 661382 Change-Id: I191ec16e0ce69a782979ae7d59b108747429ab78 Reviewed-on: https://chromium-review.googlesource.com/505067 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
Aaron Gable authored
We want PRESUBMIT to be able to equally support BUG= tags (old style) and Git-Footer: footers (new style). This change refactors the way that the presubmit api gives access to those properties so that it is easier to add support for equivalent footers. It also limits the scope of tags/footers that it exposes, as code search shows no PRESUBMIT files that take advantage of any of the more esoteric ones. Bug: 710327, 710803 Change-Id: I86f1d6cb2e1f0aff9653ef3fb455e0a6f47acf5d Reviewed-on: https://chromium-review.googlesource.com/506450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
