Commits · ea4fc839cea2cf3f35d89682c335bca4e539fe7d · Linshizhi / Chromium_Depot_tools

02 Dec, 2016 1 commit

Gerrit git cl desc: don't notify reviwers. · ea4fc839

Andrii Shyshkalov authored Dec 01, 2016

R=agable@chromium.org
BUG=644101
TEST=manual

Change-Id: I82b7209981a834c8f26d65d2701d665a4eb2ba51
Reviewed-on: https://chromium-review.googlesource.com/415829Reviewed-by: Aaron Gable <agable@chromium.org>

ea4fc839

01 Dec, 2016 2 commits

WebRTC: Make got_revision be a WebRTC revision for bots in chromium.webrtc.fyi · b6849ac4

Henrik Kjellander authored Dec 01, 2016

This is needed in order to be able to use the set_component_rev feature in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=0&l=169
which is needed for having the testers to sync the same WebRTC revision
as the builders.

This is a follow-up for https://chromium-review.googlesource.com/c/414110

BUG=chromium:669818
TBR=tandrii@chromium.org

Change-Id: I6ca77e739513009e503a3b2a6fedacde8730e9a4
Reviewed-on: https://chromium-review.googlesource.com/415788Reviewed-by: Henrik Kjellander <kjellander-cc@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org>

b6849ac4

Make Tester bots in chromium.webrtc.fyi sync the right revisions. · 5f5b83bb

Henrik Kjellander authored Nov 30, 2016

BUG=chromium:669818
TBR=tandrii@chromium.org

Change-Id: Icbefd12bd891c8fdb7b8278083f8b1accb53500c
Reviewed-on: https://chromium-review.googlesource.com/414110
Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

5f5b83bb

29 Nov, 2016 3 commits

Fix bug in is_transient check of rietveld rpc errors. · 1bf69a12

Andrii Shyshkalov authored Nov 29, 2016

R=katthomas@chromium.org,sergiyb@chromium.org
BUG=chromium:601260

Change-Id: I79e1e807d1f8aed8d294742974d1f42a852c6b13
Reviewed-on: https://chromium-review.googlesource.com/415147
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

1bf69a12

Only add master. prefix unless one is already specified · 935b93fb

Sergiy Byelozyorov authored Nov 28, 2016

BUG=668162

Change-Id: Ie38542eb4627aa8c07adf9d2665b80cdcee2758f
Reviewed-on: https://chromium-review.googlesource.com/414355
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

935b93fb

Use 'change' instead of 'issue' when talking about Gerrit CLs · a45ee11d

Aaron Gable authored Nov 22, 2016

Change-Id: I17884d9ef7efdaf75ed575e66aca1034db0672b5
Reviewed-on: https://chromium-review.googlesource.com/413289Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

a45ee11d

28 Nov, 2016 2 commits

Retry up to three times on upload timeout. · a719d3dc

Mike Stipicevic authored Nov 28, 2016

BUG=668526

Change-Id: Id49f1c1394a72880410eb06ba7356307fff7e8c5
Reviewed-on: https://chromium-review.googlesource.com/414496
Commit-Queue: Mike Stipicevic <stip@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

a719d3dc

Bump timeout to upload files to Rietveld · 1f14230d

Sergiy Byelozyorov authored Nov 28, 2016

BUG=668526

Change-Id: I8aa762e8836ddc4838baaca803de17f3ffcb1ad2
Reviewed-on: https://chromium-review.googlesource.com/414908Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

1f14230d

24 Nov, 2016 4 commits

Use codereview.settings style for GENERATE_GIT_NUMBER_FOOTERS. · b8c535f6

Andrii Shyshkalov authored Nov 24, 2016

R=sergiyb@chromium.org
BUG=642493

Change-Id: Ic4acf4076fdf27c1ed5e75f0ed1dda4b16d675fc
Reviewed-on: https://chromium-review.googlesource.com/414469Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

b8c535f6

git cl: rework setting to auto-generate git number footers. · 5fb47748

Andrii Shyshkalov authored Nov 24, 2016

BUG=642493

Change-Id: I1c83c54f7ad938cf4abeadb42f8d9414521d6dc5
Reviewed-on: https://chromium-review.googlesource.com/414465Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

5fb47748

git cl land + gnumbd: add asserts. · 813ec3c3

Andrii Shyshkalov authored Nov 24, 2016

BUG=642493

Change-Id: Ib1234922e4bcd4ee286fffb8f7c637e4d2442a42
Reviewed-on: https://chromium-review.googlesource.com/414504
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

813ec3c3

git cl land: add test expectations for Rietveld. · 06a2502f

Andrii Shyshkalov authored Nov 24, 2016

This is preperatory work for Cr- footers generation in git cl instead
of gnumbd.

BUG=642493

Change-Id: I4cfdd882fe6caa7972e51ffa81d335104ddb56dd
Reviewed-on: https://chromium-review.googlesource.com/414464
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

06a2502f

22 Nov, 2016 1 commit

Remove SVN support from PRESUBMIT · 0b65e732

agable authored Nov 22, 2016

R=maruel@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2394043002

0b65e732

21 Nov, 2016 1 commit

Allow overriding via env var path to .gitcookies in gerrit_util.py · 0bfa9ad7

Ravi Mistry authored Nov 21, 2016

This is to make it easy to specify a different .gitcookies for bots.

BUG=skia:5979

Change-Id: Iaeb148d25f1c2c3d06ab5e1b155999566ef5f294
Reviewed-on: https://chromium-review.googlesource.com/413075Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>

0bfa9ad7

19 Nov, 2016 3 commits

Roll recipe dependencies (trivial). · 850ce84c

recipe-roller authored Nov 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a239f1551fb3ba35d72b9ad4d0cf80ee08c29b22 Vendor virtualenv, update to 15.1.0. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2512373002

850ce84c

tryserver module: fix in set_failure_hash · 174c2933

Nodir Turakulov authored Nov 19, 2016

set_failure_hash assumes that (StepFailure is raised) => (some steps
were ran), which is not a correct implication.
Check that there was a step before.

R=iannucci@chromium.org
BUG=

Change-Id: I36ad187584cb42696676e3339f6a77fc77dfd3b1
Reviewed-on: https://chromium-review.googlesource.com/412994
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

174c2933

Roll recipe dependencies (trivial). · 1d196c25

recipe-roller authored Nov 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a1c2338808c1a2a02d520f4078d21f766b43df5b Add name, package_repo_resource and resource support to recipe scripts. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2515913003

1d196c25

18 Nov, 2016 2 commits

Roll recipe dependencies (trivial). · 2527f74b

recipe-roller authored Nov 18, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/271a506617d4d308d2bde55d20744198343a5bf4 path module: documents std paths (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2513963003

2527f74b

infra_paths: do nothing if path_config is not specified · 7da798be

Nodir Turakulov authored Nov 18, 2016

Currently if path_config is not specified, infra_paths
defaults to buildbot paths. We want to make this behavior explicit,
so we don't have to introduce a new "luci" path configuration which
tells infra_paths module to do nothing.

Buildbot now specifies path_config=buildbot since
https://chromium-review.googlesource.com/c/412029/ ,
so now we can remove this default.

This also affects all expectation files because this CL switches 
the default path configuration from Buildbot to LUCI.
In particular, it changes default git cache dir from [GIT_CACHE]
to [CACHE]/git.
Also code paths that work only in Buildbot environment has to 
have a test with path_config=buildbot.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae
Reviewed-on: https://chromium-review.googlesource.com/411989
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

7da798be

17 Nov, 2016 9 commits

deprecate git_cache path · e672f939

Nodir Turakulov authored Nov 17, 2016

We cannot easily move git cache location on all buildbot bots, but we
need to define a new value for LUCI.
Introduce infra_paths.default_git_cache_dir which must be used instead
of using path['git_cache'] directly.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: I5244d7a761da94858df798abbd423c85f55936af
Reviewed-on: https://chromium-review.googlesource.com/411993
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

e672f939

deprecate build path · ff416a73

Nodir Turakulov authored Nov 17, 2016

Update recipe modules that use path "build" to either check whether it
is defined or fail with an explanation if it is not defined.

This CL marks failure code paths as `# pragma: no cover`. This comment
will be removed in https://chromium-review.googlesource.com/c/411989/

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ieb7637deefa6e366dfe4c30c7711d60daa06575a
Reviewed-on: https://chromium-review.googlesource.com/412225
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

ff416a73

Remove myself (dpranke@) from the WATCHLISTS. · c68d4d36

Dirk Pranke authored Nov 17, 2016

R=iannucci@chromium.org
BUG=

Change-Id: I118714ecb443f10aa69f9be3f2b7726d83b6884a
Reviewed-on: https://chromium-review.googlesource.com/412270Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

c68d4d36

gclient module: remove revert function · 415cf53d

Nodir Turakulov authored Nov 17, 2016

Nothing uses it

R=iannucci@chromium.org
BUG=

Change-Id: I33932335e019d61f8e174e12c2b647ebfe3d6903
Reviewed-on: https://chromium-review.googlesource.com/412265Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

415cf53d

deprecate depot_tools path · cb1beaa7

Nodir Turakulov authored Nov 17, 2016

Use depot_tools module's methods or package_repo_resource function to
determine paths of tools that live in depot_tools

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ic3172308c140f7f19e982ec6ec5a4b1b83261e1b
Reviewed-on: https://chromium-review.googlesource.com/411936Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

cb1beaa7

Roll recipe dependencies (trivial). · e164056d

recipe-roller authored Nov 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/67fe1f3ccee14c273b3d7d6235280497b4413cba Move ENV into custom deps, allow it to be random. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2515473003

e164056d

Don't return 1 when failing to add Gerrit CCs · 5db8209d

Aaron Gable authored Nov 17, 2016

This causes other automated tooling to think that the entire
upload has failed, when really only a small part of it has.

BUG=666160

Change-Id: I0d646e77c54330d642097aebe70ec145ae291267
Reviewed-on: https://chromium-review.googlesource.com/412281
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

5db8209d

remove slave_build path · fbf01c54

Nodir Turakulov authored Nov 16, 2016

slave_build path, defined by infra_paths module, is unnecessarily tied
to our buildbot setup which we are trying to deprecate in favor of LUCI.
In practice it is always == start_dir and that's what we want in LUCI too.

Update all code that uses slave_build path to use start_dir instead.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Id52aa535d6a4f52670d581bf56aab65f670b1861
Reviewed-on: https://chromium-review.googlesource.com/412075
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

fbf01c54

Update infra_paths to use START_DIR · 52185b37

Nodir Turakulov authored Nov 16, 2016

CURRENT_WORKING_DIR in path module was renamed to START_DIR. Update
infra_paths accordingly.

This includes recipe_engine roll.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: I913c16b1a185c5b753284ed934a5e60912887f0f
Reviewed-on: https://chromium-review.googlesource.com/412055Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

52185b37

16 Nov, 2016 4 commits

Add gsutil recipe module. · 6ecbb4ac

Dan Jacques authored Nov 16, 2016

Add the "gsutil" recipe module to depot_tools. This module is copied
from "tools/build"'s recipe module set at:
d6205ab0c0e8e1920f4af1617b5b3767cd944492.

Two Chromium-specific functions have been removed:
- download_with_polling
- download_latest_file

It also adds a function, "gsutil_py_path", which mimics the function in
the "depot_tools" recipe module. Ultimately, the latter will be phased
out in favor of the module-specific function.

BUG=chromium:662895
TEST=expectations

Change-Id: Ie049d637593b3f02b9ff029fbd20fd3f7170faa6
Reviewed-on: https://chromium-review.googlesource.com/411970
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6ecbb4ac

Gerrit git cl land: tell user how to abort. · 3aac7756

Andrii Shyshkalov authored Nov 16, 2016

R=friedman@chromium.org,andybons@chromium.org
BUG=665623

Change-Id: I419c6c01839fd761b1941fdf002fe39769cc1e17
Reviewed-on: https://chromium-review.googlesource.com/411761Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

3aac7756

Add env variable to skip GceAuthenticator for Gerrit CLs · fad941ba

Ravi Mistry authored Nov 15, 2016

BUG=skia:5979

Change-Id: I063a79a3877f4ad778bfbcbca3ddee49e6504ede
Reviewed-on: https://chromium-review.googlesource.com/411386Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>

fad941ba

Remote nested retries on checkout. · 260ab401

Dan Jacques authored Nov 16, 2016

Remove nested retries on checkout. Since the outer loop handles retries
specially, we want to let it exclusively handle retries. This will
prevent the inner retry loop triggering a timeout condition (rather than
a failure condition) with the outer loop.

BUG=chromium:665116
TEST=None

Change-Id: I4bf0c08b75861bf1c95060452118c314a121f9f3
Reviewed-on: https://chromium-review.googlesource.com/411397Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

260ab401

15 Nov, 2016 4 commits

Remove safesync support from gclient[_scm].py · a98a6cd4
agable authored Nov 15, 2016
```
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2395013002
```
a98a6cd4

Strip netrc hack, rewrite file. · 8d11e482

Dan Jacques authored Nov 15, 2016

Strip the netrc hack; apparently it only works on some versions of
Python, and the bots have many different versions.

Instead, we will actually emit the modified netrc as a new file without
comments or newlines, then read that directly from the vanilla netrc
module.

BUG=chromium:664664
TEST=None

Change-Id: I245759e2eae4e6ddcdffa0aaef59866a62bd0240
Reviewed-on: https://chromium-review.googlesource.com/411416
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

8d11e482

"netrc" hack to strip comments before processing. · 1d949fd3

Dan Jacques authored Nov 15, 2016

Processing comments seems to trigger a bug on (some?) Windows systems
due to a negative seek. This CL runs a comment-free version of the
"netrc" file through the parser.

BUG=chromium:664664
TEST=local
  - Uploaded this CL with the change.

Change-Id: I65f5d2f8c1162b3b3a13c66d8becb1cfccf27991
Reviewed-on: https://chromium-review.googlesource.com/411455Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

1d949fd3

Roll recipe dependencies (trivial). · 1a60c9c7

recipe-roller authored Nov 15, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/672570bf06c6b438b353a4c42d4d38ceab089eea path module: read tmp and cache dirs from properties (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2498273002

1a60c9c7

14 Nov, 2016 3 commits

gerrit_util: work with all paths. · 6d5bcc2b

Dan Jacques authored Nov 14, 2016

BUG=chromium:664664
TEST=local
  - Didn't work locally, now it does.

Change-Id: I5d470feda420342b0fb00a56e42a2b7d00257920
Reviewed-on: https://chromium-review.googlesource.com/411284Reviewed-by: Aaron Gable <agable@chromium.org>

6d5bcc2b

Fix authorization support · 43906384

smut authored Nov 12, 2016

The path always starts with a / so we need to check if it starts with /a/ to see if it's already authorized, not a/.

BUG=664664

Change-Id: I2bf6abe36dd88bc7d096e67d5e7a56fe9f143f47
Reviewed-on: https://chromium-review.googlesource.com/410721Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: First Last <smut@chromium.org>

43906384

Skip checking local vs remote patchset for Gerrit · fda50ca0

Ravi Mistry authored Nov 14, 2016

BUG=chromium:664520

Change-Id: Idd5855e14f6237577b351ff51582335996522417
Reviewed-on: https://chromium-review.googlesource.com/399118
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

fda50ca0

11 Nov, 2016 1 commit

Make depot_tools upload reviews to Gerrit by default · 9b654aa0

Aaron Gable authored Nov 11, 2016

BUG=634946

Change-Id: I1724395d6ba223854e513543841bdbb317f3ede7
Reviewed-on: https://chromium-review.googlesource.com/410227Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

9b654aa0