Commit 5db8209d authored by Aaron Gable's avatar Aaron Gable Committed by Commit Bot

Don't return 1 when failing to add Gerrit CCs

This causes other automated tooling to think that the entire
upload has failed, when really only a small part of it has.

BUG=666160

Change-Id: I0d646e77c54330d642097aebe70ec145ae291267
Reviewed-on: https://chromium-review.googlesource.com/412281
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
parent fbf01c54
......@@ -2847,11 +2847,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
if change_desc.get_cced():
cc.extend(change_desc.get_cced())
if cc:
errors = gerrit_util.AddReviewers(
gerrit_util.AddReviewers(
self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False)
if errors:
return 1
return 0
def _AddChangeIdToCommitMessage(self, options, args):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment