Commits · ea3ba237b1534457e721d3f7473296e42ead5e0d · Linshizhi / Chromium_Depot_tools

07 Dec, 2021 3 commits

Move linux-arm64 to "fully supported" platforms section. · ea3ba237

Robert Iannucci authored Dec 07, 2021

R=dpranke

Change-Id: If4ff162d06ddd3bd4fb9df1b0ff7b88fcb655afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321286
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

ea3ba237

[led] Update led to get latest Build protos. · 1693c67f

Robert Iannucci authored Dec 07, 2021

R=ddoman, vadimsh, yuanjunh

Bug: 1254504
Change-Id: I109435f1cb9d2e01234168f691b9e53d9f9e864d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321285
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

1693c67f

Roll recipe dependencies (trivial). · b5c7bf81

recipe-roller authored Dec 07, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828513270620724641

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2beefed237300d4a645ecf0f42a01a7f9af8fe5d
  2beefed (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e2de65e5c13c to 31175eb1a271

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I25b4196e13e1d9b45160100953d5c7977cc20e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3319710
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b5c7bf81

06 Dec, 2021 3 commits

Roll recipe dependencies (trivial). · 82f35125

recipe-roller authored Dec 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828561082276873953

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/cd5e2568496173ee338cf397e44b144a6cb745d8
  cd5e256 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 929fc1600ebf to c01c6da99bb0

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifadf7044de0cc4399b44c63671ae12a90762eeff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3318587
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

82f35125

Roll recipe dependencies (trivial). · 440d06ad

recipe-roller authored Dec 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828598189979054433

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/841e0e7d3e74fcde212886e3465773d75dec9d2f
  841e0e7 (tikuta@chromium.org)
      cas: update client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22e996d97b6d308b24251d48de3fd7455b21b855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3317476
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

440d06ad

Roll recipe dependencies (trivial). · ed004890

recipe-roller authored Dec 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828619596768405569

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/202ad55fc6b29aef8da502f55050afe8e2b12dc9
  202ad55 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6578c26ab505 to f58188e7754b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7a41341305022675450a4eacf7508b84cfbcece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3316025
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ed004890

03 Dec, 2021 7 commits

Roll recipe dependencies (trivial). · 203a6447

recipe-roller authored Dec 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828829717730219857

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9e184408eba22447467cbb4f506cfeef745a8182
  9e18440 (iannucci@chromium.org)
      Make python warning system work for warnings issued within gree...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I88bd8874de603841048a382702063541a4207929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3315379
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

203a6447

include filename in LUCI config validation · 26bfecdd

Takuto Ikuta authored Dec 03, 2021

Fixed: 1254615
Change-Id: Ic6d5350c7a89a597c1126ec05235a3e63eb2ad09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312231
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

26bfecdd

Fix the environment for calling git number. · 18785bb2

Garrett Beaty authored Dec 03, 2021

Calling git number requires that that depot tools is on the path so that
git-number can be found and requires the CHROME_HEADLESS environment
variable to be set.

Change-Id: Iabb8ec6732ca2bcc0f3209449e23a7d0a4f629e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314033
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

18785bb2

Roll recipe dependencies (trivial). · 3f1f2128

recipe-roller authored Dec 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828846088460117121

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/f3b50b1d0329362d6b0dabf1aff48d1697df4b07~..6fc52ceac19cb00ced1b7976056c9e61add3868f
  f3b50b1 (gbeaty@chromium.org)
      Remove the include_log argument to file.write_raw.
  414e051 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f9ac0b5e43be to 378218dcdbb1
  7594d98 (iannucci@chromium.org)
      [warnings] Allow warnings to be ignored by wrapping functions.
  6fc52ce (iannucci@chromium.org)
      Add documentation support for DEPRECATED callouts.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I58c2210f47b7ebe47ecb127605930b61c71fdc94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314937
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3f1f2128

Roll recipe dependencies (nontrivial). · 4b017c4d

recipe-roller authored Dec 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828910261704258817

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7e70723004f6fc2b510a36de6cbdcc177327e10b
  7e70723 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2927dee37b79 to 1ebd4afb7f59

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=sokcevic@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16b384a76202717c95a25b71331be01043a6dbfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314076
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>

4b017c4d

[windows_sdk] allow env json to not be relative · 98be56f2

Alex Gough authored Dec 03, 2021

SetEnv json entries in cipd packages for more recent Windows SDKs are
changed from:

       [
         "..",
         "..",
         "win_sdk",
         "Include",
         "10.0.17134.0",
         "um"
       ],

to

       [
         "Windows Kits",
         "10",
         "Include",
         "10.0.19041.0",
         "um"
       ],

so we should accept these paths now.

R=iannucci@chromium.org

Bug: 1250098
Change-Id: I56c84bc5ed46dda354e018b0abac2fae0bad8199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296663Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>

98be56f2

Roll recipe dependencies (trivial). · 3e68015b

recipe-roller authored Dec 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828911520299782337

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f923130a5a81698f2678e103149f459e62511169
  f923130 (bpastene@chromium.org)
      swarming: Only reserve 10% of a CPU core when collecting tasks.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4fba339158ce4347bfe3ff46c1f8a050cd483d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3313431
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3e68015b

01 Dec, 2021 4 commits

Roll recipe dependencies (trivial). · fc79a334

recipe-roller authored Dec 01, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829008290925895649

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/74207fa63ab42cbee8d4afcb57de901a8f142ce8
  74207fa (yuanjunh@google.com)
      [autoroll] Run again no matter which type of error is thrown

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa3c194323e0164d9d7726510b4c9fe193fbb981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312081
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fc79a334

Roll recipe dependencies (trivial). · 04c4da0e

recipe-roller authored Dec 01, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829020361632760209

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4dcc60114c6afc0c17d17ca3813e5149799240f1
  4dcc601 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 35f3f4525eec to 893bb89a656c

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iadfa0d49a464c0cc7e3911f2f340df2dfed26a0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3311738
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

04c4da0e

Cache condition evaluation results in gclient · 9cbe9a07

Josip Sokcevic authored Dec 01, 2021

Condition evaluation checks are fairly expensive, and turns out we
repeat a lot of checks. All those checks are also done in a single
thread.

With this cache on my workstation, a noop gclient runhooks takes 9.5s.
Without one, it takes 26.2s.

R=gavinmak@google.com

Change-Id: Ie00b7af22cd124d08dd9fd218de77b34bbdfe6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309823Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

9cbe9a07

Enable 'elaborate line editing' in `gclient_utils.AskForData` · e6855438

Christian Flach authored Dec 01, 2021

The (raw_)input Python function used by `gclient_utils.AskForData`
supports additional 'elaborate line editing' [1] [2] features, such as
the ability to use backspace to fix a typo, if the readline module is
loaded. Make sure that readline is loaded by importing it locally in
`gclient_utils.AskForData`.
It does not appear to be possible to write a test that verifies this
behavior - assigning `io.StringIO` to `sys.stdin` appears to cause
(raw_)input to fall back to basic input processing.

[1] https://docs.python.org/2.7/library/functions.html#raw_input
[2] https://docs.python.org/3/library/functions.html#input

Change-Id: Ie1c25b3fa2f3a255b78426c20e47c968cd7198ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3306613Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Christian Flach <cmfcmf@chromium.org>

e6855438

30 Nov, 2021 7 commits

Roll recipe dependencies (trivial). · 5deb9c9a

recipe-roller authored Nov 30, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829095859467187441

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/aebd6ccd5aabc8c49389e048f3c5fe90c93c9a3c
  aebd6cc (bryner@google.com)
      Update to new cffi wheel.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I32a0b29de79ae3563377a425a8ba46b197c9fb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309675
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5deb9c9a

Roll recipe dependencies (trivial). · ad7c1452

recipe-roller authored Nov 30, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829097116635688641

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6612e07002290bd5abbb3965708ca8b0870b35a3
  6612e07 (chanli@chromium.org)
      [buildbucket] Add infra to DEFAULT_FIELDS

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic553fa686f6a867f7319d628d42f83d91eaa539a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309664
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ad7c1452

Roll recipe dependencies (trivial). · 663c5e4f

recipe-roller authored Nov 30, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829104662854196817

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/df92157f2c8a576b948799b1a2daeb057401c4b7~..346c0ea55f67794598b8e5b264411c05ed565918
  df92157 (vadimsh@chromium.org)
      Add a simple `nodejs` recipe module.
  346c0ea (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e4c95e4e4cdc to 05791e01bd94

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8475dc305397a07373470d5f66248174b2ff9d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309521
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

663c5e4f

Roll recipe dependencies (trivial). · 554765c3

recipe-roller authored Nov 30, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829105923369331681

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6ea35fceeb7a5bf0513018059ef9b09c39c79400
  6ea35fc (iannucci@chromium.org)
      Recipe 'run' command has a weirdo concept of how working directory

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9fc6896cf0780906617754142c0fe38686781de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309261
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

554765c3

Give better error message when proc fails to execute. · 8676aa92

Anthony Polito authored Nov 30, 2021

Change-Id: I9dcbaa6dd287f0a5c2a749cfdf4607bddbf04734
BUG: 1274851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307919Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>

8676aa92

Add a method to the git API for running git number. · 320a1caf

Garrett Beaty authored Nov 30, 2021

Change-Id: Ieac13aac86df1c3e759f5aa66015ee6a3ac5c826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307495
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

320a1caf

Revert "Use ort strategy when applying patch" · 804165b4

Josip Sokcevic authored Nov 30, 2021

This reverts commit d8c84597.

Reason for revert: breaks skiabuildbot, crbug.com/1273642

Original change's description:
> Use ort strategy when applying patch
>
> ort is faster and fixes bugs in recursive strategy.
>
> Bug: 1260085
> Change-Id: Ib8523d45da5cb0beea957b6ab706101d55bdc1f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3276506
> Commit-Queue: Anthony Polito <apolito@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

Bug: 1260085
Bug: 1273642
Change-Id: Iece472547549363733fd2fa8fe5240d39df744a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307500
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

804165b4

29 Nov, 2021 6 commits

Roll recipe dependencies (trivial). · 512ca5c3

recipe-roller authored Nov 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829187715444793217

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6405fa87ee7da2a25985a1c061d8ebb6e18b154c
  6405fa8 (gbeaty@chromium.org)
      Don't report coverage when using the --py3-only flag.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0e548465b03d54ab24523938f304d74dc5ce2fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307499
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

512ca5c3

Roll recipe dependencies (trivial). · 0b037419

recipe-roller authored Nov 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829188966380336977

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4d492867cfdccec4b57c156bae5cb39225b7508f
  4d49286 (iannucci@chromium.org)
      Fix ResourceWaiter to not accidentally sort by gevent.Channel

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ef516874efee21a099f3d37e42324e2c801668d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307497
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0b037419

Replace can_fail_build with raise_on_failure. · 2e486c0d

Garrett Beaty authored Nov 29, 2021

The step API now supports the same functionality that can_fail_build
provides, so standardize on that argument rather than maintaining a
duplicate mechanism.

Bug: 1274644
Change-Id: Idcc3c0dacbab8d2d786b27ec277713063da6d334
Recipe-Manual-Change: build_limited
Recipe-Manual-Change: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3301439Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>

2e486c0d

Fix the use of raw_io output placeholders. · 51d99b2f

Garrett Beaty authored Nov 29, 2021

In order to enforce that the test data provided for placeholders is of
the appropriate type (text vs binary), existing mismatches must be
resolved. This will prevent type mismatch issues from occurring when
switching builders to use python3.

Bug: 1273548
Change-Id: I83da25432b67853992d7771aba558fd38520a24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3300310Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>

51d99b2f

Roll recipe dependencies (trivial). · 02f4003f

recipe-roller authored Nov 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829229854762889089

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ba4a4b2d4f1f41483b2da98854f648727b4aecdb
  ba4a4b2 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 83708e8181ac to 7422359d33c6

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6a5dffb0ecdd5648f53f62d38f96cefece6f874f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3305986
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

02f4003f

Roll recipe dependencies (trivial). · d91735a9

recipe-roller authored Nov 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829238675179401809

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6d57d876daf8c71cf6d7c48dade968f7d46244d0
  6d57d87 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 660e637467d1 to 0f5c78ebfa5f

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iee91c2171db77513d7895dac8e5e3a8434953e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3305977
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d91735a9

25 Nov, 2021 1 commit

Roll out goma client VERSION=239 · 2ffa1bde

Fumitoshi Ukai authored Nov 25, 2021

Bug: b/206705242
Change-Id: I8c9c02b978559bf3b26a9ebdbb4aa31eace97c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3300807Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

2ffa1bde

24 Nov, 2021 2 commits

Update to new cffi wheel. · afb82b2c

Brian Ryner authored Nov 24, 2021

This removes the libffi.so.6 dependency on Linux.

Bug: 1247674
Change-Id: I271bc6525ffbe8bd413e730b23365e1bc52aa16f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3299731Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>

afb82b2c

Roll recipe dependencies (trivial). · 646c3cd4

recipe-roller authored Nov 24, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829714939111375777

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a8f2ad5eff316712dffc29d3a114c3c068afb5e5
  a8f2ad5 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8316a4907135 to 3f6049a5711c

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe4b0d8610503e34ff4aeb09e05148be4c699fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3299768
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

646c3cd4

23 Nov, 2021 1 commit

Roll recipe dependencies (nontrivial). · b23a88a7

recipe-roller authored Nov 23, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829745138191541841

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/206cd301ad30ada2437dda4ad370906f4c1d8156
  206cd30 (gbeaty@chromium.org)
      Remove the log from write_raw.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=dpranke@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb9fe37d3d17fdb9b13ddab317c3357bf4e014b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3298693
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>

b23a88a7

22 Nov, 2021 1 commit

Make fix_encoding_test py3 compatible · a29f589a

Josip Sokcevic authored Nov 22, 2021

And run it in presubmit checks

R=gavinmak@google.com

Change-Id: If2a8848f6ce85c466f45d9bf0f4fca6b4d75312f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296677Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

a29f589a

19 Nov, 2021 5 commits

Make presubmit_unittest py3 compatible · b6c1ed40

Josip Sokcevic authored Nov 19, 2021

And run it in presubmit checks

R=apolito@google.com

Change-Id: I1521fe4dd9fd5fe391459a00a91f03399b15b36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292211
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

b6c1ed40

Roll recipe dependencies (trivial). · cfb30ff2

recipe-roller authored Nov 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830172328172143009

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0dc8afb3a9ed9de231183bf0bec0d60a3dba025e
  0dc8afb (iannucci@chromium.org)
      [cipd] Move ensure_tool to non-cacheable directory

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9a53009ab6f8d0a0378b5346f5bca750fe42de7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292358
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

cfb30ff2

Make CannedChecksUnittest py3 compatible · 6635baff

Josip Sokcevic authored Nov 19, 2021

R=apolito@google.com

Change-Id: I24610ca05536b4ac6eed2c0a33ef411650b46dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292089Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

6635baff

Roll recipe dependencies (trivial). · 90da0e15

recipe-roller authored Nov 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830174212818503905

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/cb62e2ac49c58c31f7245b2e602cd21496ecc448
  cb62e2a (vadimsh@chromium.org)
      Add a simple `golang` recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0bfa5517c292fc1a5d055dc13f67e69c73989974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292355
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

90da0e15

Run py3 compatible unit tests with py3 · 11c32b5f

Josip Sokcevic authored Nov 19, 2021

R=apolito@google.com

Change-Id: Id5e4f99ccb9d284ac09c2c4dd0fa57e59cb54f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3291894
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

11c32b5f