- 24 Mar, 2020 6 commits
-
-
Edward Lesmes authored
Remove unused functions, and use scm.GIT where possible to reduce duplication. Change-Id: I24f05e7b3ae04743e97b6665ee668f44d6acc294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116938Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/9ea4c747b17c7db08d5a7ca39418d2d385de75ef (iannucci@chromium.org) [engine] Drop recipe_engine subfolder from sys.path. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I18488270ef8a39a4716022b98260e023f84e0ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2117938Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
This is a reland of 01ed3589 * python_runner.sh, gclient, roll-dep and fetch will call vpython (instead of vpython3) when running on Windows under git-bash. * vpython3 now detects when running on Windows under git-bash and executes vpython3.bat instead. * vpython3.bat calls python3.exe directly instead of calling python3.bat. Original change's description: > depot_tools: Run using Python 3 by default. > > Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.) > using vpython3 by default. > > Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: I9829141d7ea26a67e655264430151f493e73a930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118418 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
Change-Id: I8cfbc013b4f17d727b65313e9e4823bab5d9ac18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113553Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Ye Kuang authored
https://chromium.googlesource.com/infra/goma/client/+/bd9711495c9357eead845f0ae2d4eef92494c6d5 Bug: b/151806816 Change-Id: I7ff43c5b736578be28e08641019ac2d5cc888f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116379Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com>
-
Peter Kasting authored
This reverts commit 01ed3589. Reason for revert: Broke tools on Windows with bash Original change's description: > depot_tools: Run using Python 3 by default. > > Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.) > using vpython3 by default. > > Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,ajp@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: If29ad72feaa215b8b282f2f6c9911700dd2f228c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116728Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org>
-
- 23 Mar, 2020 3 commits
-
-
Edward Lesmes authored
gclient_utils.AskForData will use raw_input on Python 2 and input on Python 3. Bug: 1063976 Change-Id: I93c059c4e4454d01787716b5a0a2641ad5253f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116370 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/0e8214509db0b273e7136270946b8d6688899356 (chanli@chromium.org) Fix api.resultdb.update_inclusions More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I59d22b2b2d2e22ea91f42d8588c4ec6cd711e196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2115949Reviewed-by:
-
Edward Lemur authored
Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.) using vpython3 by default. Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550Reviewed-by:
-
- 21 Mar, 2020 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/845d6c3e423fb08e9aa317cb7539c52cef004753 (robertocn@google.com) Add include_invocations and remove_invocations to api.resultdb More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I81f463fc569a8632d515a56b46b3b755a279fc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113554Reviewed-by:
-
- 20 Mar, 2020 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/69104bbe3c28562e00ac49d64ea8444457d459d3 (engeg@google.com) buildbucket: add 'with_host' context manager More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2fe2bcbf658babc05e79a9003387b97573221955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113261Reviewed-by:
-
Edward Lemur authored
It's always true. Change-Id: I96a53c032de705724e61c64ee37e9a14b596cbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113250Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/b509c8e28ba5142f5f798f44f5abafd2807d04b8 (yiwzhang@google.com) [warning] Define Cause proto message and its proto-free equivalent More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id9644061d4a2b57e529356568a4e915b40fe87a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2111701Reviewed-by:
-
Josip Sokcevic authored
Change-Id: Idea502dc67d8cf0b7387c1b68eb0c62837af971b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2111430Reviewed-by:
-
Richard Townsend authored
Using the x86 binary is required for testing on Windows on Arm systems, which can only emulate the x86 architecture at this time. Change-Id: I28f01e3974b69ced4a96d8675adc024555791131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2108724Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
- 18 Mar, 2020 5 commits
-
-
Josip Sokcevic authored
Change-Id: I9d3d084e7f48ab991db3db16873f030890ad72d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2108981Reviewed-by:
-
Edward Lemur authored
This is a reland of 9f29465e Original change's description: > git-cl: Refactor CMDUploadChange > > Changes: > - Add _GetDescriptionForUpload and _GetTitleForUpload. > - Add ensure_change_id to ChangeDescription, that ensures the > description has a particular Change-Id. > - If more than a Change-Id was entered on new issue upload, remove > all, and add a new one. > > Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Ib2c0ad61b169f6b0c3141674591b0d3fa42bc664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2103532 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Change-Id: Ib11ada368fda13bbef62c8be26ddb9c78a528a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107839Reviewed-by:
-
Simon Que authored
Bug: b/151197414 Change-Id: I6bf1aa388bf38fe855bae8e7290ec07fce2f8426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107341Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Samuel Huang authored
GetUnitTests() has named params {run_on_python2, run_on_python3}. This CL adds these params to GetUnitTestsRecursively() so they can be forwarded to GetUnitTests(). Bug: https://crbug.com/1054018 Change-Id: I06ac25a37f94cdea1cdc91954b70113e54cfdd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107610Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
- 17 Mar, 2020 2 commits
-
-
Josip Sokcevic authored
Change-Id: Iabc6ceb75da8a71f089c8fd89c94890f7b3f428e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2106513 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Josip Sokcevic authored
Change-Id: Id4ca28da6c38f6403636ef8c4de5dae1206cb499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2106518Reviewed-by:
-
- 16 Mar, 2020 2 commits
-
-
Bruce Dawson authored
The post_build_ninja_summary.py script, which autoninja automatically runs if NINJA_SUMMARIZE_BUILD=1 is set, summarizes build time by file extension. This is a good default summary but it can be handy to create additional output categories. This change allows using fn_match style wildcards to create additional categories which will then be summarized. For instance: python post_build_ninja_summary.py -C out/Def -s prec*.obj;blink*.obj In addition the chromium_step_types environment variable can be set so that when autoninja runs this script there will be additional summary categories. This has been used most recently when measuring the cost of creating and using blink precompiled header files. Bug: 1061326 Change-Id: I080b4ddd06d045a2351220e202cd9eec111bf00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2093145 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/bf0168d315c0b612412c236f115464b36c28a580 (iannucci@chromium.org) [proto_support] Add absolute import directives to all generated protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3fe18a447b0466758236d689972791470bfa4143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2104640Reviewed-by:
-
- 13 Mar, 2020 4 commits
-
-
Edward Lesmes authored
This reverts commit 9f29465e. Reason for revert: line 2302, in CMDUploadChange change_id = change_ids[0] IndexError: list index out of range Original change's description: > git-cl: Refactor CMDUploadChange > > Changes: > - Add _GetDescriptionForUpload and _GetTitleForUpload. > - Add ensure_change_id to ChangeDescription, that ensures the > description has a particular Change-Id. > - If more than a Change-Id was entered on new issue upload, remove > all, and add a new one. > > Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: Ibb76539066c103ec951fa8d02684bc10f84549bf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2103531Reviewed-by:
-
Edward Lemur authored
Changes: - Add _GetDescriptionForUpload and _GetTitleForUpload. - Add ensure_change_id to ChangeDescription, that ensures the description has a particular Change-Id. - If more than a Change-Id was entered on new issue upload, remove all, and add a new one. Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811Reviewed-by:
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Change-Id: I298d5f962e03520a93be1a7e32943934f1bde0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101809Reviewed-by:
-
Andrii Shyshkalov authored
Old revision: 3b479f0e Change logs: infra/infra: https://chromium.googlesource.com/infra/infra/+log/3b479f0e..7def9ec8 luci-go https://chromium.googlesource.com/infra/luci/luci-go/+log/ae97ada2..0d1cb386/lucicfg Bug: 1001182 Change-Id: I4f474185cd0c730b48e0a762837318de5176cbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101884Reviewed-by:Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
- 12 Mar, 2020 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/fb1417de1c1bea92905177d69dfe8214956d664b (robertocn@google.com) Do not use hostname flag when calling rdb. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I67406ff752a8c8342c0b1aabc766ac205a40ad5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101256Reviewed-by:
-
Edward Lemur authored
Bug: 1042324 Change-Id: I72db082f086f69bf49256d0613c39dc92ae0a07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101471 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
If the Change-Id in the description is different from the one fetched from Gerrit, automatically set the right one instead of asking the user to do so. Change-Id: I0f681d9e7d98f3ed50adc4b6e4929981530e901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101368 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Interrupt tests after 3 min, so that failures can be surfaced before the presubmit step gets interrupted on the bot. Change-Id: Ia0efebaac5a0c5072b974a4fbbcb14fe672017ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098942Reviewed-by:
-
Edward Lemur authored
Implicitly concatenated strings are not supported when setting new revisions, so raise an error when attempting to do se. Bug: 1060772 Change-Id: I74d39b9eb8dcc420e9b7787c90bee642beb783cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099407Reviewed-by:
-
Andrii Shyshkalov authored
This also applies to git map-branches. R=ehmaldonado Change-Id: Ica9bc92660716c15cbdd6bfd77b93f08bd0d8f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099329 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
- 11 Mar, 2020 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/caf3b9371438a8ef80c7cc977f770d8ed939731b (mikenichols@chromium.org) update.py: Add GCE Provider protos to list of protos More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie47304611f9964f9d2137fa3c3b23e05bae191ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099426Reviewed-by:
-
Edward Lemur authored
gclient executes `git rev-parse <ref>` to check if <ref> already exists in the local clone, which succeeds when <ref> is a git revision hash, even if it doesn't exist. We execute `git rev-parse <ref>^{commit}` instead, which only succeeds when <ref> resolves to a valid commit in the local repo. Change-Id: Ia1cdf7162c4c82a7e4214c6af375c1a9522d7b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095745Reviewed-by: -
Edward Lemur authored
When running `git rev-parse REV^{commit}` in Windows, `^` must be escaped. However, it was escaped more times than necessary. Split IsValidRevision to call ResolveCommit, add tests to ResolveCommit, and run scm.py tests on Windows. Change-Id: I761a820394c8b5410d68b6ccd6c352c41c30c88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2092904Reviewed-by: -
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/6b8de18a4a0c44f518f2c68e119cb71bee118e5a (mikenichols@chromium.org) go.chromium.org: Update recipe protos More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4deee1c7c503722ecf71865bdeb1aeaca47ff1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098123Reviewed-by:
-
Andrii Shyshkalov authored
R=apolito@google.com Bug: 1060018 Change-Id: I384e8bda14341159674e941abb6f723329ca5d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097341Reviewed-by:
-
Edward Lemur authored
stdout and stderr are bytes in Python 3 and must be decoded before printing the exception. Bug: 1060409 Change-Id: Ib855f6104919734b7505aa5e978ebe394a1e9db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097595Reviewed-by:
-
