Commits · e2b865ce2b309f11614fdce92ae2d8b9e6e71fc5 · Linshizhi / Chromium_Depot_tools

23 Dec, 2009 2 commits

Rips the guts out of git-try since trychange.py is now supper awesome. · e2b865ce

maruel@chromium.org authored Dec 23, 2009

TEST=try me (none)
BUG=none
TBR=brad

Review URL: http://codereview.chromium.org/516007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35219 0039d316-1c4b-4281-b951-d872f2087c98

e2b865ce

After much refactory, finally add significant functionalities to trychanges.py · d9141bff

maruel@chromium.org authored Dec 23, 2009

Add real logging support.
Fix the patch path mungling that was broken earlier.
Add and proper refactor automatic gclient and gcl settings detection.
Factored so it is possible to add other autodetection algorithms.
Now works standalone in hybrid svn&git checkouts within a gclient meta-checkout.

TEST=bah
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/517005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35218 0039d316-1c4b-4281-b951-d872f2087c98

d9141bff

22 Dec, 2009 10 commits

Add gclient_scm.GitWrapper.pack() · ee4071d4

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507070

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35177 0039d316-1c4b-4281-b951-d872f2087c98

ee4071d4

Add --sup_rep support to trychange.py. · f7ae6d55

maruel@chromium.org authored Dec 22, 2009

This adds the functionality to try a job spread across multiple checkouts.

TEST=fixed unit tests and tested with hybrid svn-git checkouts
BUG=none

Review URL: http://codereview.chromium.org/504085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35168 0039d316-1c4b-4281-b951-d872f2087c98

f7ae6d55

Factor out PathDifference into gclient_utils for a later reuse. · 3ccbf7e6

maruel@chromium.org authored Dec 22, 2009

Make lack of email address an error.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35167 0039d316-1c4b-4281-b951-d872f2087c98

3ccbf7e6

Prints errors on http protocol · 6f6a801e

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507071

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35156 0039d316-1c4b-4281-b951-d872f2087c98

6f6a801e

Fix a typo in scm.GIT.GetBranch() and add --dry_run to trychange.py to ease testing. · c308a744

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/503085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35155 0039d316-1c4b-4281-b951-d872f2087c98

c308a744

Add full_move flag to GIT.GenerateDiff and Factor out FindGclientRootDir into gclient_utils. · a9371767

maruel@chromium.org authored Dec 22, 2009

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/501171

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35154 0039d316-1c4b-4281-b951-d872f2087c98

a9371767

Small cleanups in trychange.py · 650bb1f9

maruel@chromium.org authored Dec 22, 2009

Review URL: http://codereview.chromium.org/509020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35145 0039d316-1c4b-4281-b951-d872f2087c98

650bb1f9

Remove more logic out of trychange.py into scm.py. · b24a8e1a

maruel@chromium.org authored Dec 22, 2009

The goal is to (almost) completely remove git-try.

TEST=none

Review URL: http://codereview.chromium.org/501166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35144 0039d316-1c4b-4281-b951-d872f2087c98

b24a8e1a

Simplify call site. · 1227c7de

maruel@chromium.org authored Dec 22, 2009

Do a review comment I forgot to apply in a previous change.

TEST=none

Review URL: http://codereview.chromium.org/508012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35124 0039d316-1c4b-4281-b951-d872f2087c98

1227c7de

Move GenerateDiff into a common function. · f2f9d554

maruel@chromium.org authored Dec 22, 2009

Fix standalone trychange usage on both svn and git.
Remove implicit dependency on git-cl.

TEST=unit test

Review URL: http://codereview.chromium.org/507061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35121 0039d316-1c4b-4281-b951-d872f2087c98

f2f9d554

20 Dec, 2009 2 commits

Make breakpad, gcl and presubmit_support dependencies optional · ea8c1a9b

maruel@chromium.org authored Dec 20, 2009

TEST=unit tests

Review URL: http://codereview.chromium.org/503068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35072 0039d316-1c4b-4281-b951-d872f2087c98

ea8c1a9b

Remove gclient-specific hacks from trychange into gcl. · 18111359

maruel@chromium.org authored Dec 20, 2009

Remove upload dependency.

This is towards making trychange.py work mostly standalone for the webkit try server.

TEST=unit tests and tested both gcl try and git-try.

Review URL: http://codereview.chromium.org/501143

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35071 0039d316-1c4b-4281-b951-d872f2087c98

18111359

19 Dec, 2009 2 commits

Factor out gcl.GetRepositoryRoot() into scm.SVN.GetCheckoutRoot() · 94b1ee9d

maruel@chromium.org authored Dec 19, 2009

This is to reduce trychange.py dependency on gcl.py

Review URL: http://codereview.chromium.org/502085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35055 0039d316-1c4b-4281-b951-d872f2087c98

94b1ee9d

Remove trychange.RunCommand and replace it by gclient_utils.CheckCall. · 9a2f37ea

maruel@chromium.org authored Dec 19, 2009

TEST=unit tests

Review URL: http://codereview.chromium.org/502078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35052 0039d316-1c4b-4281-b951-d872f2087c98

9a2f37ea

18 Dec, 2009 5 commits

Fix the author search for branches (only an issue on reverts), looking at... · 461843e2

laforge@chromium.org authored Dec 18, 2009

Fix the author search for branches (only an issue on reverts), looking at trunk w/ the revision won't tell you
the correct author.
Review URL: http://codereview.chromium.org/505053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35009 0039d316-1c4b-4281-b951-d872f2087c98

461843e2

One liner fix. · 2185f006

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/502075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34984 0039d316-1c4b-4281-b951-d872f2087c98

2185f006

Get rid of gcl.ReadFile. · 0fca4f37

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/501106

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34950 0039d316-1c4b-4281-b951-d872f2087c98

0fca4f37

Remove gcl.WriteFile · fc83c11b

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/502066

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34949 0039d316-1c4b-4281-b951-d872f2087c98

fc83c11b

Fix a character encoding issue · f5a1163b

laforge@chromium.org authored Dec 18, 2009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34897 0039d316-1c4b-4281-b951-d872f2087c98

f5a1163b

17 Dec, 2009 2 commits

Add eol ignore logic to make webkit merges less problematic. · ee98c9fd

laforge@chromium.org authored Dec 17, 2009

Review URL: http://codereview.chromium.org/505042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34895 0039d316-1c4b-4281-b951-d872f2087c98

ee98c9fd

Add a minimum SVN version check to drover, to enforce the 1.5.x requirement. · 004d2efe

laforge@chromium.org authored Dec 17, 2009

Review URL: http://codereview.chromium.org/501081

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34894 0039d316-1c4b-4281-b951-d872f2087c98

004d2efe

15 Dec, 2009 1 commit

gclient: implement a less hacky relative URL implementation · c532e17e

msb@chromium.org authored Dec 15, 2009

Doing something like basename when concatenating base_url with
relative url.

Added use_relative_urls2 to enable switching between old
implementation and new implementation. Once the old implementation
is deprecated we can remove the use_relative_urls2.

Review URL: http://codereview.chromium.org/500015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34563 0039d316-1c4b-4281-b951-d872f2087c98

c532e17e

14 Dec, 2009 2 commits

--replace-all so we don't accum variables · 4c317183

jrg@chromium.org authored Dec 14, 2009

Review URL: http://codereview.chromium.org/504002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34500 0039d316-1c4b-4281-b951-d872f2087c98

4c317183

gclient: Add better error reporting and handling when there is a rebase conflict · 5bde4853

msb@chromium.org authored Dec 14, 2009

When a rebase generates a conflict, report an error and exit immediately.
If in an existing conflict (no branch), report an error and exit immediately.

Review URL: http://codereview.chromium.org/496003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34459 0039d316-1c4b-4281-b951-d872f2087c98

5bde4853

12 Dec, 2009 1 commit

gclient: Fix unittests · e8dd16c7

msb@chromium.org authored Dec 12, 2009

Review URL: http://codereview.chromium.org/486045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34415 0039d316-1c4b-4281-b951-d872f2087c98

e8dd16c7

11 Dec, 2009 3 commits

gclient: Don't change directories when checking git version. · ba9b239c

msb@chromium.org authored Dec 11, 2009

Review URL: http://codereview.chromium.org/495003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34392 0039d316-1c4b-4281-b951-d872f2087c98

ba9b239c

gclient: fix git version check to handle 1.6.5.2.5.g7c3ba.dirty · 83376f2f

msb@chromium.org authored Dec 11, 2009

Review URL: http://codereview.chromium.org/486036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34386 0039d316-1c4b-4281-b951-d872f2087c98

83376f2f

gclient: Add a minimum git version check. · 923a0373

msb@chromium.org authored Dec 11, 2009

Review URL: http://codereview.chromium.org/490021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34377 0039d316-1c4b-4281-b951-d872f2087c98

923a0373

09 Dec, 2009 1 commit

Fix default cwd value and the timing of the result code check · ffe96f07

maruel@chromium.org authored Dec 09, 2009

Review URL: http://codereview.chromium.org/474002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34166 0039d316-1c4b-4281-b951-d872f2087c98

ffe96f07

08 Dec, 2009 3 commits

Add breakpad support to git-try and trychange.py · 82f2c08a

maruel@chromium.org authored Dec 08, 2009

Review URL: http://codereview.chromium.org/465128

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34087 0039d316-1c4b-4281-b951-d872f2087c98

82f2c08a

Fix the way the temporary directory is created. · 63ebf04d

maruel@chromium.org authored Dec 08, 2009

It is much cleaner and works for cases where the directory is not writeable.

Also fix an unrelated unit test.

Review URL: http://codereview.chromium.org/464068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34080 0039d316-1c4b-4281-b951-d872f2087c98

63ebf04d

Fix git 1.6.1 vs 1.6.5 underscore key issue. (Hooks side.) · 745435c3

chase@chromium.org authored Dec 08, 2009

BUG=none
TEST=git cl upload sets watchlist extracc on rietveld
issues
Review URL: http://codereview.chromium.org/460125

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34078 0039d316-1c4b-4281-b951-d872f2087c98

745435c3

03 Dec, 2009 6 commits

http://codereview.chromium.org/460038 · 3db87198

jrg@chromium.org authored Dec 03, 2009



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33716 0039d316-1c4b-4281-b951-d872f2087c98

3db87198

Add a check so non-google employee don't send crash dumps. · 7aca9e8c

maruel@chromium.org authored Dec 03, 2009

Add a warning message in case the check ever fail.

Review URL: http://codereview.chromium.org/460044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98

7aca9e8c

Disable braekpad automatic registration while we figure out stuff · 5b3d69d2

maruel@chromium.org authored Dec 03, 2009

Review URL: http://codereview.chromium.org/462022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33686 0039d316-1c4b-4281-b951-d872f2087c98

5b3d69d2

depot_tools: Print line numbers in search results of git-gs · 34e0a35e

mnaganov@chromium.org authored Dec 03, 2009

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/458017



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33683 0039d316-1c4b-4281-b951-d872f2087c98

34e0a35e

Minimalist breakpad implementation. · ada4c65e

maruel@chromium.org authored Dec 03, 2009

Client-side implementation.

TODO: Need to automatically disable it for unit tests.

Review URL: http://codereview.chromium.org/444009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98

ada4c65e

Revert changes to GetCachedFile() in r30414, r30910, r31586, and go back to · fa44e4ae

dpranke@google.com authored Dec 03, 2009

the behavior before I started messing with it. It turns out it's not worth the
hassle to try and "clean this up"; we depend on the current convoluted
semantics, which is to crawl up the tree from the current dir looking for
codereview.settings files, but to only ever look for PRESUBMIT.py in the
root of the repo. Trying to unify the logic seems to be too painful.

   BUG=none
   R=maruel@chromium.org
   TEST=none

Review URL: http://codereview.chromium.org/387067

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33648 0039d316-1c4b-4281-b951-d872f2087c98

fa44e4ae