- 27 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: I6e288283c0033fb48a0b8ece8c06f6813f9a9d8a Reviewed-on: https://chromium-review.googlesource.com/1186158 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I258efa0a95f20b80819bc89cccfb5e0a29e09d5c Reviewed-on: https://chromium-review.googlesource.com/1188989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 23 Aug, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597 [file] Add flatten_single_directories function. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I44ccca7d3d6c580d3df711d8c3b4ca2f2f22d192 Reviewed-on: https://chromium-review.googlesource.com/1187602 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Andrii Shyshkalov authored
This fixes Gerrit project detection based on remote URL, accounting for potential 'a/' prefix in the URL path component, which isn't part of the Gerrit project name. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I473ae8c6c9e0f2034b350901abd67db151e0a3d3 Reviewed-on: https://chromium-review.googlesource.com/1187573Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Broke release process. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I02ea424632f5c5522af0010adce1c993e2610b48 Reviewed-on: https://chromium-review.googlesource.com/1187548Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
John Budorick authored
Bug: 876734 Change-Id: I5741b526f14d79f7a8eb42808c1eef93434739cb Reviewed-on: https://chromium-review.googlesource.com/1187368Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: Ie8a2dbf4c135f9f84c00c4d04d7ef1c2e9480e45 Reviewed-on: https://chromium-review.googlesource.com/1186157Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Sadly, this makes maintaining one test handling covering exceptional circumstance very complex, so it was removed. I've decoupled test that ensures that GetRemoteUrl works from upload codepath. R=ehmaldonado@chromium.org Bug: 876910 Change-Id: I39de410c72d893e73492d5c3fc8f60a6ebc4f11f Reviewed-on: https://chromium-review.googlesource.com/1186142Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado@chromium.org Testing patched my own depot_tools in $PATH and uploaded https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1186072 which set reviewers and ccs as expected. Bug: 876910 Change-Id: I43c0f2284941cf703133bb51132226d4a0472d8e Reviewed-on: https://chromium-review.googlesource.com/1186068 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 22 Aug, 2018 3 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ia35da60783cfbfd472646176d8fc669d8f4d9839 Reviewed-on: https://chromium-review.googlesource.com/1185989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: I5be27cb025f8237cef0186c90eb7b99d000076d9 Reviewed-on: https://chromium-review.googlesource.com/1185986 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Corentin Wallez authored
BUG=chromium:875245 Change-Id: Ieed7554c55bab2bc5820cf4ffbbf57b72492b90f Reviewed-on: https://chromium-review.googlesource.com/1183432Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
- 21 Aug, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2310fc75c6b6cd672558934d92f04e6ccd449140 Keep fewer copies of data to sanitize utf-8 in OutputPlaceholders too. (thakis@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I78a3487320c2dc90b346e36b072504ce24432a7b Reviewed-on: https://chromium-review.googlesource.com/1183992Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 20 Aug, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f32ed079ee0ee36fd060da830393d7bee5c0e590 Cleanup changes related to step_text/log post_process functions. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9f05ee744fc91d75cba2244447b2f1526cd76be2 Reviewed-on: https://chromium-review.googlesource.com/1182364 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Raul E Rangel authored
BUG=none TEST=Made sure my coreboot commits show up Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: If4e3fd501d844da56555a065e2911748a450b36c Reviewed-on: https://chromium-review.googlesource.com/1173069Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918 Add service-account support to recipe-py's cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If6d04864ff9665e3ca319095555581a733895089 Reviewed-on: https://chromium-review.googlesource.com/1181781 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/53053ef702fea3816a322b4ecc697348e7002555 Don't keep multiple copies of data in memory to sanitize utf-8. (thakis@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibd8941968da44700c473a8a996365484828febea Reviewed-on: https://chromium-review.googlesource.com/1181473 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Raul E Rangel authored
The `DST Root CA X3` certificate was missing from cacerts.txt in the old version. This resulted in failure to connect to Let's Encrypt hosts. e.g., https://review.coreboot.org BUG=none TEST=Made sure my_activity.py continues to function and it can also connect to review.coreboot.org Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I519916b58a59b8f13c227218e93c392a63a24800 Reviewed-on: https://chromium-review.googlesource.com/1173064Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 18 Aug, 2018 1 commit
-
-
Ben Pastene authored
Change-Id: Id1c0ab59864c0e1043751f8825828f7ae9cf9ac4 Reviewed-on: https://chromium-review.googlesource.com/1180479 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 17 Aug, 2018 1 commit
-
-
John Budorick authored
Bug: 865882 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Change-Id: I4a04c4c28c7dc63ad282f54604c300bbfe654f11 Reviewed-on: https://chromium-review.googlesource.com/1157687 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Aug, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/99a5a657f34715544dae41925c0d418482dc00c4 Fix type-checking for default tuple vals in cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2487e3acb9d7b093f11ea78f1b67d1174eaa1771 Reviewed-on: https://chromium-review.googlesource.com/1179083 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/373fc6c634e2082536176f66e106260fed801485 Add pkg-var support to cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1dc9adfa4f26ea4ed4f2576f13e811f7065d13d2 Reviewed-on: https://chromium-review.googlesource.com/1178721Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Vadim Shtayura authored
This is Windows counterpart to https://chromium-review.googlesource.com/1171957 Also cleanup code style in cipd.ps1 script. It appears the common convention for global variables in PowerShell is $GlobalVar and for locals is $localVar. R=nodir@chromium.org, iannucci@chromium.org BUG=870166 Change-Id: Ib8ffbad85497db31f7f5d44fdca6ed843e56f220 Reviewed-on: https://chromium-review.googlesource.com/1175248 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0534af39f0790915a8d13815d59784c8664c412d Correct parsing logic for tags and refs in describe operation (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib88238f06aeb94206f5ba272f9936d426ff1c0de Reviewed-on: https://chromium-review.googlesource.com/1177909 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Vadim Shtayura authored
Linux and OSX only for now. This also rolls CIPD client to a version that supports pinned hashes (v2.2.5). CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since it makes no sense when pinning hashes of the binaries at specific version on the specific backend. Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output consistently. R=iannucci@chromium.org, nodir@chromium.org BUG=870166, 874586 Change-Id: Iac67fbb6b5d07dcd81d44536737b03b146f1ad14 Reviewed-on: https://chromium-review.googlesource.com/1176727Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Andrii Shyshkalov authored
R=hinoka Bug: 851505 Change-Id: I355334c2a84f175452ff7c17f6b080d2815f0f4c Reviewed-on: https://chromium-review.googlesource.com/1168131Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This is in order to use built-in presubit recipe. R=maruel Change-Id: I3e50af7dc3a9ad83f0f358285395794ea599a4e8 Reviewed-on: https://chromium-review.googlesource.com/1176650Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 15 Aug, 2018 5 commits
-
-
Robert Sesek authored
The message was previously not clear that if the entire CL has any change to an OWNERS file, TBR will not apply. Change-Id: Ib30a93f80196f45b02a29701faab7cf581e37f50 Reviewed-on: https://chromium-review.googlesource.com/1176321Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org>
-
Vadim Shtayura authored
This reverts commit eebc3d82. Reason for revert: crbug.com/874586 Original change's description: > [cipd] Check CIPD client hash against pinned SHA256 during updates. > > Linux and OSX only for now. This also rolls CIPD client to a version that > supports pinned hashes (v2.2.5). > > CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since > it makes no sense when pinning hashes of the binaries at specific version on > the specific backend. > > Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output > consistently. > > R=iannucci@chromium.org, nodir@chromium.org > BUG=870166 > > Change-Id: I9e61f9f8fbdcf10985c52828b2bfbec64b4234f0 > Reviewed-on: https://chromium-review.googlesource.com/1171957 > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org,nodir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870166 Change-Id: I9aa8e7a7f07520aa69d366c76e4dbccae345bc00 Reviewed-on: https://chromium-review.googlesource.com/1175294Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
John Budorick authored
Change-Id: If8ef3a87ba71ae76dd1fe8e1854a6ebe073b859a Reviewed-on: https://chromium-review.googlesource.com/1176185Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
John Budorick authored
Bug: 865882 Change-Id: I27bfbeaf7395a05ce660e9e961550233461acb3d Reviewed-on: https://chromium-review.googlesource.com/1175857Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2a2c2ad5a29a6473130e7293a4585fbd5d403ee0 [cipd] Don't fail when search result is empty (phosek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id31ea54e689e323052d71994c1a1f617f1de5450 Reviewed-on: https://chromium-review.googlesource.com/1175924Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 14 Aug, 2018 4 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado@chromium.org Change-Id: Ic730530bc53632a64fb79a733e0a00ba2460da67 Reviewed-on: https://chromium-review.googlesource.com/1175242Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
John Budorick authored
Bug: 873186 Change-Id: I91649cc5f4ba8f81f982463aa534e77d88f87ac0 Reviewed-on: https://chromium-review.googlesource.com/1175099Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Vadim Shtayura authored
Linux and OSX only for now. This also rolls CIPD client to a version that supports pinned hashes (v2.2.5). CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since it makes no sense when pinning hashes of the binaries at specific version on the specific backend. Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output consistently. R=iannucci@chromium.org, nodir@chromium.org BUG=870166 Change-Id: I9e61f9f8fbdcf10985c52828b2bfbec64b4234f0 Reviewed-on: https://chromium-review.googlesource.com/1171957 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/75244002db7a51d62cabdad873d622b1d8c28434 Add post_process functions for asserting on a step's text and logs. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8896b4ca5e0d9081ba37eeb9bedfe2814539f7d0 Reviewed-on: https://chromium-review.googlesource.com/1174943 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 10 Aug, 2018 2 commits
-
-
Edward Lemur authored
Also add shortcuts, so we don't have to look through all the branches if the patch is based on a common branch (i.e. master, infra/config, lkgr) Bug: 870279 Change-Id: I625a8481dccac9a475b096b926e6fab7efe676b0 Reviewed-on: https://chromium-review.googlesource.com/1161094 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/bd5111dec043a367d69d85b81289e2207aa26f6e [cipd] Clean docs, pylint errors, add pkg-fetch, pkg-deploy. (iannucci@chromium.org) R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I19d44529f7caa41c9577e57f6a9a35815627c4c3 Reviewed-on: https://chromium-review.googlesource.com/1170243 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 09 Aug, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/01519bca7833290d850f394b71f46f4dc1b0146e [path] Cleanup pylint warnings, add more docs. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib5c1bf8a496ff235530645dfb346e59118fe6008 Reviewed-on: https://chromium-review.googlesource.com/1169840 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Robert Iannucci authored
R=hinoka@chromium.org, nodir@chromium.org, sergeyberezin@chromium.org Change-Id: I92a6675a7fa81987667edb8c7189c2e827f62732 Reviewed-on: https://chromium-review.googlesource.com/1168652Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-