Commits · e044c81799f3dc04f68507a25b5c723d08dd9d89 · Linshizhi / Chromium_Depot_tools

24 Mar, 2016 3 commits

git cl: Rework Changelist class for Rietveld/Gerrit use. · e044c817

tandrii@chromium.org authored Mar 24, 2016

This adds pluggable codereview-specific implementations into
Changelist class. The specific implementation is chosen at
Changelist automatically, with Rietveld being default for
backwards compatibility.

Gerrit implementation for Gerrit is incomplete, and will be
added in later CLs. However, it is sufficient to ensure
current functionality of this tool is not diminished.

Sadly, the base class isn't completely free from Rietveld
assumptions because of presubmit_support. Apparently, PRESUBMIT 
scripts can make use of Rietveld instance for RPCs directly.
This use doesn't make sense for Gerrit, which substitutes
rietveld instance with a dummy object, which raises exception
on any attribute access with a diagnostic message.

This also includes refactoring of some related code which
(ab)used ChangeList. Overall, this CL adds a few extra call to
git config in order to determine which codereview to use, but
but it shouldn't have any performance impact.


BUG=579160

Review URL: https://codereview.chromium.org/1805193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299462 0039d316-1c4b-4281-b951-d872f2087c98

e044c817

Roll recipe dependencies (trivial). · 2f595bd3

recipe-roller@chromium.org authored Mar 24, 2016


This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1833623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299460 0039d316-1c4b-4281-b951-d872f2087c98

2f595bd3

Fix gerrit_util to use non None body. · c7da66a4

tandrii@chromium.org authored Mar 24, 2016

Gerrit requires Content-Length to be set for POST requests.
httplib Python library has a bug which doesn't set Content-Length
if the body is empty.

Python BUGS:
https://bugs.python.org/issue14721 (partial fix)
https://bugs.python.org/issue23539 (full fix)

The full fix only appears in 2.7.11 release changelog
(technically, it's been fixed in 2.7.10 rc1, but 2.7.10 was not
released):
https://hg.python.org/cpython/raw-file/53d30ab403f1/Misc/NEWS

R=andybons@chromium.org,szager@chromium.org
BUG=579160

Review URL: https://codereview.chromium.org/1827653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299459 0039d316-1c4b-4281-b951-d872f2087c98

c7da66a4

23 Mar, 2016 4 commits

Roll recipe dependencies (trivial). · ab8b6d25

recipe-roller@chromium.org authored Mar 23, 2016


This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1821393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299446 0039d316-1c4b-4281-b951-d872f2087c98

ab8b6d25

Roll recipe dependencies (trivial). · 4337184d

recipe-roller@chromium.org authored Mar 23, 2016


This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1832523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299445 0039d316-1c4b-4281-b951-d872f2087c98

4337184d

Roll recipe dependencies (trivial). · c81a3d08

recipe-roller@chromium.org authored Mar 23, 2016


This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1825843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299443 0039d316-1c4b-4281-b951-d872f2087c98

c81a3d08

depot_tools: remove code for --trybot-json · 2ff30187

phajdan.jr@chromium.org authored Mar 23, 2016

It was added in https://codereview.chromium.org/112503005
for https://bugs.chromium.org/p/chromium/issues/detail?id=278558 ,
but we ended up implementing the functionality in different way.

BUG=583578

Review URL: https://codereview.chromium.org/1825063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299433 0039d316-1c4b-4281-b951-d872f2087c98

2ff30187

22 Mar, 2016 2 commits

Enable crash dump collection on builders · ff3af2c1

brucedawson@chromium.org authored Mar 22, 2016

Toolchain crashes on build machines are an ongoing problem, particularly
with the VC++ 2015 migration. Setting this registry key tells Windows
Error Reporting to record minidumps (a few MB typically) to a local
directory, up to a maximum of ten. This should help with investigations.

This change also suppresses Windows Error Reporting dialogs with the
DontShowUI registry value, to avoid builder hangs on crashes.

See also crrev.com/1816333002

BUG=440500

Review URL: https://codereview.chromium.org/1825163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299426 0039d316-1c4b-4281-b951-d872f2087c98

ff3af2c1

Roll recipe dependencies (trivial). · 8b860674

recipe-roller@chromium.org authored Mar 22, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1819233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299417 0039d316-1c4b-4281-b951-d872f2087c98

8b860674

21 Mar, 2016 1 commit

testing_support: fix Gerrit releases URL. · 1d2ac687

tandrii@chromium.org authored Mar 21, 2016

R=szager@chromium.org,sergiyb@chromium.org
BUG=579160

Review URL: https://codereview.chromium.org/1820923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299408 0039d316-1c4b-4281-b951-d872f2087c98

1d2ac687

18 Mar, 2016 3 commits

Make the config -> pythonish conversion a gclient module function. · 375aa588

martiniss@chromium.org authored Mar 18, 2016

Also makes bot_update use this.

This allows for clank to manually set the gclient config.

BUG=590788

Review URL: https://codereview.chromium.org/1815863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98

375aa588

Set default --lock_timeout to 5m · 5b48e48c

nodir@chromium.org authored Mar 18, 2016

gclient-sync + git-cache are racy because if two different DEPS files
dependent on the same repo URL, even if depsed to different checkout
dirs, they use same git cache dir. If both checkout dirs are synced at
the same time, one of them cannot acquire a lock.

This is a cheap solution to change --lock_timeout option default value
from 0 to 5m.

R=hinoka@chromium.org
BUG=593468

Review URL: https://codereview.chromium.org/1785083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299386 0039d316-1c4b-4281-b951-d872f2087c98

5b48e48c

add AppEngine files downloaded for running tests to gitignore. · b1200846

tandrii@chromium.org authored Mar 18, 2016

R=andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1813813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299383 0039d316-1c4b-4281-b951-d872f2087c98

b1200846

17 Mar, 2016 2 commits

Gerrit git cl: temporarily disable gerritissue setting. · 139595ec

tandrii@chromium.org authored Mar 17, 2016

Reason: it breaks re-upload.

R=andybons@chromium.org,machenbach@chromiu.org,mmentovai@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1810683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299354 0039d316-1c4b-4281-b951-d872f2087c98

139595ec

Gerrit git cl: fix change-id appending. · 9fc50db2

tandrii@chromium.org authored Mar 17, 2016

Special case when the change description has no footers, but looks
like a footer.

R=machenbach@chromium.org,andybons@chromium.org
BUG=579176

Review URL: https://codereview.chromium.org/1812803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299343 0039d316-1c4b-4281-b951-d872f2087c98

9fc50db2

16 Mar, 2016 3 commits

bot_update: Rewrite to use properties, and add override options for patches. · 29c3b346

martiniss@chromium.org authored Mar 16, 2016

Depends on https://codereview.chromium.org/1755593003

BUG=591172

Review URL: https://codereview.chromium.org/1741983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299332 0039d316-1c4b-4281-b951-d872f2087c98

29c3b346

Convert the bot_update module to use properties · 21217f42

martiniss@chromium.org authored Mar 16, 2016

R=iannucci@chromium.org
BUG=591172

Review URL: https://codereview.chromium.org/1805113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299329 0039d316-1c4b-4281-b951-d872f2087c98

21217f42

Gerrit git cl upload: record issue id for a branch. · a342c92b

tandrii@chromium.org authored Mar 16, 2016

BUG=

Review URL: https://codereview.chromium.org/1777603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299312 0039d316-1c4b-4281-b951-d872f2087c98

a342c92b

15 Mar, 2016 3 commits

Remove legacy DownloadHooks as no longer used. · 5e8bb9a2

tandrii@chromium.org authored Mar 15, 2016

R=andybons@chromium.org,jbudorick@chromium.org
BUG=579176

Review URL: https://codereview.chromium.org/1763153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299295 0039d316-1c4b-4281-b951-d872f2087c98

5e8bb9a2

Stop installing Gerrit commit-msg hooks in git cl config. · e7d3d165

tandrii@chromium.org authored Mar 15, 2016

R=bauerb@chromium.org,ukai@chromium.org,andybons@chromium.org
BUG=579176,579160

Review URL: https://codereview.chromium.org/1799553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299293 0039d316-1c4b-4281-b951-d872f2087c98

e7d3d165

git cl try-results: make color force-able. · 6cf98c8b

tandrii@chromium.org authored Mar 15, 2016

Inspiration:
  $ watch -n 10 "git cl try-results"
  $ watch --color "ls -al --color"

R=nodir@chromium.org,sergiyb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1799203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299291 0039d316-1c4b-4281-b951-d872f2087c98

6cf98c8b

14 Mar, 2016 2 commits

Delete super old and unused git-cl-upload-hook. · 5e2a6873

tandrii@chromium.org authored Mar 14, 2016

Follow up on https://codereview.chromium.org/6758001

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1795753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299283 0039d316-1c4b-4281-b951-d872f2087c98

5e2a6873

Roll recipe dependencies (trivial). · 20b3a844

recipe-roller@chromium.org authored Mar 14, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1798163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299278 0039d316-1c4b-4281-b951-d872f2087c98

20b3a844

12 Mar, 2016 4 commits

depot_tools: use ninja.exe instead of just ninja on Windows · dabddd8a

phajdan.jr@chromium.org authored Mar 12, 2016

BUG=437264

Review URL: https://codereview.chromium.org/1778243008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299267 0039d316-1c4b-4281-b951-d872f2087c98

dabddd8a

depot_tools: expose location of ninja · f3874aff

phajdan.jr@chromium.org authored Mar 12, 2016

BUG=437264

Review URL: https://codereview.chromium.org/1787633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299263 0039d316-1c4b-4281-b951-d872f2087c98

f3874aff

Log the location where we start to search .gclient for · fa2707ee

sergiyb@chromium.org authored Mar 12, 2016

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1789713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299261 0039d316-1c4b-4281-b951-d872f2087c98

fa2707ee

Reland of Use gclient's git_cache setting in bot_update/api.py · 5fc657ba

martiniss@chromium.org authored Mar 12, 2016

https://codereview.chromium.org/1762513002/

Use gclient's git_cache setting in bot_update/api.py

BUG=589140
R=szager@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/1784043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299260 0039d316-1c4b-4281-b951-d872f2087c98

5fc657ba

11 Mar, 2016 1 commit

Roll recipe dependencies (trivial). · a516b591

recipe-roller@chromium.org authored Mar 11, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1786883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299256 0039d316-1c4b-4281-b951-d872f2087c98

a516b591

10 Mar, 2016 2 commits

Roll recipe dependencies (trivial). · 62a585a6

recipe-roller@chromium.org authored Mar 10, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1781083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299218 0039d316-1c4b-4281-b951-d872f2087c98

62a585a6

Roll recipe dependencies (trivial). · 059ff501

recipe-roller@chromium.org authored Mar 10, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1784623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299202 0039d316-1c4b-4281-b951-d872f2087c98

059ff501

09 Mar, 2016 5 commits

depot_tools: adjust for resource API changes in recipe engine · 88e173be

phajdan.jr@chromium.org authored Mar 09, 2016

This is rolling in https://codereview.chromium.org/1777003003

BUG=593420

Review URL: https://codereview.chromium.org/1785443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98

88e173be

Don't use 'git remote get-url', which is a new-ish feature. · 8159374e

szager@chromium.org authored Mar 09, 2016

Apparently most Mac's have git 2.6.2, which doesn't have this
feature.

This only affects end developers, so there's no urgency to push
this out to the bots.

TBR=agable@chromium.org,wkorman@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/1777043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299185 0039d316-1c4b-4281-b951-d872f2087c98

8159374e

Let package_from_installed actually package the json files it now writes. · d12b7210

thakis@chromium.org authored Mar 09, 2016

I failed to do this in https://codereview.chromium.org/1706423002

BUG=495204

Review URL: https://codereview.chromium.org/1776283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299179 0039d316-1c4b-4281-b951-d872f2087c98

d12b7210

git cl upload: print patchset when uploading to Rietvled. · f04a6e6c

tandrii@chromium.org authored Mar 09, 2016

R=andybons@chromium.org,phajdan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1772293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98

f04a6e6c

Enable git-cl-land for git-cache checkouts. · 151ebcff

szager@chromium.org authored Mar 09, 2016

The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote.

BUG=589140
R=wkorman,agable,iannucci,martiniss

Review URL: https://codereview.chromium.org/1777693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299166 0039d316-1c4b-4281-b951-d872f2087c98

151ebcff

08 Mar, 2016 5 commits

Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6... · 907a1e7c

martiniss@chromium.org authored Mar 08, 2016

Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6 id:100001 of https://codereview.chromium.org/1762513002/ )

Reason for revert:
Roll into build breaks infra crons.

Original issue's description:
> Use gclient's git_cache setting in bot_update/api.py
>
> BUG=589140
> R=agable@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299120

TBR=agable@chromium.org,hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,wkorman@chromium.org,szager@chromium.org
BUG=589140

Review URL: https://codereview.chromium.org/1776193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299160 0039d316-1c4b-4281-b951-d872f2087c98

907a1e7c

Roll recipe dependencies (trivial). · ae9e80cc

recipe-roller@chromium.org authored Mar 08, 2016


R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1771893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299159 0039d316-1c4b-4281-b951-d872f2087c98

ae9e80cc

depot_tools: expose path to download_from_google_storage · 61960393

phajdan.jr@chromium.org authored Mar 08, 2016

BUG=585401

Review URL: https://codereview.chromium.org/1770383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299158 0039d316-1c4b-4281-b951-d872f2087c98

61960393

Make CACHE_DIR set by default in most gclient configs. · 3ce9b444

martiniss@chromium.org authored Mar 08, 2016

This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140

Review URL: https://codereview.chromium.org/1768893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299143 0039d316-1c4b-4281-b951-d872f2087c98

3ce9b444

git-cl-try: print proper access denied error msg · baff4e1c

nodir@chromium.org authored Mar 08, 2016

git-cl-try does not properly print error message when the response
status code is 403, because response parsing is broken.
Fix response parsing.

R=sheyang@chromium.org, tandrii@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1773963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299137 0039d316-1c4b-4281-b951-d872f2087c98

baff4e1c