- 13 Mar, 2019 1 commit
-
-
Vadim Shtayura authored
Changes: 2019-03-12 seanabraham@chromium.org chromiumos-protos: Use new builder proto location 2019-03-12 vadimsh@chromium.org [lucicfg] Implement 'equivalent_to' support in CQ config generator. 2019-03-12 dburger@chromium.org Add Id and General configs to BuilderConfig. 2019-03-12 seanabraham@chromium.org testplans: Use protos in chromiumos/infra/proto rather than in lucicfg/external 2019-03-12 hinoka@google.com [milo] Add default_commit_limit and default_expand to console definitions 2019-03-11 vadimsh@chromium.org [lucicfg] Recognize e.g. 'builder = lucicfg.rule(impl = _builder)' in docgen. R=tandrii@chromium.org, nodir@chromium.org CC=dburger@chromium.org Change-Id: I73a54bfe19a86e59e22bd320df6b4d414f654a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521149Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 07 Mar, 2019 1 commit
-
-
Vadim Shtayura authored
Changes: 2019-03-07 dburger@chromium.org Add dummy BuilderConfig proto to lucicfg external protos. 2019-03-06 vadimsh@chromium.org [lucicfg] Forbid "luci.*" bucket names in luci.bucket(...). 2019-03-06 vadimsh@chromium.org [lucicfg] Use 'flatten_buildbucket_cfg' tool to normalize cr-buildbucket.cfg. 2019-03-06 vadimsh@chromium.org [lucicfg] Add 'triggered_by' support to CQ config generator. 2019-03-06 vadimsh@chromium.org [lucicfg] Add "lucicfg semantic-diff" subcommand to aid in the migration. 2019-03-05 vadimsh@chromium.org [lucicfg] Add luci.cq_tryjob_verifier(...). 2019-03-05 vadimsh@chromium.org [lucicfg] Add retry_config support. 2019-03-04 vadimsh@chromium.org [lucicfg] Initial implementation of luci.cq_group(...). 2019-03-02 vadimsh@chromium.org [lucicfg] Make '#!/usr/bin/env lucicfg' work. 2019-02-28 vadimsh@chromium.org [lucicfg] Add luci.cq(...) rule. 2019-02-27 vadimsh@chromium.org [lucicfg] Get rid of `refs_regexps`, always accept regexps via `refs`. 2019-02-27 seanabraham@chromium.org crostesting: Change "BuildCritera" to "TargetCriteria" R=tandrii@chromium.org Change-Id: I8477088c50764ba847424eb1e59be34d03d86eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509016 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 28 Feb, 2019 1 commit
-
-
Robert Iannucci authored
The newest version isn't quite ready for prime-time (it drops support for the `-repository` kitchen flag, which is still passed by buildbucket). I should be able to reland this later today. TBR=nodir@chromium.org, tandrii@chromium.org, vadimsh@chromium.org Bug: 936254 Change-Id: I18d25886cb008dc6f1a32a7ff85ec95b4a055b02 Reviewed-on: https://chromium-review.googlesource.com/c/1495205Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 26 Feb, 2019 1 commit
-
-
Vadim Shtayura authored
Hopefully it works better on OSX 10.14. R=tandrii@chromium.org BUG=936067 Change-Id: I097802a053b7f17b81f13a69c1f0c153dc327b10 Reviewed-on: https://chromium-review.googlesource.com/c/1489874Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 22 Feb, 2019 1 commit
-
-
Vadim Shtayura authored
Change log: https://chromium.googlesource.com/infra/luci/luci-go/+log/ea41200b..1d348dee/lucicfg R=tandrii@chromium.org CC=andrewlamb@google.com Change-Id: I37b8a33971348b24db53ddf384ec3f5d7088e283 Reviewed-on: https://chromium-review.googlesource.com/c/1483872Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 20 Feb, 2019 1 commit
-
-
Robert Iannucci authored
cc015d890 Roll infra/go/src/go.chromium.org/luci/ 0d6874412..340fb1e12 (7 commits) 2378074b7 [led] Give auth-login advice everywhere we get an authClient. b48969046 Roll infra/go/src/go.chromium.org/luci/ e48c958d0..44257920e (6 commits) 072630eb2 [led] Edit the right properties instead of the old properties :) 1673f6db0 [led] Remove interface abstraction 44ab51ec6 [led] Remove support for rietveld URLs. R=nodir@chromium.org Change-Id: Ic4d4842722a63bbd2369feff8c7df722eab86865 Reviewed-on: https://chromium-review.googlesource.com/c/1474426 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 12 Feb, 2019 1 commit
-
-
Vadim Shtayura authored
Change log: https://chromium.googlesource.com/infra/luci/luci-go/+log/e48c958d0748..2af4f06eb36/lucicfg R=maruel@chromium.org Change-Id: Id2bc5be90e7baf872d79f032fa1e01e2832a8e75 Reviewed-on: https://chromium-review.googlesource.com/c/1465209Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 05 Feb, 2019 1 commit
-
-
Vadim Shtayura authored
Change log: https://chromium.googlesource.com/infra/luci/luci-go/+log/e2281b0154c8..e48c958d0748/lucicfg R=tandrii@chromium.org BUG=925532 Change-Id: Id9fe0493d739e5f6b71ff4bbd9dd7c34a000aff1 Reviewed-on: https://chromium-review.googlesource.com/c/1453477 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 30 Jan, 2019 1 commit
-
-
Vadim Shtayura authored
It knows how to interpret configuration files written in Starlark-based DSL and produce a bunch of protobuf messages as a result. Will be used to generate various infra configs. In particular, will be used by infra developers (to update configs), by PRESUBMIT.py on dev machines (to verify configs before uploading CLs) and by bots (to verify configs before submitting CLs). R=tandrii@chromium.org BUG=833946 Change-Id: Iceec7d808ce180f7d4a341fab8b5ce11933c2a6b Reviewed-on: https://chromium-review.googlesource.com/c/1444499 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 13 Dec, 2018 1 commit
-
-
Robert Iannucci authored
This removes the '-mode' flag from the emitted job descriptions. TBR=nodir@chromium.org Bug: 914196,914926 Change-Id: I94ab67f0969b198164fa3fc3ef64a649dcf941bd Reviewed-on: https://chromium-review.googlesource.com/c/1376657Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 21 Nov, 2018 1 commit
-
-
Robert Iannucci authored
Now with correct error handling. R=nodir@chromium.org, vadimsh@chromium.org Bug: 869227 Change-Id: I961fd80209c9d9988e9d03016b7c0bd253c6cdfb Reviewed-on: https://chromium-review.googlesource.com/c/1347249 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
- 20 Nov, 2018 2 commits
-
-
Vadim Shtayura authored
This reverts commit f4913068. Reason for revert: panics, see b/119830955 Original change's description: > [vpython] Roll to pick up user differentiation of cached envs. > > R=vadimsh@chromium.org > > Bug: 869227 > Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f > Reviewed-on: https://chromium-review.googlesource.com/c/1344638 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Auto-Submit: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org Change-Id: Ie77d559dc1787ec1b8a19076238b7018d39dd0b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869227 Reviewed-on: https://chromium-review.googlesource.com/c/1344639Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Robert Iannucci authored
R=vadimsh@chromium.org Bug: 869227 Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f Reviewed-on: https://chromium-review.googlesource.com/c/1344638 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
- 16 Nov, 2018 1 commit
-
-
Robert Iannucci authored
Fixes issue with bogus secret bytes being included when running `led get-build`. The server would return "<REDACTED>".encode("base64"), and led would pass this along to the task, which would fail to decode it as a proto. R=nodir@chromium.org, vadimsh@chromium.org Change-Id: Ie8b33a2dc1f05ddb163465d72ea461f9e6833363 Reviewed-on: https://chromium-review.googlesource.com/c/1340504 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 15 Nov, 2018 1 commit
-
-
Robert Iannucci authored
R=vadimsh@chromium.org Change-Id: Ibd55035fe62ae710cdce448ec489bf7af06925fd Reviewed-on: https://chromium-review.googlesource.com/c/1337522 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 12 Nov, 2018 1 commit
-
-
Robert Iannucci authored
R=bpastene@chromium.org, nodir@chromium.org Bug: 904478 Change-Id: I087c4e5a3a88339869573f214e6f415dd54f82aa Reviewed-on: https://chromium-review.googlesource.com/c/1332027 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org>
-
- 10 Nov, 2018 1 commit
-
-
Robert Iannucci authored
R=nodir@chromium.org Change-Id: I37a0647ad9358a9e9b88f25b737385556428ebcd Reviewed-on: https://chromium-review.googlesource.com/c/1329997 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
- 09 Nov, 2018 1 commit
-
-
Vadim Shtayura authored
The most notable change is in how the integrity of the tag cache file is checked. Once deployed, existing tag cache files will be considered invalid and wiped. The only observable side effect is the following line in the log: "can't deserialize tag cache - no sha256 is recorded in the file" R=tandrii@chromium.org, iannucci@chromium.org Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62 Reviewed-on: https://chromium-review.googlesource.com/c/1327823Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 09 Oct, 2018 1 commit
-
-
Robert Iannucci authored
TBR=tandrii@chromium.org, vadimsh@chromium.org Change-Id: Ie976820701359bb4976d251b3de4f1077d2357ac Reviewed-on: https://chromium-review.googlesource.com/c/1271304 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 05 Oct, 2018 1 commit
-
-
Ryan Tseng authored
Picks up https://chromium-review.googlesource.com/c/1260068 Bug: 891925 Change-Id: If2df9ea7ce2d1bcbaca8533935f6e6d30dcd8810 Reviewed-on: https://chromium-review.googlesource.com/c/1263015Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 03 Oct, 2018 1 commit
-
-
Robert Iannucci authored
R=tandrii@chromium.org, vadimsh@chromium.org Change-Id: I1f235cf959e92e4430cff7dcd0d292db1721319d Reviewed-on: https://chromium-review.googlesource.com/c/1257585Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 24 Sep, 2018 1 commit
-
-
Robert Iannucci authored
TBR=tandrii@chromium.org, vadimsh@chromium.org Bug: 875089 Change-Id: Ia48c7c67df8bdbd9bc0573406bd9f56f6cfe5d49 Reviewed-on: https://chromium-review.googlesource.com/1241677Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 18 Sep, 2018 1 commit
-
-
Vadim Shtayura authored
Together with already committed cipd_client_version.digests file, this cryptographically binds contents of CIPD packages used by depot_tools with depot_tool's git revision (assuming the CIPD client pinned by cipd_client_version.digests is trusted too, which can presumably be verified when it is being pinned). This holds true even if the CIPD backend is compromised. The worst that can happen is a denial of service (e.g. if the backend refuses to serve packages at all). If a bad backend tries to serve a malicious (unexpected) CIPD client, 'cipd' bootstrap script (and its powershell counterpart) will detect a mismatch between SHA256 of the fetched binary and what's specified in cipd_client_version.digests, and will refuse to run the untrusted binary. Similarly, if the bad backend tries to serve some other unexpected package (in place of a package specified in cipd_manifest.txt), the CIPD client (already verified and trusted as this point) will detect a mismatch between what was fetched and what's pinned in cipd_manifest.versions, and will refuse to install untrusted files. cipd_manifest.versions was generated from cipd_manifest.txt by: $ cipd ensure-file-resolve -ensure-file cipd_manifest.txt This will have to be rerun each time cipd_manifest.txt is updated. There's a presubmit check that verifies *.versions file is up-to-date (it's part of 'cipd ensure-file-verify'). BUG=870166 R=nodir@chromium.org, iannucci@chromium.org, tandrii@chromium.org Change-Id: I25314adf0a9b05c69cd16e75aff01dbc79c87aa5 Reviewed-on: https://chromium-review.googlesource.com/1227435 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-