Commits · deb384f985d00de73ee29a65760b826f08a60983 · Linshizhi / Chromium_Depot_tools

13 Mar, 2019 1 commit

[lucicfg] Bump lucicfg version 1.5.3 -> v1.5.4. · deb384f9

Vadim Shtayura authored Mar 13, 2019

Changes:
2019-03-12 seanabraham@chromium.org chromiumos-protos: Use new builder proto location
2019-03-12 vadimsh@chromium.org [lucicfg] Implement 'equivalent_to' support in CQ config generator.
2019-03-12 dburger@chromium.org Add Id and General configs to BuilderConfig.
2019-03-12 seanabraham@chromium.org testplans: Use protos in chromiumos/infra/proto rather than in lucicfg/external
2019-03-12 hinoka@google.com [milo] Add default_commit_limit and default_expand to console definitions
2019-03-11 vadimsh@chromium.org [lucicfg] Recognize e.g. 'builder = lucicfg.rule(impl = _builder)' in docgen.

R=tandrii@chromium.org, nodir@chromium.org
CC=dburger@chromium.org

Change-Id: I73a54bfe19a86e59e22bd320df6b4d414f654a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521149Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

deb384f9

12 Mar, 2019 7 commits

cipd: link directly to created package on chrome-infra-packages. · 8b94108e

John Budorick authored Mar 12, 2019

I've been using this recipe module for a new internal builder
(http://shortn/_wvjqgrpIGb) and it seems odd to have the package
name and instance ID in the step text rather than a link directly
to the site. (Perhaps the module predates the CIPD UI rewrite?)

Recipe-Nontrivial-Roll: infra
Change-Id: Iab6080c3c6110ac2205cb3de397055b30d881d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1496953Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

8b94108e

Add sdk_root property to windows_sdk module · 920bada9

Veranika Liaukevich authored Mar 12, 2019

Bug: 926631
Change-Id: Ie2ce79dd5f2cb75ef5160dda5ff5d8dd497beead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1518793Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

920bada9

Roll recipe dependencies (trivial). · 77e5d48a

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aef5bb3df38a8c316b2af0301be808e34c749583 Trivial doc change to test new recipe roller setup. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I998e054a24c5960acc4bf84e9fd7743ad315e6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1517203Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

77e5d48a

Make sys a top-level import in gclient_paths. · 112a77f4

Dirk Pranke authored Mar 12, 2019

sys takes essentially no time to import (I think possibly because
it's a built-in?), and importing it as-needed is fragile. Make
it a top-level import to gclient_paths to prevent future breakages.

BUG=939959

Change-Id: I1ebe1260afd927355d668acf3cab5067ff0a2e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1515669Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

112a77f4

Roll recipe dependencies (trivial). · 8195bd9e

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/be611800cb1d17d3eeb7b3ab53e1acb056f8d50f [run_build] Improve fake_kitchen to actually run butler service. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic90a9f7ecd9d0add27d63e93d2acd23e1b474405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516446Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8195bd9e

my_activity.py: Add date to format · 860378ee

Lutz Justen authored Mar 12, 2019

Allows adding the created and modified dates to the output. Doesn't
change the default behavior.

Example:
$ my_activity.py --begin=01/01/19 -f "{created} {modified} {url} {title}"
2018-12-19 2019-01-09 https://crbug.com/916521 Tests do not resolve libbrillo-libchrome dependency properly
2018-12-05 2019-01-14 https://crbug.com/912312 authpolicy: Cache authentication data

BUG=None

Change-Id: Idfe8aa9553dfb8f9774ee4915e85b6167e6fb75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1511252
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

860378ee

Roll recipe dependencies (trivial). · 18bfe479

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f270edd89315dd13dbeddd19ccb73ed7038dcc2b Improve fake_kitchen, add LUCI_CONTEXT support, add nonfunctional run_steps. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0da492a71345edb55d86ee4a6b0c74a571b761c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516864Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

18bfe479

11 Mar, 2019 7 commits

Roll recipe dependencies (trivial). · a1488d4d

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a9e17d2bfaefc76e7355cb5123f1fe6ebcf4af9b Fix the assertions.assertRaises{,Regexp} to act as context managers. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3be3012b9264c1d16dd8fbf4a4a449c9db2a96fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516443
Reviewed-by: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a1488d4d

Roll recipe dependencies (trivial). · 8220b123

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d21dc6a81bce49816df20745cb36daa73ca28f8c Fix the assertions whitelist. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1c8a563f9dca9d73ab5a1d0d83b3d06312ee5275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516441
Reviewed-by: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8220b123

Roll recipe dependencies (trivial). · ab83aac1

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5ffb2e26442a8cd2d109686ef16f8ae9f7ea8979 Add support for longMessage and maxDiff to assertions api. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1b4a6392a6b25051741e612893b1422b895e92d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516438Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ab83aac1

Fixing getting machine arch on AIX running in an LPAR environment · 973788f8

Milad Farazmand authored Mar 11, 2019

Trying to get "host_cpu" in DEPS file may fail on AIX.
Getting the "machine ID number" using "uname -m" on an AIX box, in an LPAR
environment will not generate a unique machine identifier and instead might
return a string such as "00f9445f4c00". "platform.processor()" will be used
as a fall back on AIX.

Change-Id: I7fada10059e29066f5a13d6135b01eaeaccb769d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504554Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

973788f8

Roll recipe dependencies (trivial). · 53aa75c9

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/515401ea01ef01bfe17a84de228d9ff467fac4e5 [isolated] Roll isolated client (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c3c18bcc46db7af74c23030fe1a69092d6ccc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516172Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

53aa75c9

Unbreak clang-format / GetBuildtoolsPlatformBinaryPath() after depot_tools/+/1512058 · ad116ba9

Nico Weber authored Mar 11, 2019

TBR=tandrii
Bug: 939959
Change-Id: Ia200eb38fda3d2572c4f1c3dc0d9f8f8fbd34362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1515874
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

ad116ba9

Move gclient path access to separate module. · 09e0b38f

Nico Weber authored Mar 11, 2019

gclient_utils.py is a kitchen sink and is for that reason expensive
to import. Move the comparatively cheap and simple path routines
to a new gclient_paths module and use that in gn.py, clang_format.py,
dart_format.py.

(To be able to move FindGclientRoot() to gclient_paths.py,
make it use io.open() instead of FileRead(). FileRead() tries
to paper over invalid utf-8, but that was added for presubmits,
not for .gclient files, so this is hopefully fine.)

Cuts gn.py overhead in half (on my Windows laptop from 0.6s to 0.25s,
still high; on my Mac laptop from 0.1s to 0.05s), and probably helps
the other two too.

Completely remove PathDifference() since it's unused.

Bug: 939959
Change-Id: I6a70f6e4c16062b622fb2df8778e8a598d4cc956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512058
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

09e0b38f

08 Mar, 2019 3 commits

Roll recipe dependencies (trivial). · 3485a263

recipe-roller authored Mar 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1c1a6b6cb1387f9791ff31497301333def7306b3 post_process: move logs extraction to its own function for reuse. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97c87ab6722fe84c907e84c04407888edd9485dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512055Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

3485a263

Avoid unnecessary invocations of "git fetch" (reland) · 73fac91f

Michael Spang authored Mar 08, 2019

If we already have the correct commit, it is not necessary to fetch.  Any
fetches can takes minutes due to gerrit problems, and often fail
completely, so it is helpful to avoid them completely whenever we can.

Reland now that skia autoroller does its own fetch.

Bug: 938627

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I5a6877125c682ff0d98bd6d2ffe495245f74c513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512024
Auto-Submit: Michael Spang <spang@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

73fac91f

Roll recipe dependencies (trivial). · cc43111e

recipe-roller authored Mar 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5b1889d51455dafc76ddd22dd58b2e90aedc129a Move more internal files to the internal package. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida69d2c114e0f7865cc1fd80c11e505e8dbedc88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509916Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

cc43111e

07 Mar, 2019 4 commits

Simplify GIT.IsValidRevision · 2f3c820a

Michael Spang authored Mar 07, 2019

We should pass --verify to tell rev-parse that we're just testing,
and use the ^{commit} dereference operator to avoid the hack of
removing a character from the commit hash to see if it's really
in the object database.

Bug: 938627

Change-Id: Ic6ea898b0a5a6a1a5d706c7586c7208ec8ca2ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504104
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

2f3c820a

[lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3. · b139178f

Vadim Shtayura authored Mar 07, 2019

Changes:
2019-03-07 dburger@chromium.org Add dummy BuilderConfig proto to lucicfg external protos.
2019-03-06 vadimsh@chromium.org [lucicfg] Forbid "luci.*" bucket names in luci.bucket(...).
2019-03-06 vadimsh@chromium.org [lucicfg] Use 'flatten_buildbucket_cfg' tool to normalize cr-buildbucket.cfg.
2019-03-06 vadimsh@chromium.org [lucicfg] Add 'triggered_by' support to CQ config generator.
2019-03-06 vadimsh@chromium.org [lucicfg] Add "lucicfg semantic-diff" subcommand to aid in the migration.
2019-03-05 vadimsh@chromium.org [lucicfg] Add luci.cq_tryjob_verifier(...).
2019-03-05 vadimsh@chromium.org [lucicfg] Add retry_config support.
2019-03-04 vadimsh@chromium.org [lucicfg] Initial implementation of luci.cq_group(...).
2019-03-02 vadimsh@chromium.org [lucicfg] Make '#!/usr/bin/env lucicfg' work.
2019-02-28 vadimsh@chromium.org [lucicfg] Add luci.cq(...) rule.
2019-02-27 vadimsh@chromium.org [lucicfg] Get rid of `refs_regexps`, always accept regexps via `refs`.
2019-02-27 seanabraham@chromium.org crostesting: Change "BuildCritera" to "TargetCriteria"

R=tandrii@chromium.org

Change-Id: I8477088c50764ba847424eb1e59be34d03d86eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509016
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

b139178f

Revert "Avoid unnecessary invocations of "git fetch"" · 0cec542e

Edward Lesmes authored Mar 07, 2019

This reverts commit 61a1b5f3.

Reason for revert:
It's blocking skia autoroller
https://skia-review.googlesource.com/c/buildbot/+/198700

Original change's description:
> Avoid unnecessary invocations of "git fetch"
> 
> If we already have the correct commit, it is not necessary to fetch.  Any
> fetches can takes minutes due to gerrit problems, and often fail
> completely, so it is helpful to avoid them completely whenever we can.
> 
> Bug: 938627
> 
> Change-Id: I54494cad9b9aa0090f51674b6b9f56bb3e842f12
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
> Commit-Queue: Michael Spang <spang@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=spang@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: If8bd26d74bf84ff0ca69378dbfe6b9369b9988d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 938627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1508980Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0cec542e

gclient: Fetch refs/{branch-heads,tags}/* if needed. · db5c5ade

Edward Lemur authored Mar 07, 2019

If we're asked to sync a repo to branch-heads or tags,
make sure we fetch refs/branch-heads/* and refs/tags/* even if
--with-branch-heads or --with-tags was not passed.

Bug: 938160
Change-Id: I04de8e7762c83322692d9551d057ec803fd2ac9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506420Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

db5c5ade

06 Mar, 2019 4 commits

Roll recipe dependencies (trivial). · ffb1ffb8

recipe-roller authored Mar 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/64b31a70df43a9a0bd220a667a5d7ea500348879 [scheduler] Use buildbucket API instead of props (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If1429732e53693d50841afe097c58916d0b83ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506286Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ffb1ffb8

Roll recipe dependencies (trivial). · 48f640f5

recipe-roller authored Mar 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2009db83ebf1017a34c5390585f3eb9f288c47e3 [run_build] Add skeleton run_build command, testing script, bundle support. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba5af13da6a11ebb79c2a2b459099fe65830f99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506282Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

48f640f5

Avoid unnecessary invocations of "git fetch" · 61a1b5f3

Michael Spang authored Mar 06, 2019

If we already have the correct commit, it is not necessary to fetch.  Any
fetches can takes minutes due to gerrit problems, and often fail
completely, so it is helpful to avoid them completely whenever we can.

Bug: 938627

Change-Id: I54494cad9b9aa0090f51674b6b9f56bb3e842f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

61a1b5f3

Also redirect stderr from the browser since Chrome recently started using it too · 0668403d

Sergiy Belozorov authored Mar 06, 2019

Example stderr output from Chrome:

  [24599:24650:0306/123817.372418:ERROR:browser_process_sub_thread.cc(209)]
  Waited 3 ms for network service

R=nodir@chromium.org

Change-Id: Idb71c9f3a2c735ee49b886896f55bdede559137c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1505792Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>

0668403d

05 Mar, 2019 5 commits

Roll recipe dependencies (trivial). · 7e68767e

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55876a3b36992bb1cf5984cb136da88de5068fd3 [buildbucket] read hostname (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16b0481fe20159a05b6c523b86776cf17d5119fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504243Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7e68767e

Roll recipe dependencies (trivial). · 314a2f06

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f069044eb4ac5e3050d42898d4f02d491d7e6c4a Reland "[buildbucket] Use RPC protobufs" (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If22b4f983b3e12eeec0e39b3fedf1b27ea0ae96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503683Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

314a2f06

Roll recipe dependencies (trivial). · d0082247

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)
  https://crrev.com/8925d49937f06510ef00b9469e53bc69c2429da9 Revert "[buildbucket] Use RPC protobufs" (martiniss@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0bbb092974b6611a0c619fd69361ad13ae93581c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503681Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d0082247

Revert "Roll recipe dependencies (trivial)." · 3963d9b2

Stephen Martinis authored Mar 05, 2019

This reverts commit 5b3bf586.

Reason for revert: Broke everything

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
>   https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I8643525a58ddbe3ee51df24493ba8de95fea73a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503678
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: I6b2491ce379298feeff84f694a552aa7d1f3a1ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504096Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

3963d9b2

Roll recipe dependencies (trivial). · 5b3bf586

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8643525a58ddbe3ee51df24493ba8de95fea73a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503678Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

5b3bf586

04 Mar, 2019 5 commits

Roll recipe dependencies (trivial). · adbf3bef

recipe-roller authored Mar 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aa56edf9619152ce9971d90461d909f215e7fab4 [third_party/logdog] Rev to latest. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8496b82c553fbc52635e781551482a7551f12cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1500916Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

adbf3bef

[bot_update] Downstream change for buildbucket proto update. · cf661acb

Robert Iannucci authored Mar 04, 2019

Downstream counterpart to https://chromium-review.googlesource.com/1481660

R=martiniss@chromium.org, nodir@chromium.org

Bug: 930761, 927716
Change-Id: Ib6390b3d27bed79a01eefa966084233e71aa8235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1496049
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

cf661acb

Add --no-branch-color option to git cl status · a3be9a52

Alan Cutter authored Mar 04, 2019

Change-Id: Ieebdb32ac316a443789e26f3be8d5dcb4f94c4b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1470404Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>

a3be9a52

Roll recipe dependencies (trivial). · 8f418985

recipe-roller authored Mar 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ae3604f2d2ae0291ecdc690672cc173e06a965ba [proto_support] Handle unicode filesystem walks. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2ab9ccba317f6a74d1c05748ca7d4cceddd0be28
Reviewed-on: https://chromium-review.googlesource.com/c/1498126Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

8f418985

autoninja: limit j value for mac · da4dbf85

Takuto Ikuta authored Mar 04, 2019

Large parallelism causes too many open files error.
Let me limit to 500 for Mac now.

Bug: 936864
Change-Id: I2fccc8cf14483c6f34d84c84d82c44df6e4f3177
Reviewed-on: https://chromium-review.googlesource.com/c/1496675Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

da4dbf85

03 Mar, 2019 1 commit

Improve error message for missing gerrit credentials in git-cl. · e9e89e3a

William Hesse authored Mar 03, 2019

Bug:
Change-Id: I058fcd85548c6e17f33de71ed2ad04549294e13d
R: dpranke@chromium.org, iannucci@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/558250Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e9e89e3a

02 Mar, 2019 2 commits

Roll recipe dependencies (trivial). · 71bae22f

recipe-roller authored Mar 02, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1a86f54ceba35d31196e8664958e53ba8f64cbd2 cq: fix a comment. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6b5d17b19a7f0c9d5802ba9959abc064f1ad98a3
Reviewed-on: https://chromium-review.googlesource.com/c/1497658Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

71bae22f

Roll recipe dependencies (trivial). · c9031987

recipe-roller authored Mar 02, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0c4c8afe0d49874f5d596697b09057aa3be0a64c [source_manifest] Use PB for source manifest proto. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e0942b4bd9bbe4b32b239aee88ab6c234f1cf07
Reviewed-on: https://chromium-review.googlesource.com/c/1496053Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

c9031987

01 Mar, 2019 1 commit

Roll recipe dependencies (trivial). · 6008eaf2

recipe-roller authored Mar 01, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/921a0d25cc4e1ccc382944bcfadda66e4f04948a Add proper protobuf support to recipe engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0638634da889a2a3413bbf770bbb3caaa9dc5a47
Reviewed-on: https://chromium-review.googlesource.com/c/1496042Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

6008eaf2