- 29 Jun, 2017 1 commit
-
-
Aaron Gable authored
Using the remote url is much more useful than the hash of the first commit in the repo, since we can use it to track down repos, teams, and people still using Rietveld for review. Bug: 600469 Change-Id: I067594794ba77692c11daf63b5f5844d36209a08 Reviewed-on: https://chromium-review.googlesource.com/556301Reviewed-by:
Andrew Bonventre <andybons@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 11 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I1297f817f2e3d791c22b256de40f12c0c23dceb5 Reviewed-on: https://chromium-review.googlesource.com/500807 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 15 Mar, 2017 1 commit
-
-
Aaron Gable authored
This issue is fixed in Python 2.7.12, but we don't guarantee that we use that version everywhere. The root issue is that, on certain platforms (e.g. Mac), the exception indicating that the underlying command (e.g. 'hg') was not found is too large, and loading the pickle representing the exception fails. This CL catches this specific exception and treats it identically to the OS properly raising a 'command not found' code. BUG=699173 Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f Reviewed-on: https://chromium-review.googlesource.com/455537Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 17 Feb, 2017 1 commit
-
-
Andrii Shyshkalov authored
This includes gerrit_cq_ability verifier. TBR=sergiyb@chromium.org,rmistry@chromium.org BUG= Change-Id: Ifdb09bb33dd6a6fc7fdcb592e6bc4a2f8ac474ad Reviewed-on: https://chromium-review.googlesource.com/444767Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 19 Dec, 2016 1 commit
-
-
Andrii Shyshkalov authored
R=machenbach@chromium.org BUG=644915 Change-Id: Id0035e8b286c0f5b4c0c41aec7458965b9bd1a39 Reviewed-on: https://chromium-review.googlesource.com/421514Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 28 Nov, 2016 2 commits
-
-
Mike Stipicevic authored
BUG=668526 Change-Id: Id49f1c1394a72880410eb06ba7356307fff7e8c5 Reviewed-on: https://chromium-review.googlesource.com/414496 Commit-Queue: Mike Stipicevic <stip@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
Sergiy Byelozyorov authored
BUG=668526 Change-Id: I8aa762e8836ddc4838baaca803de17f3ffcb1ad2 Reviewed-on: https://chromium-review.googlesource.com/414908Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 08 Nov, 2016 1 commit
-
-
scottmg authored
It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as opposed to one that's in the current patch). BUG=544889 Review-Url: https://codereview.chromium.org/2488823002
-
- 19 Oct, 2016 1 commit
-
-
Aaron Gable authored
BUG=657216 R=dnj@chromium.org Review URL: https://codereview.chromium.org/2431893002 .
-
- 19 Sep, 2016 1 commit
-
-
hinoka authored
A quick "git grep gsutil" reveals that this is no longer being used, and all references to gsutil are pointed to gsutil.py. BUG= Review-Url: https://codereview.chromium.org/2280023003
-
- 24 Aug, 2016 1 commit
-
-
agable authored
R=tandrii@chromium.org BUG=638750 Review-Url: https://codereview.chromium.org/2271873003
-
- 27 Jun, 2016 1 commit
-
-
nodir authored
R=pauljensen@chromium.org BUG= TEST=PatchSet 3 of this CL Review-Url: https://codereview.chromium.org/2096123003
-
- 22 Jun, 2016 1 commit
-
-
vapier authored
The ConfigParser module was renamed to configparser, so update the two modules using it to try both (and default to the new name). Review-Url: https://codereview.chromium.org/2076653002
-
- 17 Jun, 2016 1 commit
-
-
mgiuca authored
Review-Url: https://codereview.chromium.org/2075923003
-
- 16 Jun, 2016 4 commits
-
-
vapier authored
The newer form works with python2 and python3. Review-Url: https://codereview.chromium.org/2076643002
-
vapier authored
This makes the code work both in python2 and python3. Review-Url: https://codereview.chromium.org/2078553002
-
vapier authored
Review-Url: https://codereview.chromium.org/2076613002
-
vapier authored
This is in preparation for adding py3 support. Review-Url: https://codereview.chromium.org/2073823002
-
- 09 Jun, 2016 1 commit
-
-
nodir authored
git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG=582419 Review-Url: https://codereview.chromium.org/1868313002
-
- 09 Mar, 2016 1 commit
-
-
tandrii@chromium.org authored
R=andybons@chromium.org,phajdan@chromium.org BUG= Review URL: https://codereview.chromium.org/1772293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Feb, 2016 1 commit
-
-
tandrii@chromium.org authored
From infra_internal, revisions 6f979a..cd0150f. TBR=sergiyb@chromium.org,machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/1697053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298789 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Dec, 2015 1 commit
-
-
bratell@opera.com authored
R=dpranke@chromium.org,tandrii@chromium.org BUG= Review URL: https://codereview.chromium.org/1545913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298097 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Dec, 2015 1 commit
-
-
bratell@opera.com authored
If the stderr buffer used in git diff became full before stdout was completely consumed, git cl upload would deadlock. This also sets GIT_PAGER to be perfectly sure no pager is triggered by the git commands run. I haven't seen that as a problem but it's a reasonable (and common) precaution. BUG=558726 Review URL: https://codereview.chromium.org/1544813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298090 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Dec, 2015 2 commits
-
-
sergiyb@chromium.org authored
R=tandrii@chromium.org BUG=564557 Review URL: https://codereview.chromium.org/1534813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298053 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
BUG= TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1533853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298052 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Dec, 2015 1 commit
-
-
machenbach@chromium.org authored
BUG=chromium:561530 Review URL: https://codereview.chromium.org/1490473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297753 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2015 2 commits
-
-
tandrii@chromium.org authored
R=sergiyb@chromium.org BUG= Review URL: https://codereview.chromium.org/1479983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297729 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
R=akuegel@chromium.org BUG=562427 Review URL: https://codereview.chromium.org/1475033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2015 3 commits
-
-
sergiyb@chromium.org authored
Original CL: https://codereview.chromium.org/1437483002/. R=dnj@google.com, tandrii@chromium.org, dnj@chromium.org, pgervais@chromium.org BUG=542922, 503067 Review URL: https://codereview.chromium.org/1407953011 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297494 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@google.com authored
Revert of Removed virtualenv from depot_tools (patchset #1 id:1 of https://codereview.chromium.org/1437483002/ ) Reason for revert: This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this. update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems. I'm reverting to restore the toolchain so we can create new Windows bots. Original issue's description: > Removed virtualenv from depot_tools > > This effectively reverts http://crrev.com/1195423002 and > http://crrev.com/1205873002. > > R=pgervais@chromium.org, tandrii@chromium.org > TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) > BUG=542922,503067 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491 TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542922,503067 Review URL: https://codereview.chromium.org/1431173002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
This effectively reverts http://crrev.com/1195423002 and http://crrev.com/1205873002. R=pgervais@chromium.org, tandrii@chromium.org TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) BUG=542922,503067 Review URL: https://codereview.chromium.org/1437483002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Oct, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=akuegel@chromium.org Review URL: https://codereview.chromium.org/1412393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297201 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Oct, 2015 1 commit
-
-
stip@chromium.org authored
Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ ) Reason for revert: Outage is now over Original issue's description: > Temporary fix for codereview cert issue. > > BUG=537763 > R=stip@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 TBR=tandrii@google.com,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537763 Review URL: https://codereview.chromium.org/1374223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Sep, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=537763 R=stip@chromium.org Review URL: https://codereview.chromium.org/1376333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Sep, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org, rmistry@chromium.org Review URL: https://codereview.chromium.org/1309393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296530 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Aug, 2015 1 commit
-
-
petermayo@chromium.org authored
This issue is cloned from https://codereview.chromium.org/1273083004/ for andreyu BUG=chromium:517460 R=vapier@chromium.org Review URL: https://codereview.chromium.org/1281273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296285 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jul, 2015 1 commit
-
-
iannucci@chromium.org authored
* make RunTest's multiprocessing.Pool in the constructor of InputApi to avoid getting tripped up by chdir manipulation. * Don't do the split cyclic-import check when the invoker of the Pylint presubmit checks explicitly sends cyclic import check parameters via extra_args * fix pseudobug where ownership of the files variable was unclear, and pass all arguments on stdin (instead of mix of CLI + stdin). * fix bug in pylint which caused it to manipulate sys.path before spawning its subprocesses, which caused multiprocessing to fail on windows. * Note: This may carry a slight semantic change. Before, pylint would add all .py files' directories to sys.path while checking any of them. Now in parallel mode, pylint will only add the path of the single file to sys.path. This behavior actually mirrors Python's own behavior, so the check should be more-correct than before (and should cut down on pylint import scanning time with very large sys.path's). * If someone encounters an issue with this, please note that the GetPylint check also includes an extra_paths_list which is expressly for this purpose. R=dpranke@chromium.org, kbr@chromium.org, maruel@chromium.org BUG=501012 Review URL: https://codereview.chromium.org/1208743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org BUG=503067 Review URL: https://codereview.chromium.org/1195423002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295843 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=akuegel@chromium.org, pgervais@chromium.org BUG=472612, 503068 Review URL: https://codereview.chromium.org/1200863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295818 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 1 commit
-
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-