Commit e1fe1ff0 authored by Andrii Shyshkalov's avatar Andrii Shyshkalov Committed by Commit Bot

Update CQ proto files to 07b713a88.

This includes gerrit_cq_ability verifier.

TBR=sergiyb@chromium.org,rmistry@chromium.org
BUG=

Change-Id: Ifdb09bb33dd6a6fc7fdcb592e6bc4a2f8ac474ad
Reviewed-on: https://chromium-review.googlesource.com/444767Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
parent 3e631421
......@@ -13,6 +13,10 @@ When modifying cq.proto, consider adding checks to validator in
[https://chrome-internal.googlesource.com/infra/infra_internal/+/master/appengine/commit_queue/src/commitqueue/validate.go]().
## Updating depot_tools with the copy of this.
make update-depot-tools
## Generation of Python and Go bindings
### tl;dr
......
This diff is collapsed.
......@@ -45,10 +45,10 @@ message Config {
// source repository is not supported by luci-config (e.g. GitHub).
optional string git_repo_url = 10;
// Target ref to commit to. This can be used to specify a different ref than
// the one where the luci config is located. This is useful, e.g. for projects
// that use gnumbd where CQ should commit into a pending ref.
optional string target_ref = 11;
// DO NOT USE. Kept here for validator error messages
// and internal CQ usage (and insanity).
// TODO(tandrii): clean insanity internally and update this message.
optional string target_ref = 11 [deprecated = true];
// DO NOT USE. Kept here for validator error messages.
optional string svn_repo_url = 12 [deprecated = true];
......@@ -104,13 +104,19 @@ message Gerrit {
// describes types of verifiers that should be applied to each CL and their
// parameters.
message Verifiers {
// This verifier is used to ensure that an LGTM was posted to the code review
// site from a valid project committer.
// It is ignored in case of Gerrit, and you should not declare it unless you
// use both Gerrit and Rietveld for codereview. Unlike Rietveld, Gerrit has
// its own ACL system which should be set up by project admins.
// [Rietveld only] This verifier is used to ensure that an LGTM was posted to
// the code review site from a valid project committer. It also validates
// ability of non-committers to trigger CQ, which for Gerrit is done by
// GerritCQAbilityVerifier.
optional ReviewerLgtmVerifier reviewer_lgtm = 1;
// [Gerrit only] GerritCQAbilityVerifier ensures that a user who triggered
// this CQ attempt has actually rights to do so based on 3 factors:
// * membership of the user in committers & dryrunners group,
// * the state of CL/patchset on which CQ is triggered,
// * relationship of the user to the CL.
optional GerritCQAbilityVerifier gerrit_cq_ability = 5;
// This verifier is used to check tree status before committing a CL. If the
// tree is closed, then the verifier will wait until it is reopened.
optional TreeStatusLgtmVerifier tree_status = 2;
......@@ -148,6 +154,19 @@ message Verifiers {
optional string dry_run_access_list = 4;
}
message GerritCQAbilityVerifier {
// Required. Name of the chrome-infra-auth group, which contains the list of
// identities authorized to trigger CQ runs on any CLs in this project.
optional string committer_list = 1;
// Optional, but strongly recommended. Name of the chrome-infra-auth group,
// which contains the list of identities authorized to trigger CQ dry run
// on Gerrit CLs they own (not to be confused with OWNER files) even if CL
// hasn't been approved.
// This is usually the same group as tryjob-access.
optional string dry_run_access_list = 4;
}
message TreeStatusLgtmVerifier {
// Required. URL of the project tree status app.
optional string tree_status_url = 1;
......
This diff is collapsed.
......@@ -5,7 +5,6 @@ commit_burst_delay: 600
max_commit_burst: 10
in_production: false
git_repo_url: "http://chromium.googlesource.com/infra/infra.git"
target_ref: "refs/pending/heads/master"
rietveld {
url: "https://codereview.chromium.org"
......
......@@ -5,7 +5,6 @@ commit_burst_delay: 600
max_commit_burst: 10
in_production: false
git_repo_url: "https://chromium.googlesource.com/infra/infra.git"
target_ref: "refs/pending/heads/master"
gerrit {
cq_verified_label: "Commit-Queue-Verified"
......
......@@ -5,7 +5,6 @@ commit_burst_delay: 600
max_commit_burst: 10
in_production: false
git_repo_url: "http://github.com/infra/infra.git"
target_ref: "refs/pending/heads/master"
rietveld {
url: "https://codereview.chromium.org"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment