Commits · d55c50771361fa0295d9e14b6ab061db042c7772 · Linshizhi / Chromium_Depot_tools

20 Feb, 2020 1 commit

git-cl: Mock DieWithError and GitSanityTests · d55c5077

Edward Lemur authored Feb 20, 2020

Bug: 1051631
Change-Id: I20f68db7dd0a901ff53513998e148cf4ba2c3eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2065133Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d55c5077

19 Feb, 2020 8 commits

repo: update to 2.4 launcher · 56c9bd5a

Mike Frysinger authored Feb 19, 2020

Bug: None
Test: `repo sync` still works
Change-Id: Ibef61ccda4640dfc6a28b9a919e50f7a8162bf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062618Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

56c9bd5a

git-cl: Mock GetChangeDetail on tests. · 7677e5cc

Edward Lesmes authored Feb 19, 2020

Mock GetChangeDetail instead of using self.calls to make the code
easier to change.

Bug: 1051631
Change-Id: I77361caccaf694644839825d890343864267688f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062716
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

7677e5cc

gclient_eval, gclient_utils: Fix Python 3.9 removal of collections members · 6693d092

Raul Tambre authored Feb 19, 2020

Various collections module members were removed in Python 3.9 after being deprecated and moved to collections.abc in earlier Python 3 versions.
For accessing these members alias collections_abc as:
* collections.abc on Python 3
* collections on Python 2

Traceback (most recent call last):
  File "C:\Google\depot_tools\gclient.py", line 107, in <module>
    import gclient_eval
  File "C:\Google\depot_tools\gclient_eval.py", line 11, in <module>
    import gclient_utils
  File "C:\Google\depot_tools\gclient_utils.py", line 1201, in <module>
    class FrozenDict(collections.Mapping):
AttributeError: module 'collections' has no attribute 'Mapping'

Traceback (most recent call last):
  File "C:\Google\depot_tools\gclient.py", line 107, in <module>
    import gclient_eval
  File "C:\Google\depot_tools\gclient_eval.py", line 25, in <module>
    class _NodeDict(collections.MutableMapping):
AttributeError: module 'collections' has no attribute 'MutableMapping'

Bug: 984182
Change-Id: I7a4417978b93e29397e63764e4570a598c075bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2043879
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6693d092

git-cl: Use scm.GIT.GetConfig in more places. · 26964072

Edward Lemur authored Feb 19, 2020

Bug: 1051631
Change-Id: I43460b72dfbc9c8210c2d8fdf5d29e876a5637f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2056648Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

26964072

Roll recipe dependencies (trivial). · 5e1d29fc

recipe-roller authored Feb 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/90eb05b0df05f7840e58ff3c9f3685af0c89a27d (guterman@google.com)
Add --stop flag to run/train which fails fast

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie51e696713fd0019828141d5a11b2914b08138a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062620Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5e1d29fc

Roll recipe dependencies (trivial). · 68e5c907

recipe-roller authored Feb 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a7a70da79ed53f56f5150bb7d1eb577aca51c457 (yiwzhang@google.com)
    [bb] Fix the bug that search api only returns 1000 builds max when limit>1000

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ife6d21365e0f7707382c25caacf2a929ab2a193d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2064606Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

68e5c907

Roll bb tool to @ 37d99607 · 10e0e6d6

Andrii Shyshkalov authored Feb 19, 2020

Old revision: 1ab4441a

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/1ab4441a..37d99607
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/0f62d394..7ffc1965

Bug: 1052637
Change-Id: I49129e3f4e68961dbd6055a07f3d0a9cd7bc3111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2063381
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

10e0e6d6

Roll lucicfg tool to @ 3b479f0e v1.12.3. · 1fbe7c0b

Andrii Shyshkalov authored Feb 19, 2020

Old revision: 54dac392

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/54dac392..3b479f0e
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/addc6508..ae97ada2/lucicfg

Bug: 925080
Change-Id: I5fb37c83b7e8a4d3e8aacb7fe29e3ea89c9683e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2063216
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

1fbe7c0b

14 Feb, 2020 2 commits

git-cl: Use scm.GIT.{Get,Set}BranchConfig and {Get,Set}BranchRef instead of git calls. · 85153289

Edward Lemur authored Feb 14, 2020

scm.GIT functions are tested, and using them makes it easier to mock
git calls on git-cl tests.

Bug: 1051631
Change-Id: If067aa3f71b7478cafd7985d3020dacc0c6a41c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055464Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

85153289

[lucicfg] Update in depot_tools to 1.12.2 · c4243361

Marc-Antoine Ruel authored Feb 14, 2020

R=iannucci@chromium.org, tandrii@chromium.org

Bug: 1051164
Change-Id: I2c6cccc14cb8a86e27f5469c02d5a6af99160672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2056967
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

c4243361

13 Feb, 2020 9 commits

Roll bb tool to @ 1ab4441 · 86fbe04c

Yiwei Zhang authored Feb 13, 2020

Old revision: 9b687fbe

infra/infra change log:
  https://chromium.googlesource.com/infra/infra/+log/9b687fbe..1ab4441

luci_go change log:
  https://chromium.googlesource.com/infra/luci/luci-go/+log/fa8b9bf0..0f62d39

R=tandrii

Bug: 1039823
Change-Id: I85bafb139aa6b251418323bc839d978cf66038af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053730
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

86fbe04c

Roll recipe dependencies (trivial). · ca1907e5

recipe-roller authored Feb 13, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/33fed4343ba9723f8d4e16dd04978f27490f0a57 (gbeaty@chromium.org)
Report run steps in the order they were run.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77a0aba8f5fa355f96e51555b1aa9cf16dbf7927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055395Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ca1907e5

Revert "gerrit-util: Fix GCE check from behind proxy." · ca9a5ebc

Edward Lesmes authored Feb 13, 2020

This reverts commit 9ee86e5a.

Reason for revert: Typo.

Original change's description:
> gerrit-util: Fix GCE check from behind proxy.
> 
> Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
> to fail.
> 
> The behavior of an unreachable server behind proxy is different from a direct
> connection, it won't throw a httplib2.ServerNotFoundError error,
> so catch httplib2.Httplib2Error instead.
> 
> Bug: 1050380
> Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Idb17520e71fc1d892694e0d4d1cf1630a42bb482
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055390Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ca9a5ebc

gerrit-util: Fix GCE check from behind proxy. · 9ee86e5a

Edward Lemur authored Feb 13, 2020

Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
to fail.

The behavior of an unreachable server behind proxy is different from a direct
connection, it won't throw a httplib2.ServerNotFoundError error,
so catch httplib2.Httplib2Error instead.

Bug: 1050380
Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9ee86e5a

Add tikuta, <user>@chromium.org to GOMA_OWNERS · e9ed65aa

Simon Que authored Feb 13, 2020

Bug: None
Change-Id: Ib8f349044e3ea1a6ac7dd0c5428f5c561e36ac5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053627Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

e9ed65aa

roll out new goma client binary (VERSION=190) · 0c4a5eb7

Simon Que authored Feb 13, 2020

https://chromium.googlesource.com/infra/goma/client/+/bf6b833ba9f59247d9b6542d9c9852c1bed22e04

BUG=b/148913740

Change-Id: I0d107d4c22daa86f0f3e0587530b7f651bca08ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053623Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Simon Que <sque@chromium.org>

0c4a5eb7

git-cl: Use scm.GIT.FetchUpstreamTuple. · 15a9b8cc

Edward Lemur authored Feb 13, 2020

scm:
- Add methods to deal with git configs and tests for them.
  Will make it easier to mock git config calls as opposed
  to all git calls.
- Add tests to FetchUpstreamTuple

git-cl:
- Mock out settings.GetChangeRoot()
- Use scm.GIT.FetchUpstreamTuple() to reduce code duplication,
  and mock it out on tests.

Bug: 1051631
Change-Id: I1a3220b4c0f3e6221b3c00550259a433c2775798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052552
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

15a9b8cc

git-cl: Use mock.patch instead of custom mock. · da4b6c6e

Edward Lemur authored Feb 13, 2020

Bug: 1051631
Change-Id: I0c8222f89477300e6a14296b72ecaa01d65ca32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052627Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

da4b6c6e

repo: update to 2.3 launcher · da8eec5d

Mike Frysinger authored Feb 13, 2020

This pulls the latest version from upstream.  Largely should be
bugfixes, but there's a few new hot features too!

Bug: https://crbug.com/gerrit/10418
Test: `repo sync` still works
Change-Id: Icd901b490857083f047ce900990769efdf5f269b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052975Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

da8eec5d

12 Feb, 2020 3 commits

Revert "cros: switch CrOS programs to python3" · 3d37f4f7

John Budorick authored Feb 12, 2020

This reverts commit 35b70cac.

Reason for revert: causing problems for the chromium cq, e.g.
https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/471366
https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/197740

Original change's description:
> cros: switch CrOS programs to python3
> 
> We start warning if people have outdated systems.
> 
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

TBR=vapier@chromium.org,iannucci@chromium.org,saklein@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ie85691d9f847ad7edb4c9932a0788431c886fec2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052543Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

3d37f4f7

cros: switch CrOS programs to python3 · 35b70cac

Mike Frysinger authored Feb 12, 2020

We start warning if people have outdated systems.

Bug: 997354
Test: `cros --help` uses python3 now
Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

35b70cac

Roll recipe dependencies (trivial). · 1de518cc

recipe-roller authored Feb 12, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/ee858e5e410b4d30b666b29ebd759866300a5504 (tikuta@chromium.org)
swarming: update swarming binary

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97f4569e4089b0a5c0fa6c5e3e62689916a12d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2051730Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1de518cc

11 Feb, 2020 2 commits

Roll recipe dependencies (trivial). · da4dea33

recipe-roller authored Feb 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/9d6a5450a86f921c7890b72414e99e7d9828d9a5 (tandrii@chromium.org)
cq: update doc.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I83c3c1f7a03bd578d198c956dd87a297d79b5aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050541Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

da4dea33

Roll recipe dependencies (trivial). · 4fad8587

recipe-roller authored Feb 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/202779b4946ce3ff354fd4a1e9171cf132ca85c0 (maruel@google.com)
    [swarming] Roll executable, make invocation failure an infra failure
  https://crrev.com/0da3025f2afe23f98970f64f56c1869f137d4b4e (maruel@chromium.org)
    Revert "[swarming] Roll executable, make invocation failure an infra failure"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icab6411926169eb1ace0858b7bfaf34ca43467b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2048994Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4fad8587

10 Feb, 2020 1 commit

repo: update to 2.0 launcher · 64c5af3a

Mike Frysinger authored Feb 10, 2020

This pulls the latest version from upstream.

This drops the custom keys Chromium has been carrying.
We switched our release signing over to the official key,
so there's no need for ours anymore.

The new version will attempt to use Python 3 if available
and whine if it's not.  It shouldn't cause errors, just new
warnings, but it should help us track down old systems.

Bug: https://crbug.com/gerrit/10418
Test: `repo sync` still works
Change-Id: I915d0874a1642880831964f91c4632f9d17a1e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2044341Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

64c5af3a

07 Feb, 2020 2 commits

git-cl: Fix call to GetChange. · 3b8094ac

Edward Lemur authored Feb 07, 2020

GetChange now takes a single argument.

Bug: 1042324, 1050198
Change-Id: Ib8521d7134e9c7b251d590dac6759a6cc585d3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2044971Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3b8094ac

Delete tryserver.set_do_not_retry. · 8ac1b465

Andrii Shyshkalov authored Feb 07, 2020

Use cq.set_do_not_retry instead.
See https://crrev.com/c/2040838

R=yiwzhang

Change-Id: I110c398e794c19df30c42aa77e88a5da5d33276d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040709
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

8ac1b465

06 Feb, 2020 12 commits

git-cl: Don't use assertRegexpMatches on tests. · 73c76703

Edward Lemur authored Feb 06, 2020

Is not needed, and it's deprecated on Python 3.

Change-Id: I040891ff74708c6606b8c216da3a0bb98d44d977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2042281
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

73c76703

git-cl: Simplify FetchDescription and UpdateDescription · 6c6827cb

Edward Lemur authored Feb 06, 2020

- Merge GetDescription and FetchDescription, and remove unused `force` argument.
- Merge UpdateDescription and UpdateDescriptionRemote.

Bug: 1042324
Change-Id: Ia7a1b0aa1ea12a95bb6a19d9d3c9dd6aeb5bd2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2039968
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

6c6827cb

git-cl: Remove GetDescriptionFooters and UpdateDescriptionFooters · 6e9bfb06

Edward Lemur authored Feb 06, 2020

Unused after https://skia-review.googlesource.com/c/skia/+/265209

Bug: 1042324
Change-Id: I43a04d659e4d851e7b954cdd7dc0525490e3244c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2039969
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6e9bfb06

git-cl: Simplify Change object construction. · 7f6dec01

Edward Lemur authored Feb 06, 2020

The `author` parameter is never set.
The `local_description` parameter was only set with the
purpose of getting the local description, so separate it into its
own method and call that instead.
Use the absolute root when getting the list of modified files instead.

Bug: 1042324
Change-Id: I8505172edaacee0656dda98ebbd5f8ebfacb3cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038050
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7f6dec01

Roll recipe dependencies (trivial). · 816c2b35

recipe-roller authored Feb 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/9cc10f207c74c1a1d2b5a34436cb21a5dcc57d92 (tandrii@google.com)
Refactor tryserver.do_not_retry into cq.do_not_retry.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1ae546ad699e6eb7c318c156a10054dd5de6525e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2042120Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

816c2b35

git-cl: Remove _add_codereview_[issue_]select_options and _CODEREVIEW_IMPLEMENTATIONS. · 52969c9d

Edward Lemur authored Feb 06, 2020

Change-Id: I94922e1abab8acac132e16d255e1a9b95771ea5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040572Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

52969c9d

Reland "presubmit_support: Add --all-files options." · 50984a64

Edward Lemur authored Feb 06, 2020

This is a reland of 1c8026d2

Original change's description:
> presubmit_support: Add --all-files options.
> 
> Will be set when --all is passed to git-cl presubmit to execute
> presubmit checks over all files on a repo.
> 
> Bug: 1042324
> Change-Id: I2ebb7c3ec633f9d3a3774314799aa056bc2919c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2003071
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1042324
Change-Id: I452d98972f9b2c6d0a212029bac5aa6af57dce40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038055Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

50984a64

Revert "Enable Javascript formatting by default" · 417d89c3

Andreas Haas authored Feb 06, 2020

This reverts commit 42a51f6a.

Reason for revert: With this change also JavaScript code in the
V8 code base gets formatted. However, clang-format cannot deal with
V8 intrinsics, and therefore inserts a space between the `%` and the
intrinsics name. With that Clusterfuzz cannot detect intrinsics
anymore, and therefore the blacklisting of intrinsics would not
work anymore. The result is that Clusterfuzz then produces useless
test cases that are known to crash and could not exist in the wild.

Original change's description:
> Enable Javascript formatting by default
> 
> This removes the need for explicitly passing `--js` to `git cl format`
> to format both JavaScript and TypeScript. It would reduce a significant
> amount of mental overhead for formatting code in DevTools frontend,
> which is primarily JS/TS.
> 
> Fixed: 1007347
> Change-Id: Ia35c9af677d12ce9be72fe5fcdd6ceb6cb039c5f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029371
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I13e8ce8916f0685b667607f2c8e68b1185d43329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2041650Reviewed-by: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>

417d89c3

tryserver: delete failure_hash support. · e868546a

Andrii Shyshkalov authored Feb 06, 2020

It was used by CQ a while ago, but since 2019, it had little if any
effect, and has since been deleted from CQ entirely.

Companion CL
https://chromium-review.googlesource.com/c/chromium/tools/build/+/2040484

R=jbudorick

Change-Id: Ia570bce4886fa60a3bf16e88919f3a230d48fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040699Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

e868546a

OWNERS: add the Goma client release rotation to cipd_manifest.* · 4d200f44

Yoshisato Yanagisawa authored Feb 06, 2020

The Goma team releases the Goma client in depot_tools via CIPD.
Let me add all the Goma client release rotation so that they do not
need to wait for the review.

Bug: b/148421866
Change-Id: I45eb24ac8c34bba2183c16e72dcf0a9d7f13d603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040850
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

4d200f44

roll out new goma client binary (VERSION=189) · e36029b1

Yoshisato Yanagisawa authored Feb 06, 2020

https://chromium.googlesource.com/infra/goma/client/+/882f39c4e8b50acfab01334e03ae3bbd6254ae2b

BUG=b/148421866

Change-Id: I0c308c3d44d8d4e306564ef94cd88b7a3abd8a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2037185
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Ye Kuang <yekuang@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

e36029b1

Roll lucicfg tool to @ d8fd92af v1.12.0. · 6df2add3

Andrii Shyshkalov authored Feb 06, 2020

Old revision: 2251d40a

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/2251d40a..d8fd92af
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/2eea4652..80c570f9/lucicfg

Bug: 824492
Change-Id: I11d48ddcb0d55c0ed9408bfa25d3d6a5a0d16474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040109
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

6df2add3