- 29 Apr, 2016 20 commits
-
-
calamity@chromium.org authored
This CL fixes an issue where map branches would hang when trying to retrieve a deleted issue due to a long timeout. This has been fixed by reducing the timeout. This CL also fixes a small issue where {NO_UPSTREAM} would show the current branch's codereview URL. BUG=470765 Review-Url: https://codereview.chromium.org/1847693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300369 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
BUG=607359 Review-Url: https://codereview.chromium.org/1935653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300366 0039d316-1c4b-4281-b951-d872f2087c98
-
estaab@chromium.org authored
Depends on http://crrev.com/1787173003. BUG=594265 Review-Url: https://codereview.chromium.org/1792823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300365 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
Revert of git_cl: Add the ability to set the description. (patchset #3 id:40001 of https://codereview.chromium.org/1922133006/ ) Reason for revert: splitlines man Original issue's description: > git_cl: Add the ability to set the description. > > BUG=607359 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300357 TBR=iannucci@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607359 Review-Url: https://codereview.chromium.org/1935633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300360 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
BUG=607359 Review-Url: https://codereview.chromium.org/1922133006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300357 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=machenbach@chromium.org,phajdan.jr@chromium.org BUG=605563 Review-Url: https://codereview.chromium.org/1927773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300353 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Revert of Implement owners check in presubmit for Gerrit. (patchset #5 id:80001 of https://codereview.chromium.org/1927773002/ ) Reason for revert: now it doesn't work for gerrit. Damn it. Original issue's description: > Implement owners check in presubmit for Gerrit. > > R=machenbach@chromium.org,phajdan.jr@chromium.org > BUG=605563 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300350 TBR=machenbach@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605563 Review-Url: https://codereview.chromium.org/1935563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300352 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=machenbach@chromium.org,phajdan.jr@chromium.org BUG=605563 Review-Url: https://codereview.chromium.org/1927773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300350 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/1933233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300347 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=chromium:596887 Review-Url: https://codereview.chromium.org/1933683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300343 0039d316-1c4b-4281-b951-d872f2087c98
-
recipe-roller@chromium.org authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/e3081f3e9b9592caa464400604e8f134f07e932f recipe engine: remove infra-specific paths from the engine (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG=chromium:605919 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1935503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300341 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Reland of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1928373002/ ) Reason for revert: Was me - too fast to pull the revert trigger. The CL in question has notry set to true :( Original issue's description: > Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) > > Reason for revert: > Now only presubmit is scheduled on dry run, example CL: > https://codereview.chromium.org/1804003002 > > Original issue's description: > > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > > > R=machenbach@chromium.org,sergiyb@chromium.org > > BUG=601128,594127,591030 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 > > TBR=sergiyb@chromium.org,tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=601128,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300337 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1930363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300338 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Now only presubmit is scheduled on dry run, example CL: https://codereview.chromium.org/1804003002 Original issue's description: > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG=601128,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1928373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300337 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
This is a preparation for removal of infra-specific paths from the recipe engine. BUG=chromium:605919 Review-Url: https://codereview.chromium.org/1930373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Revert of Implement owners check in presubmit for Gerrit. (patchset #3 id:40001 of https://codereview.chromium.org/1927773002/ ) Reason for revert: Breaks presubmit: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175120/steps/presubmit/logs/stdio Original issue's description: > Implement owners check in presubmit for Gerrit. > > R=machenbach@chromium.org,phajdan.jr@chromium.org > BUG=605563 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300320 TBR=phajdan.jr@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605563 Review-Url: https://codereview.chromium.org/1928343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300326 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
This is different from previous attempt https://codereview.chromium.org/1915463002 . The change is completely backwards-compatible, and doesn't introduce recipe expectation changes. Modules can be switched to depend on infra_paths independently, without any expectation changes either. By moving path module's config.py to paths_config.py here, we also guarantee that the returned results are going to be exactly the same. Depends on https://codereview.chromium.org/1923363003 . BUG=chromium:605919 Review-Url: https://codereview.chromium.org/1926033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
-
recipe-roller@chromium.org authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/53217bee9af1ac4284df50b3e4e334b770eb0ddb recipe engine: add a hook for initializing recipe module with injected deps (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG=chromium:605919 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1933093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300322 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=machenbach@chromium.org,phajdan.jr@chromium.org BUG=605563 Review-Url: https://codereview.chromium.org/1927773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300320 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
This was broken in r299682 (adding setup_color). git_hyper_blame now initializes setup_color. BUG=607771 Review-Url: https://codereview.chromium.org/1930813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300316 0039d316-1c4b-4281-b951-d872f2087c98
-
bsep@chromium.org authored
BUG=600051 Review-Url: https://codereview.chromium.org/1917863009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300311 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Apr, 2016 12 commits
-
-
recipe-roller@chromium.org authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/1f0b237bd9e097a0b7f15e247ed6a7767f81148d Quiet clone, don't fetch overriden deps. (martiniss@chromium.org) R=martiniss@chromium.org BUG=586649 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1931933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300309 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
Revert of Add ability to override DEPS file in recursedeps. (patchset #1 id:1 of https://codereview.chromium.org/1919103003/ ) Reason for revert: Looks like this broke some bots; see https://build.chromium.org/p/chromium.infra.cron/builders/recipe-autoroller-public/builds/2960 https://build.chromium.org/p/chromium.infra.cron/builders/gsubtreed-luci-py/builds/52912 Original issue's description: > Add ability to override DEPS file in recursedeps. > > This will allow ANGLE to have a recursible deps-file in their repo instead of > relying on chromium's DEPS file to specify an accurate dependency for itself. > > R=agable@chromium.org, jmadill@chromium.org > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300293 TBR=agable@chromium.org,dpranke@chromium.org,jmadill@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1932063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300304 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
With a fix: actually set dry_run for presubmit, and don't set it for other builders. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1926663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
This will allow ANGLE to have a recursible deps-file in their repo instead of relying on chromium's DEPS file to specify an accurate dependency for itself. R=agable@chromium.org, jmadill@chromium.org BUG= Review-Url: https://codereview.chromium.org/1919103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300293 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
BUG= Review-Url: https://codereview.chromium.org/1929993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300287 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=607268 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/1924033004 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300283 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
See the bug for how these were built (comment 16 onwards). See the bug comment 0 also for what's new in this version. All binaries built by thakis@chromium.org. The Windows binary is now (as of 1.7.x) 64-bit instead of 32-bit. BUG=607268 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/1925133002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300281 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/ reverting first, then investigating. Original issue's description: > git cl try: don't skip presubmit builders, but set dry_run property. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG=601128,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 TBR=machenbach@chromium.org,sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1929483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300274 0039d316-1c4b-4281-b951-d872f2087c98
-
recipe-roller@chromium.org authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/571d980027fd27c602ec16bce9922327f30d5d87 recipe engine: convert path resolving logic to object-oriented style (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG=chromium:605919 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1922303005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300272 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
It's now passed using command line flags. This depends on https://codereview.chromium.org/1931633002, which actually uses this command line flag. R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG=601128 Review-Url: https://codereview.chromium.org/1929653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300268 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1926663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300265 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Also, implement skipping of CheckOwners presumbit canned check. To be used by run_presubmit recipe in build repo in https://codereview.chromium.org/1931633002 R=sergiyb@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org BUG=594127 Review-Url: https://codereview.chromium.org/1923623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300262 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Apr, 2016 4 commits
-
-
thakis@chromium.org authored
See the bug for how these were built. See the bug comment 0 also for what's new in this version. The linux binaries were built by thestig@chromium.org. The windows and mac binaries were built by thakis@chromium.org. The Windows binary is now 64-bit instead of 32-bit. BUG=607268 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1919773006 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300251 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
See https://codereview.chromium.org/8353039/ R=maruel@chromium.org BUG=605563 Review URL: https://codereview.chromium.org/1917883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300238 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Follow up on https://codereview.chromium.org/1901733003. R=martiniss@chromium.org BUG= Review URL: https://codereview.chromium.org/1924643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300236 0039d316-1c4b-4281-b951-d872f2087c98
-
recipe-roller@chromium.org authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG=chromium:605919 Review URL: https://codereview.chromium.org/1926633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2016 4 commits
-
-
martiniss@chromium.org authored
Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ ) Hopefully everything will be back to normal now... Original issue's description: > depot_tools: add infra_paths recipe module for infra-specific paths > > Depends on https://codereview.chromium.org/1906323003 > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Review URL: https://codereview.chromium.org/1915033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/1901733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300207 0039d316-1c4b-4281-b951-d872f2087c98
-
martiniss@chromium.org authored
TBR=phajdan.jr BUG=606708 Review URL: https://codereview.chromium.org/1921893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300206 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ ) Reason for revert: re-landing because wrong order of reverts :( Original issue's description: > Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ ) > > Reason for revert: > breaks skia bots :( > > Original issue's description: > > depot_tools: add infra_paths recipe module for infra-specific paths > > > > Depends on https://codereview.chromium.org/1906323003 > > > > BUG=chromium:605919 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184 > > TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199 TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Review URL: https://codereview.chromium.org/1921373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
-