Commit c68f7b51 authored by tandrii@chromium.org's avatar tandrii@chromium.org

Reland of git cl try: don't skip presubmit builders, but set dry_run property.

With a fix: actually set dry_run for presubmit, and don't set it for other builders.

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128,594127,591030

Review-Url: https://codereview.chromium.org/1926663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98
parent c38fd01b
......@@ -337,6 +337,8 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):
'rietveld': rietveld_url,
},
}
if 'presubmit' in builder.lower():
parameters['properties']['dry_run'] = 'true'
if tests:
parameters['properties']['testfilter'] = tests
if properties:
......@@ -4316,8 +4318,7 @@ def CMDtry(parser, args):
for master, builders in cq_masters.iteritems():
for builder in builders:
# Skip presubmit builders, because these will fail without LGTM.
if 'presubmit' not in builder.lower():
masters.setdefault(master, {})[builder] = ['defaulttests']
masters.setdefault(master, {})[builder] = ['defaulttests']
if masters:
return masters
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment