- 13 Jun, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I2b68e8e8a0e28b28b9aab79833578cdf59392b98 Reviewed-on: https://chromium-review.googlesource.com/531185Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Bruce Dawson authored
When no files are found where there should be on the VS packaging script throw an exception - using a non-existent variable. Resolving the missing files is a separate problem that I have filed a VS bug for: https://developercommunity.visualstudio.com/content/problem/67864/vs-2017-update-3-preview-2-is-missing-mfc-redist-f.html Bug: 683729 Change-Id: I1a3ba2a342ce7f8fa826300bb808e87c36969b52 Reviewed-on: https://chromium-review.googlesource.com/532114Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 12 Jun, 2017 5 commits
-
-
Bruce Dawson authored
Using goma requires the developer to remember which build directories use goma and which don't so that they can pass an appropriate -j number. Getting this wrong makes builds slower, either by under utilizing resources or by causing a self-inflicted DOS attack. Usage: autoninja -C out/debug autoninja looks at the settings for the specified build directory and then selects either -j num_cores*20 or no -j flag based on the use_goma setting. You can set the NINJA_CORE_MULTIPLIER variable to change from the default 20* multiplier. You can also use NINJA_CORE_ADDITION if you want non-goma builds to specify -j with an offset to the number of cores, such as this Linux command: NINJA_CORE_ADDITION=-2 autoninja -C out/release base This will tell autoninja to pass -j to ninja with num_cores-2 as the parameter. On Windows you can have a ninja.bat file (ahead of ninja on the path) such that autoninja will automatically be used. It should contain this: @call autoninja.bat %* Change-Id: I4003e3fc323d1cbab612999c945b5a8dc5bc6655 Reviewed-on: https://chromium-review.googlesource.com/517662Reviewed-by:Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/060325b14d5a63ce65e65d93052b265ee310a828 [path] Cleanup and use "C:\" for test Windows base (dnj@chromium.org) https://crrev.com/96221bce29d908b951812550036f42520f085dec [generator_script] Make allowed keys strict and improve error handling. (iannucci@chromium.org) https://crrev.com/cfff93afa16e61285e295d49f6aa2ba64642f330 [path] bring PLATFORM back to config. (iannucci@chromium.org) R=martiniss@chromium.org, phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I214f2a5a0f39b09d7c401da8f997545336335bbb Reviewed-on: https://chromium-review.googlesource.com/531974 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6d2596f2b4183b3abc59b92d0298e781e02d1687 [generator_script] constrain generator_script to have a stricter API. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If0c38cc948b5ed998ff40df5aeb26aefe1d7b69b Reviewed-on: https://chromium-review.googlesource.com/531526Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Paweł Hajdan, Jr authored
This will also be useful for other values (deps_os, hooks_os) we may want to store and keep constant. Freeze code copied from luci/recipes-py @ 944125e6d1e8c831d09517bde658a38d8f81db37 Bug: 570091 Change-Id: I3365cf2b267c478316870bbb3fd41e9955aa4ddf Reviewed-on: https://chromium-review.googlesource.com/531166 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c7595ad0dd704f72e4765e2645501c553bef3af1 [file] fix "rmtree" on non-dir path (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib07ee1b4327305d2fc59f199dcac22d7bb6c7034 Reviewed-on: https://chromium-review.googlesource.com/531224Reviewed-by:
-
- 10 Jun, 2017 2 commits
-
-
Robert Iannucci authored
R=dnj@chromium.org Bug: 662654 Change-Id: Ic5a59eeb67c435d54878ef5f060399f6b2963cd4 Reviewed-on: https://chromium-review.googlesource.com/523015 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
Robert Iannucci authored
R=dnj@chromium.org Bug: 720603 Change-Id: Iec447a7e32a4221009172f600ced7a9c19125266 Reviewed-on: https://chromium-review.googlesource.com/530099Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 09 Jun, 2017 5 commits
-
-
Aaron Gable authored
Bug: skia:6744 Change-Id: I0f84bd685bfacf692190f8636208122cf88d0b82 Reviewed-on: https://chromium-review.googlesource.com/529016Reviewed-by:
-
Andrii Shyshkalov authored
R=agable@chromium.org Bug: 728150 Change-Id: I3b2a843ac44bf447ce27a6d901d72a1c8035f496 Reviewed-on: https://chromium-review.googlesource.com/529112Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Aaron Gable authored
TBR=tandrii@chromium.org Bug: 723787 Change-Id: Ie5017747f2070116774cd12ba0dd2ea531b2d0aa Reviewed-on: https://chromium-review.googlesource.com/529547Reviewed-by:
-
Andrii Shyshkalov authored
Follow up on https://chromium-review.googlesource.com/c/527325/ R=agable@chromium.org,rmistry@chromium.org Bug: chromium:729967 Bug: skia:6744 Change-Id: I7443298797a7c95c8ca01624e3cbf08c95e04855 Reviewed-on: https://chromium-review.googlesource.com/529246Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Dan Jacques authored
"remote_run" builds explicitly supply a cleanup directory in recipe properties, so it isn't necessary to supply it here. BUG=chromium:725631 TEST=None TBR=iannucci@chromium.org Change-Id: I6eaaeea14bd699181d7ceeff6b3baac2d1cd9861 Reviewed-on: https://chromium-review.googlesource.com/528630Reviewed-by:
-
- 08 Jun, 2017 10 commits
-
-
Dan Jacques authored
Update the "vpython" CIPD version to pick up schema and runtime performance changes. BUG=None TEST=None R=iannucci@chromium.org Change-Id: If0e3c393abb16b8918b5fa16593a8788ef8947ec Reviewed-on: https://chromium-review.googlesource.com/527608Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Dan Jacques authored
Currently, "bot_update" relies on a BuildBot cleanup mechanism and, to a lesser extent, the standard BuildBot directory layout. Both of these are problematic when projecting it into other circumstances, notably "remote_run" and LUCI. Have "bot_update" handle its own cleanup. It will now choose a cleanup directory within the hierarchy of its checkout, and explicitly purge it prior to execution if it exists. This enforces its expected behavior in all circumstances and removes its expectations of the greater checkout layout. Export "cleanup_dir" via "infra_paths" to point to "build.dead" when running on BuildBot builds. Otherwise, it is a default directory which, on Kitchen, is ephemeral by design. BUG=chromium:725631 TEST=expectations Change-Id: I664434c542a25aaa7ff3eac216208a2425730fde Reviewed-on: https://chromium-review.googlesource.com/528057 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/154ef7e5d8f964ef30b1250dd33751582705f6f2 [path] Add concept of a "cleanup" directory. (dnj@chromium.org) R=dnj@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I31787615cfaa6f33deae6c1c0c3d7b748c222d05 Reviewed-on: https://chromium-review.googlesource.com/527503 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Robert Iannucci authored
R=dnj@chromium.org Bug: Change-Id: I69d2e75a7a6784a611f6e0128f1ba5617f009af2 Reviewed-on: https://chromium-review.googlesource.com/528320Reviewed-by:
-
Ryan Tseng authored
This picks up about 2 years worth of changes. Bug:723733 TEST=Ran gclient sync on src.git checkout, worked. Change-Id: I7021ac62be560bb3ba7b523f0758d56bceeef12a Reviewed-on: https://chromium-review.googlesource.com/527262Reviewed-by:
-
Aaron Gable authored
This CL changes the way that "git cl patch" behaves for Gerrit changes. Previously, git-cl-patch behaved just like it did for Rietveld: make sure you're on a branch, download the diff, apply it on top of your branch. However, this causes problems with Gerrit. Namely, when you upload a change to Gerrit, git-cl has to make sure that all parents of your local change have previously been uploaded as well, either as other changes or as commits already landed on the target branch. But the method for "applying a patch" from Gerrit was to cherry-pick it, and that changes the commit hash. So the resulting commit would *not* have been uploaded to Gerrit. Thus, the following routine didn't work with Gerrit: $ git checkout -t origin/master -b your-work $ git cl patch 123456 $ git checkout -tb my-work $ #hack and commit $ git cl upload This would fail during the upload with a message saying that the contents of 'your-work' hadn't been uploaded. This CL fixes the situation by replacing the cherry-pick with a hard reset. This means that the contents of the 'your-work' branch will be *exactly* what was downloaded from Gerrit. Uploads based on top of that commit will work just fine. Finally, in a concession to some people who want 'git cl patch' to actually apply a patch instead of performing a hard reset, if the current branch contains local work, then rather than leaving that work behind with a hard reset, we fall back to the old cherry-pick behavior with a confirmation dialog and warning that uploading will be hard. Bug: 723787 Change-Id: I3ad164f6d3078bff00139d446bb8ce97738a1344 Reviewed-on: https://chromium-review.googlesource.com/527345 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Aaron Gable authored
The logic for handling --title, --message, and the commit message of the most recent commit was accidentally doing this differently from how Rietveld had done them. Bug: 728391 Change-Id: I70a46ccb470d790103f5d6bb745902595be28eee Reviewed-on: https://chromium-review.googlesource.com/527339 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Aaron Gable authored
This prevents TBR (self code-review) permissions from blocking the CL from being uploaded at all. Instead, it will fully upload, and then show a better error message after upload is complete. Bug: 729967 Change-Id: I55e3e98e200143076afcaab858064d9f5c62f8ef Reviewed-on: https://chromium-review.googlesource.com/527325Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c916898b8189866a0bf43fe15c800e4fe6d4a19e [context] fix treatment of None in env. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I96a7fb05593c4e946faa581a67bcc5f2ecdcace4 Reviewed-on: https://chromium-review.googlesource.com/527913Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c40412cbc4e1b8ee1e6eba2e88328ca71c6ec1e4 [context] Add path prefix/suffix manipulation. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10613e30e3a58c208346243fb221cf9ed9d6b274 Reviewed-on: https://chromium-review.googlesource.com/527403Reviewed-by:
-
- 07 Jun, 2017 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/db920908bf51fcdb0e30f686a528b25cd4876ca7 Update vpython and spec to new text protobuf. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idc9ee786cc2f54eb69cbd5034fb5f58370d5663a Reviewed-on: https://chromium-review.googlesource.com/527497Reviewed-by:
-
Jeremy Roman authored
This causes review links to be shown using crrev.com/c/ or crrev.com/i/, which are the ones recommended at https://polygerrit.appspot.com/. This gerrit server is no longer used only by CrOS. Change-Id: Ie6b856390ec465f9d35a5035547f7b779392b24c Reviewed-on: https://chromium-review.googlesource.com/526612Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5c7cf00722c47a2063a8635822c0bb270a26b524 Reviewed-on: https://chromium-review.googlesource.com/527632 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Aaron Gable authored
TBR=iannucci@chromium.org Change-Id: I07668787e4f26bc4809ea3c3a5331a259655d2da Reviewed-on: https://chromium-review.googlesource.com/527295Reviewed-by:
-
- 06 Jun, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib2b966b5bc967de11a295b1636c1901faabea55f Reviewed-on: https://chromium-review.googlesource.com/525540 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Id95be31767d302c5eb9f7de96d31e32cc4dec1a4 Reviewed-on: https://chromium-review.googlesource.com/524492Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/267b9221c5fbd2712527852550d86f9e2e3874ff [file] Derive user-facing error from StepFailure and set FAILURE status on step. (iannucci@chromium.org) https://crrev.com/1ec7ad4df3efbdd7224f249179390aab4a66c562 [file] add log listings to file.listdir and file.glob_paths. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I45cd3ad3d3282e80d1b13b4873b77865c62bbcd1 Reviewed-on: https://chromium-review.googlesource.com/525853Reviewed-by:
-
- 05 Jun, 2017 3 commits
-
-
Aaron Gable authored
This brings the gerrit version of "git cl comments" into line with the Rietveld implementation by including file- and line-level comments as well as top-level review comments. It requires an extra API call to do so, so this may result in some slow-down, but the result is worth it. It formats the comments to match the formatting used in the PolyGerrit UI, with the addition of visible URLs linking to the comment since we can't hyperlink text in the terminal. This CL also causes it to ignore messages and comments with the 'autogenerated' tag, which are generally less interesting and clutter the output. Bug: 726514 Change-Id: I1fd939d90259b43886ddc209c0e727eab36cc9c9 Reviewed-on: https://chromium-review.googlesource.com/520722 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ddd199058ea23f965a1a6b276d76cf5c3723baaf [bundle] switch implimentation to use git 2.13 attr pathspec. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I14490bf186639eff4d6c0b0735b623e4343e5e1f Reviewed-on: https://chromium-review.googlesource.com/524007Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I72326ee6ddd907a97b5c497a8b2cc7fb744cf422 Reviewed-on: https://chromium-review.googlesource.com/523142Reviewed-by:
-
- 02 Jun, 2017 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a64a4d4ad8e4844cb81868a2b24df4d836d5caca [file] No error in remove if file does not exist (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie865339d6d6b8495a0ab737905f3236e006603b9 Reviewed-on: https://chromium-review.googlesource.com/523183Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
gclient-new-workdir.py should work on systems not supporting reflink now. Bug: 728903, 721585 Change-Id: I1385c4281bbf61d4ccae64c3595a39972fbe9d9e Reviewed-on: https://chromium-review.googlesource.com/522232 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Wiktor Garbacz authored
Using --no-squash resulted in an exception being thrown, because issue number is not set in that case. Change-Id: Iaf0d7eb05851eba0d5231640c077b845bca486ee Reviewed-on: https://chromium-review.googlesource.com/505509Reviewed-by:
-
Paweł Hajdan, Jr authored
This way we can get e.g. ordered dict as needed for conditions. Only the new logic does it, not the regular python exec logic. Bug: 570091 Change-Id: Ia5554e5b018085b3b9bd876b7f28a9f8e54a7984 Reviewed-on: https://chromium-review.googlesource.com/522564Reviewed-by:
-
Paweł Hajdan, Jr authored
It's still used in some places like CDM. This fixes the bug below. Bug: 728343 Change-Id: I0f9e2bbd0339838ee6d1d240c584858947cf36d2 Reviewed-on: https://chromium-review.googlesource.com/522682 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Emma Soederberg <emso@google.com>
-
Dan Jacques authored
Bump to: c6dbc470acfd836494db899bc6aebe0f3d2df593 BUG=None TEST=None R=iannucci@chromium.org Change-Id: I02a62665c9d7c95b4dc8dc93e45028cf9ff99aae Reviewed-on: https://chromium-review.googlesource.com/522422Reviewed-by:
-
