Commit 2c376aa2 authored by Andrii Shyshkalov's avatar Andrii Shyshkalov Committed by Commit Bot

git cl: Fix incorrect notify parameter when setting TBR.

Follow up on https://chromium-review.googlesource.com/c/527325/

R=agable@chromium.org,rmistry@chromium.org

Bug: chromium:729967
Bug: skia:6744
Change-Id: I7443298797a7c95c8ca01624e3cbf08c95e04855
Reviewed-on: https://chromium-review.googlesource.com/529246Reviewed-by: 's avatarRavi Mistry <rmistry@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
parent a07816dd
......@@ -3102,7 +3102,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
print('Adding self-LGTM (Code-Review +1) because of TBRs.')
gerrit_util.SetReview(
self._GetGerritHost(), self.GetIssue(),
labels={'Code-Review': 1}, notify=bool(options.send_mail))
labels={'Code-Review': 1},
notify='ALL' if options.send_mail else 'NONE')
return 0
......
......@@ -1581,7 +1581,8 @@ class TestGitCl(TestCase):
if tbr:
calls += [
(('SetReview', 'chromium-review.googlesource.com',
123456 if squash else None, {'Code-Review': 1}, notify), ''),
123456 if squash else None, {'Code-Review': 1},
'ALL' if notify else 'NONE'), ''),
]
calls += cls._git_post_upload_calls()
return calls
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment