Commits · cd1331ea69ccdfcecc6ab07eee8ffaf21824a7c6 · Linshizhi / Chromium_Depot_tools

07 Jan, 2020 4 commits

Move httplib2 import above third_party. · cd1331ea

Mark Orchard authored Jan 07, 2020

7fd6347b removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest.

move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix.

Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mark Orchard <morchard@google.com>

cd1331ea

Roll recipe dependencies (trivial). · 6ae3921d

recipe-roller authored Jan 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f46d187695175b7a4cd0a76ef58b364890499f2d Minor clean-up of docs (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0af5598af451814b5c2d700e114522bed577443b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989013Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6ae3921d

Roll recipe dependencies (trivial). · 2616b72b

recipe-roller authored Jan 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bf4885534ce2e5214c7ef1a015296d79bfab6b7b [resultdb] Log output (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iceccf6abb75db28c2155e48d540c0be5d0d6f31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989011Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2616b72b

Revert "depot_tools: Remove third_party/httplib2." · d0de3a7b

Dan Field authored Jan 07, 2020

This reverts commit 7fd6347b.

Reason for revert: This broke Flutter CI - we're not using vpython everywhere yet

Original change's description:
> depot_tools: Remove third_party/httplib2.
> 
> depot_tools' scripts have been using vpython httplib2 for a while.
> 
> Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

Change-Id: Ie53a8d07ccfba5a7cc5bcb431d4f7b897f66788a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989012Reviewed-by: Dan Field <dnfield@google.com>
Commit-Queue: Dan Field <dnfield@google.com>

d0de3a7b

06 Jan, 2020 7 commits

depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock · a8145025

Edward Lemur authored Jan 06, 2020

Change-Id: I3a188b34ae5f62649108afe08fe0e389a408c2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1947933
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

a8145025

Add flag to "git cl format" to avoid invoking clang-format. · ed0cc5f6

Garrett Beaty authored Jan 06, 2020

In repos that are checked out separately from chromium, invoking
"git cl format" on a change that has files that would be formatted using
clang-format causes an error because the depot_tools version of
clang-format looks for a clang-format inside the repo.

This prevents using proto-based properties (the preferred mechanism
going forward) in recipe repos that enforce formatting. The
--no-clang-format flag provides a workaround that can be used to
prevent trying to format any files where clang-format doesn't work.

Bug: 979330
Change-Id: Ice8561d88b29623deb953465253f92c88aa7fc2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986111
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

ed0cc5f6

Fix the --no-python flag for git cl format. · 91a6f338

Garrett Beaty authored Jan 06, 2020

The current behavior of the --no-python flag doesn't disable formatting
for python files. Instead, it has the same effect as the --python flag.

Change-Id: I26024d3030b9c873180b488d00351676c37c9492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1985785
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

91a6f338

presubmit_support: Add timeout to presubmit tests. · ecc27074

Edward Lemur authored Jan 06, 2020

Change-Id: I7a434d4420573c6e5fc014455b011984f4d681b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1952159Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ecc27074

depot_tools: Remove third_party/httplib2. · 7fd6347b

Edward Lemur authored Jan 06, 2020

depot_tools' scripts have been using vpython httplib2 for a while.

Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7fd6347b

Exclude ES imports from long lines check · f392703d

Dan Beam authored Jan 06, 2020

Bug: 1028829
Change-Id: Iafc40952e402884639543436281e93942c0257a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959813
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

f392703d

Roll recipe dependencies (trivial). · 989da695

recipe-roller authored Jan 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d459837f12b4d8d7e032c9b474d9a23f6935ff35 [swarming] Add bot_id property to TaskResult (athom@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3de181cfca521f0ff358362c0af4bd5980ab20b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988192Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

989da695

03 Jan, 2020 1 commit

Roll recipe dependencies (trivial). · cf50f774

recipe-roller authored Jan 03, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f44ad10ae5127aa3120f4d105db62e080b4af9ec [swarming] Expose swarming task duration (olivernewman@google.com)
  https://crrev.com/5591fe66be52b94aab70120f5401343521aaa4cc Enable use of 'cipd ensure -max-threads'. (mohrr@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie1cf92f7b93cc207ed253a31c8dfb326104d1d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987009Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

cf50f774

20 Dec, 2019 2 commits

Roll recipe dependencies (trivial). · 44134341

recipe-roller authored Dec 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d2fba763e27b1b169856f5eff7135584426967c4 Stop running a ton of tests on upload (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3578cecbe46d8c03a2208c8c20eb4742a2d21fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1979422Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

44134341

Roll recipe dependencies (trivial). · 8b876bd4

recipe-roller authored Dec 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ef92c00521e4df0b3c0f1d0d1ce5a6a36d58050e [swarming] Document how to use task fallback (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0ef8225675e4b7cfcc0b385bbb8e040960b53375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978783Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8b876bd4

19 Dec, 2019 2 commits

gclient: Make smoketests run on Windows. · 05934953

Edward Lesmes authored Dec 19, 2019

Bug: 1024683
Change-Id: I1c30473699c1bd6b198188b53b632e3617fed335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1929653Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

05934953

Roll recipe dependencies (trivial). · a892219c

recipe-roller authored Dec 19, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5ed573b5fc71c25e1821f2756d9637ca4eff066e [resultdb] Parse invocation (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I315213908cd6f00cfb9ac8d357963f5147aca143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1974804Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a892219c

17 Dec, 2019 4 commits

cpplint: use list() for working with python3 · 60378204

Sarthak Kukreti authored Dec 17, 2019

In python3, dict.keys() returns a view instead of a separate
dictionary, which results in the following error while trying
to use cpplint:

"RuntimeError: dictionary changed size during iteration"

Use a list of the keyset instead.

R=ehmaldonado@chromium.org

Bug: 1027160
Change-Id: I0040b8912d7e446d35d755bb021670c9f2248f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1966743Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Sarthak Kukreti <sarthakkukreti@chromium.org>

60378204

[cipd] Update client v2.3.4 => v2.3.5. · a33af223

Vadim Shtayura authored Dec 17, 2019

Includes bug fix for handling cache corruption.

R=tandrii@chromium.org
BUG=1034124

Change-Id: I06e2be15d97522c0a78a97c6ebd202824f8f8c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1972372
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

a33af223

depot_tools: Delete roll-dep-svn · 5e2debe5

Edward Lemur authored Dec 17, 2019

Bug: 642523
Change-Id: I0e52b6a4d7b45af31aa293f69895c3775044a730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1971120Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5e2debe5

Escape forward slash to avoid undesired path conversion in Git 2.24.1(2). · 115b7179

Peter Kasting authored Dec 17, 2019

Bug: none
Change-Id: I8fe6e68ab93025b461722fc6ce43274c091902e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1963407
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

115b7179

13 Dec, 2019 2 commits

[cipd] Update client v2.3.2 => v2.3.4. · ba4699fe

Vadim Shtayura authored Dec 13, 2019

Notable changes:
  - Bug fix for an edge case of "symlink => dir" replacement.
  - Ask to login on permission errors.

R=tandrii@chromium.org
BUG=1031057, 1033987

Change-Id: I60175e79d37cf5425c9b777159bd10d47353f003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1967964
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

ba4699fe

Roll recipe dependencies (trivial). · f1ad6e46

recipe-roller authored Dec 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ee9e27dca1ca19f086e572a4266ef7d35f5462a8 Whitelist RECIPE_MODULES imports. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifeae30970270145c8ccfd2f6430fdac248e76683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1966416Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f1ad6e46

12 Dec, 2019 1 commit

Roll lucicfg tool to @ 5fca57db v1.11.14 · 785eba07

Andrii Shyshkalov authored Dec 12, 2019

Old revision: 0416cda1

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/0416cda1..5fca57db
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/ecd08a2a..8a10a4b7/lucicfg

Bug: 944108
Change-Id: If28291d5270e4ade84c19dd4a1dc697152fac446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1963484Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

785eba07

11 Dec, 2019 2 commits

[goma_ctl] Use vpython to call goma_ctl.py. · 8b34eb4d

Robert Iannucci authored Dec 11, 2019

goma_ctl.py recommends that folks run `pip install pywin32`, which will
work up until python in depot_tools is updated, at which point it will
break again.

Running with vpython means that the vpython spec which ships with goma
will correctly take effect.

R=brucedawson@chromium.org, tikuta@chromium.org

Bug: 1033106
Change-Id: Icafadf381df782ab30d6cc156419dd7ed424d2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

8b34eb4d

Remove myself from owners · 812a1469

Sergiy Belozorov authored Dec 11, 2019

R=iannucci@chromium.org, nodir@chromium.org

Change-Id: I5eb3b3732610139e04da07129f89b646e0cf60b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962930
Auto-Submit: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

812a1469

10 Dec, 2019 6 commits

Roll python to actually correct packages. · ee67b97d

Robert Iannucci authored Dec 10, 2019

For bonus points, this also fixes PRESUBMIT so that it actually checks
the manifests.

TBR=bpastene@chromium.org, tandrii@chromium.org

Bug: 1032743
Change-Id: I4dac5a520e333e3c429597684a44ece83d21c5fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1960950Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

ee67b97d

Update git-drover to use branch CQ · 6865d132

Aaron Gable authored Dec 10, 2019

Now that the CQ has been enabled for both the Beta and Stable
branches, git-drover should use the commit queue instead of
directly submitting the CL. To that end, this CL replaces the
usage of `git cl land` with `git cl set-commit`.

Change-Id: I0d0c10115acc98eafe0c069825de5499b8ade3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1960697
Auto-Submit: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

6865d132

Roll recipe dependencies (trivial). · 446df390

recipe-roller authored Dec 10, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8605aab007613ffcd29297c0462ed8f4c7f7369c [recipe_modules/platform] Update doc for arch property. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id5ed8e8adf4bf1e096fadbbc6c559b00f98cd3fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959696Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

446df390

Roll python 2 and 3 to versions matching the fleet. · 92b150fa

Robert Iannucci authored Dec 10, 2019

R=ajp@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Change-Id: I8fe37755858f0b7205aa790dc4620e1ce0e84850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1960695
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

92b150fa

Roll git to 2.24.1. · 7f9e1a2d

Robert Iannucci authored Dec 10, 2019

R=jrn@google.com, tandrii@chromium.org, vadimsh@chromium.org

Bug: 1032658
Change-Id: I60885ef7d959fbe9146bcbb5f62ab4be729caee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1960690
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

7f9e1a2d

bot_update: only add input commit refs for gclient solution roots. · e9aeaee5

John Budorick authored Dec 10, 2019

Bug: 1031805
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Change-Id: I6edd221900eadd4d621d6190e08b61fdbc2f8621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1958706
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

e9aeaee5

09 Dec, 2019 4 commits

Roll recipe dependencies (trivial). · cfd87e82

recipe-roller authored Dec 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/19c96b27a29dbad65e5e01d28ff479e856d666bd [resultdb] Add chromium_derive function. (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8b0effcd02b79fa8448539291758f873a2f8d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1958857Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

cfd87e82

pylint: make pylint-quotes available · 198b5629

Mike Frysinger authored Dec 09, 2019

We load it, but disable all the warnings by default. People can
re-enable the warnings for their modules if they want, but there
is way too much broken code in the tree currently.

Bug: 738534
Test: ran each pylint version by hand on some bad code
Change-Id: Ia5b24093f18febd452f4c1eed6e82044544161bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1958849Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

198b5629

[cipd] Bump client version 2.3.1 => 2.3.2. · bf31df7a

Vadim Shtayura authored Dec 09, 2019

Has slightly friendlier error message on permission errors. No other changes.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=1031057

Change-Id: Ie6dd75285bf6125bc76a1d338f956a303b42f825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959085
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

bf31df7a

pylint: roll less spammy versions · ed71210a

Mike Frysinger authored Dec 09, 2019

Pull the patched versions that reduce log spam.

Bug: 866772
Test: `pylint-1.9 __init__.py` doesn't spam
Change-Id: I766e534e08199f1cc54d93a40e8a2dccb77f2934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1958848Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

ed71210a

06 Dec, 2019 1 commit

Default to origin's default branch instead of always origin/master. · 6b52dc21

Jeffrey Yasskin authored Dec 06, 2019

BUG=1023031

Change-Id: I4bf3e33932af40600646f070f057a7c8c0661f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1954624
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Jeffrey Yasskin <jyasskin@chromium.org>

6b52dc21

05 Dec, 2019 2 commits

[git] Update bootstrapped git version to 2.24 to match fleet. · fe18a43d

Robert Iannucci authored Dec 05, 2019

R=ehmaldonado@chromium.org, tandrii@chromium.org, thakis@chromium.org

Bug: 1026340
Change-Id: I16b3e5452114cf8b33368c5721e7b53a5700c941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1954210
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

fe18a43d

Roll recipe dependencies (trivial). · 850516a9

recipe-roller authored Dec 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1f2a908debbd1f17a22d1a92f811871e348c7cd6 Update Tricium proto in recipes to contain showOnUnchangedLines field (ltina@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3186175e0ca62a86e65e1be4982f6a103d089e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1954204Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

850516a9

04 Dec, 2019 2 commits

[recipes] replace the variable ${platform} with resolved-platform in test output · 9212599f

Yiwei Zhang authored Dec 04, 2019

The intention is to create parity with cipd module[1] in recipe engine so that
there will be less friction when downstream repo starts to consume cipd module in
recipe engine

[1]: https://chromium.googlesource.com/infra/luci/recipes-py/+/refs/heads/master/recipe_modules/cipd/test_api.py#23

R=iannucci

Bug: 875523
Change-Id: I5f9100a81e7ca3c7300ab3b0ba198120d598ca48
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1951224
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

9212599f

Revert "[bot_update] Also bootstrap in the case that there are 0 pack files" · cc11b065

Edward Lesmes authored Dec 04, 2019

This reverts commit 32a801b5.

Reason for revert:
It's causing depot tools presubmit to time out
(Also, introduces a Python 3 error for git_cache).

Original change's description:
> [bot_update] Also bootstrap in the case that there are 0 pack files
> 
> This can happen if the cache repo was init'd, but has no pack files;
> previously it would try to fetch from scratch.
> 
> R=ehmaldonado@chromium.org, tandrii@chromium.org
> 
> No-Presubmit: true
> Change-Id: I97e863dd6c2ecfd00fdb4238dda48e0d3929c4f2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1941337
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=iannucci@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

Change-Id: I93366bcc6ff1df579a67d51c2cda812c84a06215
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1951985Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

cc11b065