- 13 Feb, 2020 7 commits
-
-
Edward Lesmes authored
This reverts commit 9ee86e5a. Reason for revert: Typo. Original change's description: > gerrit-util: Fix GCE check from behind proxy. > > Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl > to fail. > > The behavior of an unreachable server behind proxy is different from a direct > connection, it won't throw a httplib2.ServerNotFoundError error, > so catch httplib2.Httplib2Error instead. > > Bug: 1050380 > Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idb17520e71fc1d892694e0d4d1cf1630a42bb482 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055390Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl to fail. The behavior of an unreachable server behind proxy is different from a direct connection, it won't throw a httplib2.ServerNotFoundError error, so catch httplib2.Httplib2Error instead. Bug: 1050380 Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Simon Que authored
Bug: None Change-Id: Ib8f349044e3ea1a6ac7dd0c5428f5c561e36ac5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053627Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Simon Que <sque@chromium.org>
-
Simon Que authored
https://chromium.googlesource.com/infra/goma/client/+/bf6b833ba9f59247d9b6542d9c9852c1bed22e04 BUG=b/148913740 Change-Id: I0d107d4c22daa86f0f3e0587530b7f651bca08ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053623Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Simon Que <sque@chromium.org>
-
Edward Lemur authored
scm: - Add methods to deal with git configs and tests for them. Will make it easier to mock git config calls as opposed to all git calls. - Add tests to FetchUpstreamTuple git-cl: - Mock out settings.GetChangeRoot() - Use scm.GIT.FetchUpstreamTuple() to reduce code duplication, and mock it out on tests. Bug: 1051631 Change-Id: I1a3220b4c0f3e6221b3c00550259a433c2775798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052552 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
Bug: 1051631 Change-Id: I0c8222f89477300e6a14296b72ecaa01d65ca32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052627Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Mike Frysinger authored
This pulls the latest version from upstream. Largely should be bugfixes, but there's a few new hot features too! Bug: https://crbug.com/gerrit/10418 Test: `repo sync` still works Change-Id: Icd901b490857083f047ce900990769efdf5f269b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052975Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 12 Feb, 2020 3 commits
-
-
John Budorick authored
This reverts commit 35b70cac. Reason for revert: causing problems for the chromium cq, e.g. https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/471366 https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/197740 Original change's description: > cros: switch CrOS programs to python3 > > We start warning if people have outdated systems. > > Bug: 997354 > Test: `cros --help` uses python3 now > Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243 > Commit-Queue: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=vapier@chromium.org,iannucci@chromium.org,saklein@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ie85691d9f847ad7edb4c9932a0788431c886fec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052543Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Mike Frysinger authored
We start warning if people have outdated systems. Bug: 997354 Test: `cros --help` uses python3 now Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/ee858e5e410b4d30b666b29ebd759866300a5504 (tikuta@chromium.org) swarming: update swarming binary More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I97f4569e4089b0a5c0fa6c5e3e62689916a12d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2051730Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 11 Feb, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/9d6a5450a86f921c7890b72414e99e7d9828d9a5 (tandrii@chromium.org) cq: update doc. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I83c3c1f7a03bd578d198c956dd87a297d79b5aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050541Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/202779b4946ce3ff354fd4a1e9171cf132ca85c0 (maruel@google.com) [swarming] Roll executable, make invocation failure an infra failure https://crrev.com/0da3025f2afe23f98970f64f56c1869f137d4b4e (maruel@chromium.org) Revert "[swarming] Roll executable, make invocation failure an infra failure" More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icab6411926169eb1ace0858b7bfaf34ca43467b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2048994Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 10 Feb, 2020 1 commit
-
-
Mike Frysinger authored
This pulls the latest version from upstream. This drops the custom keys Chromium has been carrying. We switched our release signing over to the official key, so there's no need for ours anymore. The new version will attempt to use Python 3 if available and whine if it's not. It shouldn't cause errors, just new warnings, but it should help us track down old systems. Bug: https://crbug.com/gerrit/10418 Test: `repo sync` still works Change-Id: I915d0874a1642880831964f91c4632f9d17a1e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2044341Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 07 Feb, 2020 2 commits
-
-
Edward Lemur authored
GetChange now takes a single argument. Bug: 1042324, 1050198 Change-Id: Ib8521d7134e9c7b251d590dac6759a6cc585d3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2044971Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
Use cq.set_do_not_retry instead. See https://crrev.com/c/2040838 R=yiwzhang Change-Id: I110c398e794c19df30c42aa77e88a5da5d33276d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040709 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by:
Yiwei Zhang <yiwzhang@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
- 06 Feb, 2020 13 commits
-
-
Edward Lemur authored
Is not needed, and it's deprecated on Python 3. Change-Id: I040891ff74708c6606b8c216da3a0bb98d44d977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2042281 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
- Merge GetDescription and FetchDescription, and remove unused `force` argument. - Merge UpdateDescription and UpdateDescriptionRemote. Bug: 1042324 Change-Id: Ia7a1b0aa1ea12a95bb6a19d9d3c9dd6aeb5bd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2039968 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
Unused after https://skia-review.googlesource.com/c/skia/+/265209 Bug: 1042324 Change-Id: I43a04d659e4d851e7b954cdd7dc0525490e3244c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2039969 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
The `author` parameter is never set. The `local_description` parameter was only set with the purpose of getting the local description, so separate it into its own method and call that instead. Use the absolute root when getting the list of modified files instead. Bug: 1042324 Change-Id: I8505172edaacee0656dda98ebbd5f8ebfacb3cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038050 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/9cc10f207c74c1a1d2b5a34436cb21a5dcc57d92 (tandrii@google.com) Refactor tryserver.do_not_retry into cq.do_not_retry. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1ae546ad699e6eb7c318c156a10054dd5de6525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2042120Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lemur authored
Change-Id: I94922e1abab8acac132e16d255e1a9b95771ea5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040572Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
This is a reland of 1c8026d2 Original change's description: > presubmit_support: Add --all-files options. > > Will be set when --all is passed to git-cl presubmit to execute > presubmit checks over all files on a repo. > > Bug: 1042324 > Change-Id: I2ebb7c3ec633f9d3a3774314799aa056bc2919c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2003071 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1042324 Change-Id: I452d98972f9b2c6d0a212029bac5aa6af57dce40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038055Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andreas Haas authored
This reverts commit 42a51f6a. Reason for revert: With this change also JavaScript code in the V8 code base gets formatted. However, clang-format cannot deal with V8 intrinsics, and therefore inserts a space between the `%` and the intrinsics name. With that Clusterfuzz cannot detect intrinsics anymore, and therefore the blacklisting of intrinsics would not work anymore. The result is that Clusterfuzz then produces useless test cases that are known to crash and could not exist in the wild. Original change's description: > Enable Javascript formatting by default > > This removes the need for explicitly passing `--js` to `git cl format` > to format both JavaScript and TypeScript. It would reduce a significant > amount of mental overhead for formatting code in DevTools frontend, > which is primarily JS/TS. > > Fixed: 1007347 > Change-Id: Ia35c9af677d12ce9be72fe5fcdd6ceb6cb039c5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029371 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> TBR=tvanderlippe@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I13e8ce8916f0685b667607f2c8e68b1185d43329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2041650Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org>
-
Andrii Shyshkalov authored
It was used by CQ a while ago, but since 2019, it had little if any effect, and has since been deleted from CQ entirely. Companion CL https://chromium-review.googlesource.com/c/chromium/tools/build/+/2040484 R=jbudorick Change-Id: Ia570bce4886fa60a3bf16e88919f3a230d48fbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040699Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
Yoshisato Yanagisawa authored
The Goma team releases the Goma client in depot_tools via CIPD. Let me add all the Goma client release rotation so that they do not need to wait for the review. Bug: b/148421866 Change-Id: I45eb24ac8c34bba2183c16e72dcf0a9d7f13d603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040850 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
Yoshisato Yanagisawa authored
https://chromium.googlesource.com/infra/goma/client/+/882f39c4e8b50acfab01334e03ae3bbd6254ae2b BUG=b/148421866 Change-Id: I0c308c3d44d8d4e306564ef94cd88b7a3abd8a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2037185 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Ye Kuang <yekuang@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
Andrii Shyshkalov authored
Old revision: 2251d40a Change logs: infra/infra: https://chromium.googlesource.com/infra/infra/+log/2251d40a..d8fd92af luci-go https://chromium.googlesource.com/infra/luci/luci-go/+log/2eea4652..80c570f9/lucicfg Bug: 824492 Change-Id: I11d48ddcb0d55c0ed9408bfa25d3d6a5a0d16474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040109 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/6dd9a28312365e28c7e851516829968cce68df1e (tandrii@google.com) cq: expose properties to group similar attempts together. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iafc598833743c737734e3af3bf461a66bd19374a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040105Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 05 Feb, 2020 1 commit
-
-
Edward Lesmes authored
This reverts commit 1c8026d2. Reason for revert: Description should be set from gerrit before parsing the changes. Original change's description: > presubmit_support: Add --all-files options. > > Will be set when --all is passed to git-cl presubmit to execute > presubmit checks over all files on a repo. > > Bug: 1042324 > Change-Id: I2ebb7c3ec633f9d3a3774314799aa056bc2919c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2003071 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I8c455a269cdd6eb3dea9379faf351a04644bd23f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042324, 1048885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038052Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 04 Feb, 2020 4 commits
-
-
Edward Lemur authored
Pass a gerrit object instead of a git-cl ChangeList object to PostUploadHook to remove dependency of presubmit_support in git-cl. Requires https://skia-review.googlesource.com/c/skia/+/265209 Bug: 1042324 Change-Id: I4b20b75deb6a3d8d4caf46ca3580883699dbf707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2008287 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Will be set when --all is passed to git-cl presubmit to execute presubmit checks over all files on a repo. Bug: 1042324 Change-Id: I2ebb7c3ec633f9d3a3774314799aa056bc2919c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2003071Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/f72daca5c12eb4d83d74c25465520380c169c6b2 (maruel@google.com) [swarming] Always trim output when raising an exception More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id6c7d59126fda025b50654148c7c8781674358fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2037870Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Yuly Novikov authored
Needed to find *.winmd files for UWP build. This CL and crrev.com/c/2007881 were used to generate the recent toolchains with UWP support: b92fff97f2e0323e99803f37f4b77b843bdbf69d in crrev.com/c/2015984 and 9ff60e43ba91947baca460d0ca3b1b980c3a2c23 in crrev.com/c/2025528. Bug: chromium:1032635 Change-Id: I1ab0b6e11a30600deb377078815c268d8f9027e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2013579 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org>
-
- 03 Feb, 2020 4 commits
-
-
Edward Lemur authored
Mock time_time so that time.time is not called from ThreadPoolTest tests, so that the execution time doesn't change between executions. Bug: 1047631 Change-Id: I4f4ac30ca6a2ee3be25830c0e17a9f29a9c0c999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2036477Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Needed by Skia's PostUploadHooks, so that presubmit_support doesn't depend on git-cl classes. Bug: 1042324 Change-Id: I02475e346437b26fa8d0d2021ea62754077a2b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007262Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Needed by Skia's PostUploadHooks, so that presubmit_support doesn't depend on git-cl internal classes. Bug: 1042324 Change-Id: If8f4e6ea035197667cd9705a4274590c4d11511e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007670Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Yuly Novikov authored
It is needed for UWP build and is the same on at least 2 machines in C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0\Windows.winmd Bug: chromium:1032635 Change-Id: I9d7148a8dc11ea85f1b930f63ae19eaa58ac2bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007881Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
- 31 Jan, 2020 3 commits
-
-
Josip authored
Change-Id: I0a4d16fef3aed6bba0c6015fe861a2f11558e11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029114 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Tim van der Lippe authored
This removes the need for explicitly passing `--js` to `git cl format` to format both JavaScript and TypeScript. It would reduce a significant amount of mental overhead for formatting code in DevTools frontend, which is primarily JS/TS. Fixed: 1007347 Change-Id: Ia35c9af677d12ce9be72fe5fcdd6ceb6cb039c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2029371Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
-
Aaron Gable authored
Bug: 773529 Change-Id: If00fae56890e7826f9a08ccafe7d45fff2d31ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2015615 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Aaron Gable <agable@chromium.org>
-