Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 14 Jul, 2022 1 commit
    • Brian Ryner's avatar
      New vpython to depot_tools. · c8fadda5
      Brian Ryner authored 
      This release contains commits:
e74f8f68337ee619d400e0b6607cbe9df37f78ee Fix so that Python inherits file handles again on Windows.
059bcab0fb866cf8b9bc25b5845beeb8ee90fe3d Bundle the python interpreter on Mac.
e2552b1a6ebed6651aceb5a7ab4639c0d69c0c0e Resolve symlinks when finding the vpython executable.
d5fc7bca58e458258f8c3b8a25ecd070c77581ac Roll infra/go/src/go.chromium.org/luci/ ee2c632ce..82d549a81 (1 commit)
5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48 Roll infra/go/src/go.chromium.org/luci/ 0480658b5..0535bf685 (5 commits)
3076679301d2b9b040bce2c871a63ddc49273c41 [environ] Rename Get => Lookup, GetEmpty => Get.
37f02f9f91aa3918b195931fbcf02750290d0571 Search bundled python paths before looking in PATH.
a4136aa4d9e8c359bcf234fcd6ae026fb5b92925 [go] Format all files.
8349853d4517895a2c5838a00aea3e368ce3f865 [vpython] Make TestLoadForScript pass on OSX when running locally.
d94b5704d8ad151a0306974a1a949d8057c44a18 Revert "Add support for bootstrapping the Python interpreter package."
6dacee57fbe6b5bc5a2fca23b5b7d8ccfea54ee7 Revert "Pass packages to vpython to bootstrap."
03e0afedc841bad5fed8024c4b7fd38d332701ad Pass packages to vpython to bootstrap.
fa3d6effe8906e93944bf54ea6978adcd022f75c go generate all
b5eee61d0153295f3efb2e67b319066c2306ac5b Add support for bootstrapping the Python interpreter package.
cc5fb5e4934445a0a5206bfc324ca486c1285415 [vpython] Skip flaky test.
c04b64ca743703ebbfc064ec5b5c35d3bc378fa4 Add vpython3-only cipd packages.
f14d61370f1d7302a797feb2adc3a2f2449130d1 Remove the VENVOmitUseWheel field now that nothing uses it.
7c739ae11aa23bc37601e6923add677600ae1329 Remove support for old pip versions in pep425 tag probing.
51e3f0a01454d2e18b36de28c7e0ca2f6127ea2b Stop setting the unused VENVOmitUseWheel option.
e0e35a4e2227fb3429f3483c4719b6370eca7e1e Hardcode the venv OmitUseWheel option to true.

Bug: 1318617, 1340653
Change-Id: Ifb94c81492edfa98e1b59fc82e6d43678b82d776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3756933Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
      c8fadda5
  3. 13 Jul, 2022 4 commits
  5. 11 Jul, 2022 1 commit
  7. 08 Jul, 2022 1 commit
  9. 07 Jul, 2022 1 commit
  11. 01 Jul, 2022 7 commits
  13. 30 Jun, 2022 3 commits
  15. 29 Jun, 2022 4 commits
  17. 28 Jun, 2022 2 commits
  19. 27 Jun, 2022 3 commits
  21. 24 Jun, 2022 2 commits
  23. 23 Jun, 2022 3 commits
  25. 22 Jun, 2022 3 commits
  27. 21 Jun, 2022 1 commit
  29. 17 Jun, 2022 2 commits
    • dan sinclair's avatar
      Add some c++17 headers to the list of known headers. · 9a3c4bc6
      dan sinclair authored 
      This CL updates cpplint.py to add some of the c++17 header files to the
list of known c++ headers. We're specifically using optional and variant
in the Tint project and would like to remove the NOLINT lines necessary
to keep the linter happy.

Bug: dawn:1379
Change-Id: I41cacd21e0742f992cdd6913b7f4def556b543c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3709241
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
      9a3c4bc6
    • Bruce Dawson's avatar
      Mitigate Python 3 multiprocessing bug on Windows · 8254f06b
      Bruce Dawson authored 
      The multiprocessing module on Windows has a bug where if you ask for
more than 60 child processes then it will hang. This is related to the
MAXIMUM_WAIT_OBJECTS (64) limit of WaitForMultipleObjects. Other sources
have listed the multiprocessing limit as being 61, or have said that the
the maximum number of objects that can be waited on is actually 63, but
those details don't really matter.

The original fix for this class of issues was crrev.com/c/2785844. This
change extends those fixes to depot_tools, which was missed last year.
This change also updates how PyLint is called by further limiting the
number of jobs to the number of files being processed divided by 10.
This is because there is a significant cost to creating PyLint
subprocesses - each takes about 0.5 s on my test machine. So there needs
to be enough parallelism to justify this.

Patches for PyLint and a bug for cpython are planned.

This will stop PyLint from hanging during presubmits on many-core
machines. The command used to reproduce the hangs and validate the fix
was:

  git cl presubmit -v --force --files "chrome/test/mini_installer/*.py"

Prior to this change this command would use (on my many-core test
machine) 96 processes and would hang. How it uses just two processes
because there are only 16 files to analyze.

Output before:
  Pylint (16 files using ['--disable=cyclic-import'] on 96 cores)
Output after:
  Pylint (16 files using ['--disable=cyclic-import'] on 2 processes)

This is actually not quite true because the hang would prevent the
old message from being displayed.

Bug: 1190269, 1336854
Change-Id: Ie82baf91df4364a92eb664a00cf9daf167e0a548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3711282Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      8254f06b
  31. 16 Jun, 2022 2 commits