- 15 Jun, 2022 3 commits
-
-
Junji Watanabe authored
There are still some places that directly calls depot_tools/ninja{,.exe} without ensuring .cipd_bin dir. This is a binary build on 3pp CIPD pipeline specified in cipd_manifest.txt. Bug: 931218 Change-Id: I9f455bf47d648ce8e5bf74bd6c6d356867766314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3708571 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Junji Watanabe authored
Some users call ninja/autoninja inside a depot_tools.on_path() context. e.g. https://source.chromium.org/chromium/chromium/tools/build/+/main:recipes/recipes/chromium_upload_clang.py;l=92;drc=5bf3de010da6bd44d776f98c136e3b41f82cdfe8 Tested on a led build. https://ci.chromium.org/swarming/task/5b802dcdfe0a2810 Bug: 931218 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: If3ece36c1d6590d30bc071deba6387d39b7c33a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3704921Reviewed-by:
Alexander Thomas <athom@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Junji Watanabe authored
This reverts commit 0a5bae7e + some modifications on recipe module. The previous CL https://crrev.com/c/3697958 ensures depot_tools/.cipd_bin in recipe environments. This CL copies ninja.exe from .cipd_bin to depot_tools root as cipd_bin_setup.bat. For developers, it's expected to run update_depot_tools which triggers cipd_bin_setup. For CI/CQ, depot_tools._cipd_bin_setup() should be called before using ninja/autoninja recipe module APIs. Builds with depot_tools recipe bundle are tested using led. # Windows > led get-build 8811491780369249585 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch https://ci.chromium.org/swarming/task/5b7512ee9d91fc10? # Linux > led get-build 8811504372914233697 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch https://ci.chromium.org/swarming/task/5b7515832d0f7c10 Original change's description: > Revert "Switch to use CIPD ninja v1.8.2" > > This reverts commit c90a9821. > > Reason for revert: > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8811949917908303825/+/u/compile/stdout > > Original change's description: > > Switch to use CIPD ninja v1.8.2 > > > > https://crrev.com/c/3674981 installed CIPD ninja packages. > > This CL switches from the old ninja binaries to them. > > > > Note that this CL doesn't change ninja version. the old/CIPD ninja binaries are v1.8.2. > > > > The differences from the old binaries are > > - the CIPD packages don't use chromium's clang. > > - the CIPD package for Linux doesn't use chromium's sysroot. > > - the min macOS version is 10.13, which was 10.6. > > Please also see https://crsrc.org/i/3pp/ninja/install_bootstrap.sh > > > > > > On Windows, ninja.exe will be installed under .cipd_bin. > > But there are many places that assume that ninja.exe exists on depot_tools root. So this CL also copies the ninja.exe from .cipd_bin to root in cipd_bin_setup.bat. > > > > Bug: 931218 > > Change-Id: Ib67eee5e9b6ad9b2937b789626970d9c85867dbd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674982 > > Commit-Queue: Junji Watanabe <jwata@google.com> > > Reviewed-by: Philipp Wollermann <philwo@google.com> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Bug: 931218 > Change-Id: I08d61dad119a0d23ae9ec8b1ed787dd3915de697 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686854 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Owners-Override: Takuto Ikuta <tikuta@chromium.org> Bug: 931218 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: infra Change-Id: Ic7a9395c0e858823375f1a6ec79034dbc54230bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696963Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org>
-
- 14 Jun, 2022 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8811411832944140097 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/57e0012cfe9b6fdc0af51b0ebcb269323bc3b071 57e0012 (olivernewman@google.com) [cas] Add log_level arg to archive() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: If9036779b5db21f13d0245f85456061afc96e4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3704761 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Junji Watanabe authored
Tested in led builds on chromium/tools/build repo. # Linux ``` > led get-build 8811504372914233697 | led edit-recipe-bundle -O depot_tools="$HOME/depot_tools" | led launch ... https://ci.chromium.org/swarming/task/5b749884a3f3fa11 ``` # Windows ``` > led get-build 8811491780369249585 | led edit-recipe-bundle -O https://ci.chromium.org/swarming/task/5b74bc67963d7610 ``` Bug: 931218 Change-Id: I4a967f7544f71a9fef8a44baad45196365659596 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: infra Change-Id: I4a967f7544f71a9fef8a44baad45196365659596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3697958 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 13 Jun, 2022 2 commits
-
-
Aravind Vasudevan authored
The meta quest browser has an issue with the initial design where the all the dependencies within the same tree are overridden with the solution URL's scheme. This fix updates fetch to add a .gclient entry instead of implicitly overriding the URL's scheme. Bug: 1336027 Change-Id: Iabe5b9017f6eb9e682a0c721f43dd5f347ffcbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3703942Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
Aleksey Khoroshilov authored
This reverts commit 6754c49e. Reason for revert: will be relanded with fixed batch comments that triggered parser error. Original change's description: > Revert "Make depot_tools scripts return exit codes properly on all platforms." > > This reverts commit 7c4f7ec4. > > Reason for revert: bugs reported by users (see comments in Gerrit). > error: block. was unexpected at this time. > > Original change's description: > > Make depot_tools scripts return exit codes properly on all platforms. > > > > Changes: > > 1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation. > > 2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation. > > 3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure. > > > > A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations. > > > > Test case for update_depot_tools changes: > > 1. Make a change to depot_tools sources that will conflict with next depot_tools update > > 2. Run update_depot_tools either directly or via gclient > > 3. Expect a git error is triggered > > 4. Inspect %errorlevel% or $? depending on platform > > 5. Expected 1, but the actual result is 0. > > > > Test case for changes in other .bat files: > > 1. Make a change to depot_tools sources that will conflict with next depot_tools update > > 2. Run cmd /c gclient > > 3. Expect a git error is triggered > > 4. Inspect %errorlevel% > > 5. Expected 1, but the actual result is 0. > > > > Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632 > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > > Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Change-Id: I85d598af01d75588cdee77165d6af22270ee031d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3694139 > Auto-Submit: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Change-Id: I377f966ea1b1a567de815caca703b5e124a76b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696396Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
-
- 10 Jun, 2022 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8811716339900330657 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dfb53acac971bed26ea89cbeeedd748de5ca7938 dfb53ac (jkusuma@google.com) Update resultdb recipe module to support gcs uri. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I873e31a9bd0d955f7f04b11305874c6f083840e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3699409 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Bruce Dawson authored
While all Chromium PRESUBMIT.py scripts have been running on Python 2 for a long time they continue to invoke child scripts under Python 2. Part of the reason for slow progress on this transition is that it is not easy to tell that this is happening, and most developers probably assume that Python 3 presubmits implies a lack of Python 2. This change adds a warning when it detects Python 2 scripts being run. Typical output (edited for clarity) looks like this: git cl presubmit --files "chrome/updater/tools/*;ppapi/generators/*" ... Python 2 scripts were run during Python 3 presubmits. Please ask ??? if help is needed in preventing this. "depot_tools\pylint-1.5" --args-on-stdin from chrome\updater\tools \ "depot_tools\pylint-1.5" --args-on-stdin from chrome\updater\tools \ idl_tests.py from ppapi\generators If Python 2 scripts launch child scripts, especially if they use sys.executable, then they will not be reported. However this is a good thing because it means that the report focuses on the top-level scripts that drive Python 2 usage. This change works by modifying vpython.bat to write invocation information to a text file. The data in this text file is picked up by presubmit_support.py when it finishes running a set of presubmits. Bug: 1313804 Change-Id: Ic632b38eae07eca2e02e94358305cc9c998818e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3699002Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 09 Jun, 2022 4 commits
-
-
Joanna Wang authored
Bug:1330629 Change-Id: Ieccf72c75dda7cbec473fcfa07d25fb59f8eb7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3689728 Commit-Queue: Joanna Wang <jojwang@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com>
-
Josip Sokcevic authored
When initializing git_cache repository, we can't assume the default branch is main. This results in HEAD pointing to invalid ref for repos that don't have main branch. Instead, fetch information from remote git repository. R=gavinmak@google.com Fixed: 1334889 Change-Id: I84e6d8e09c81bdae7e5e31af88973534431824e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696906Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Junji Watanabe authored
https://crrev.com/c/3686855 missed this file to run cipd.bat. Bug: 931218 Change-Id: Ib4f8d9d31c259477d5531f32bf1e6f44d71d2ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3697956Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org>
-
Leszek Swirski authored
Add helpers to gerrit_util for: * Setting the commit message on a ChangeEdit, * Creating a cherry-pick, * Getting the contents of a file in a change. Bug: v8:12849 Change-Id: I1a5de3054a366d480def32942fd42be179ffb749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3683383 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
- 08 Jun, 2022 7 commits
-
-
Bruce Dawson authored
presubmit --all should succeed regardless of the current state of the tree. Otherwise a presubmit --all bot will be flaky due to circumstances beyond its control. This is a logical follow-on to crrev.com/c/3628368 which turned some other errors into warnings for presubmit --all. Bug: 1309977 Change-Id: I6d26708f8c47916cf015dec75e27833db7ca465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696070 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Rebecca Chang Swee Fun authored
Signed-off-by:
Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com> Bug: 1331190 Change-Id: I7c751e5cf02f088f2145c3c701547f0412f2bd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686858Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Will Cassella authored
It's sometimes possible to end up with a depot_tools checkout that isn't a git repository, which breaks the update mechanism. Rather than allowing the updater to silently fail and have things break several weeks/months later, we should emit a warning. Bug: 1333997 Change-Id: I70ae4f3b479e24b87987847927184687caf08b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3692864Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Will Cassella <cassew@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org>
-
Leszek Swirski authored
gerrit_util.ChangeEdit was passing the result of b64encode into a %s format, which was printing the contents with a bytes prefix (b'...'). Decode the bytes object back to a str object before passing it to '%s' Bug: v8:12849 Change-Id: I8b54b427bbbe8b914444d7486b5a8afbd743de70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3683382Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Junji Watanabe authored
https://crrev.com/c/3674982 caused compile step failures finding depot_tools/.cipd_bin/ninja because depot_tools recipe bundle doesn't setup .cipd_bin. It needs to ensure .cipd_bin by calling cipd_bin_setup.{sh, bat} before calling ninja in the depot_tool recipe module. This CL bundles more files required to call cipd_bin_setup. Bug: 931218 Change-Id: I3d5067c0326415b086aca7e6e56a8f6428969b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686855 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Takuto Ikuta authored
This reverts commit c90a9821. Reason for revert: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8811949917908303825/+/u/compile/stdout Original change's description: > Switch to use CIPD ninja v1.8.2 > > https://crrev.com/c/3674981 installed CIPD ninja packages. > This CL switches from the old ninja binaries to them. > > Note that this CL doesn't change ninja version. the old/CIPD ninja binaries are v1.8.2. > > The differences from the old binaries are > - the CIPD packages don't use chromium's clang. > - the CIPD package for Linux doesn't use chromium's sysroot. > - the min macOS version is 10.13, which was 10.6. > Please also see https://crsrc.org/i/3pp/ninja/install_bootstrap.sh > > > On Windows, ninja.exe will be installed under .cipd_bin. > But there are many places that assume that ninja.exe exists on depot_tools root. So this CL also copies the ninja.exe from .cipd_bin to root in cipd_bin_setup.bat. > > Bug: 931218 > Change-Id: Ib67eee5e9b6ad9b2937b789626970d9c85867dbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674982 > Commit-Queue: Junji Watanabe <jwata@google.com> > Reviewed-by: Philipp Wollermann <philwo@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Bug: 931218 Change-Id: I08d61dad119a0d23ae9ec8b1ed787dd3915de697 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3686854 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Takuto Ikuta <tikuta@chromium.org>
-
Junji Watanabe authored
https://crrev.com/c/3674981 installed CIPD ninja packages. This CL switches from the old ninja binaries to them. Note that this CL doesn't change ninja version. the old/CIPD ninja binaries are v1.8.2. The differences from the old binaries are - the CIPD packages don't use chromium's clang. - the CIPD package for Linux doesn't use chromium's sysroot. - the min macOS version is 10.13, which was 10.6. Please also see https://crsrc.org/i/3pp/ninja/install_bootstrap.sh On Windows, ninja.exe will be installed under .cipd_bin. But there are many places that assume that ninja.exe exists on depot_tools root. So this CL also copies the ninja.exe from .cipd_bin to root in cipd_bin_setup.bat. Bug: 931218 Change-Id: Ib67eee5e9b6ad9b2937b789626970d9c85867dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674982 Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by:
Philipp Wollermann <philwo@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 07 Jun, 2022 6 commits
-
-
Josip Sokcevic authored
This reverts commit 7c4f7ec4. Reason for revert: bugs reported by users (see comments in Gerrit). error: block. was unexpected at this time. Original change's description: > Make depot_tools scripts return exit codes properly on all platforms. > > Changes: > 1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation. > 2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation. > 3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure. > > A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations. > > Test case for update_depot_tools changes: > 1. Make a change to depot_tools sources that will conflict with next depot_tools update > 2. Run update_depot_tools either directly or via gclient > 3. Expect a git error is triggered > 4. Inspect %errorlevel% or $? depending on platform > 5. Expected 1, but the actual result is 0. > > Test case for changes in other .bat files: > 1. Make a change to depot_tools sources that will conflict with next depot_tools update > 2. Run cmd /c gclient > 3. Expect a git error is triggered > 4. Inspect %errorlevel% > 5. Expected 1, but the actual result is 0. > > Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Change-Id: I85d598af01d75588cdee77165d6af22270ee031d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3694139 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Ryan Heise authored
Bug:1286319 Change-Id: I7b205e48605f3d889a4780043fdfc54e900aff01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3692861Reviewed-by:
Leina Sun <sunxiaodi@google.com> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Ryan Heise <heiserya@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
Victor Vianna authored
AFAIK, flash is long gone from Chromium. Bug: 1064651 Change-Id: I25b98ac2b44e52fa3e3cfdbc9d7716ee736a4b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3687701 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8811985614603312065 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/51b3aed56d1ba5b0e8ac65f94c20b15513a5f87c 51b3aed (jkusuma@google.com) Update go.chromium.org/luci protos related to resultdb. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I60997a4ef19b45a3ce381ea885ba0932bf78f6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3694138 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Aleksey Khoroshilov authored
Changes: 1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation. 2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation. 3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure. A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations. Test case for update_depot_tools changes: 1. Make a change to depot_tools sources that will conflict with next depot_tools update 2. Run update_depot_tools either directly or via gclient 3. Expect a git error is triggered 4. Inspect %errorlevel% or $? depending on platform 5. Expected 1, but the actual result is 0. Test case for changes in other .bat files: 1. Make a change to depot_tools sources that will conflict with next depot_tools update 2. Run cmd /c gclient 3. Expect a git error is triggered 4. Inspect %errorlevel% 5. Expected 1, but the actual result is 0. Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8812059854989420705 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/92f7100ca350a89b67174e89eaef52fb04c5e8ef 92f7100 (iannucci@chromium.org) [proto] Add ability to inject python files when scanning protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I11df85101f6262d6e3529db3598b2a294d170216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3691023 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 04 Jun, 2022 1 commit
-
-
Bruce Dawson authored
A run of "git cl presubmit --all" shows that PyLint 1.5 is being run from nine locations, however the deprecation warnings don't say where. This makes it difficult to file bugs or fix the remaining instances. This changes the message to list the path to the presubmit that is running PyLint 1.5. This also adds instructions on how to change to version 2.7. Before: pylint-1.5 is deprecated, please switch to 2.7 before 2022-07-11 After (with word wrapping): pylint-1.5 is being run on ...src\tools\find_runtime_symbols and is deprecated, please switch to 2.7 before 2022-07-11 (add version='2.7' to RunPylint call) Change-Id: Iece2cb904f5d26ad66e3ab78f7ce7aef1878bfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688839Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 03 Jun, 2022 5 commits
-
-
Aleksey Khoroshilov authored
When a repository doesn't work with Gerrit, it doesn't make sense to create GerritAccessor and pass it to presubmit checks. gerrit.host is stored into git config when codereview.settings file contains GERRIT_HOST item. Change-Id: I9740950caf85a1da9a6e4ae12e3612625cf0cec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3687235Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
Tested manually since we have no unit tests that cover this bit. R=gavinmak@google.com Bug: 1105747 Change-Id: I113e27236ed450490e59df9a6f698925ff556bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3685350Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Aleksey Khoroshilov authored
When PRESUBMIT is run with a custom --upstream, dry run cl format should also use this value, otherwise format warnings would be inconsistent. Change-Id: I1370f614618ecc03706e54cd4b151a207d9b3bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688631 Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Fumitoshi Ukai authored
Bug: b/234078033 Change-Id: I54589891b54986859db539e45c3a208f97081bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3689029Reviewed-by:
Junji Watanabe <jwata@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org>
-
Junji Watanabe authored
Currently, the ninja binaries in depot_tools are committed to the repo directly. This CL installs CIPD ninja packages to replace them. Switching to CIPD ninja will be done in the next CL. Also, see the performance comparison and CIPD packages in the comments below. https://crbug.com/931218#c84 https://crbug.com/931218#c86 Bug: 931218 Change-Id: I44d5e9ea1447588b32a10db20cfba088dd748f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674981 Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org>
-
- 02 Jun, 2022 5 commits
-
-
Joanna Wang authored
Bug:1330629 Change-Id: I522255528e36d4806eada70c22afee1277a6778d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3668429Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Joanna Wang <jojwang@chromium.org>
-
Aravind Vasudevan authored
This CL makes fetch default to sso:// within the cog env. It also adds a helper within gclient_scm to check if the env is cog. Bug: chrome-operations:170 Change-Id: I8c35348653406549fadbd08df3d9991bb24ca776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3670721Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Joanna Wang <jojwang@chromium.org> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
Aleksey Khoroshilov authored
Remove unnecessary os.listdir call and fix infinite loop on Windows if no file was found in a tree. Change-Id: I82a8763e807bbc0ce6fcae6b35a370ffe3b34943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3687234Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
-
Bruce Dawson authored
This reverts commit 013e47be. Reason for revert: This will be relanded as a warning, although the bugs which the original change exposed should be fixed soon. Original change's description: > Revert "Fix not-run-test detection." > > This reverts commit 41691abe. > > Reason for revert: I thought https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3683378 would solve the problem but turns out this is the issue where it now reports it as a critical error. > > Original change's description: > > Fix not-run-test detection. > > > > In crrev.com/c/2986400 the skip_shebang_check flag was added to address > > the problem of some tests being run neither on Python 2 or Python 3. At > > the same time reporting was added to warn if tests were run on neither > > Python version. > > > > Unfortunately the reporting code was incorrect. A PresubmitPromptWarning > > object was created but was not added to the list of results, so it had > > no effect. Also the skipped tests name was added where a list was > > expected which meant that each character of the test name showed up on > > its own line. > > > > This change fixes the reporting. It also changes the format of the > > report and makes it an error - a failure to run tests at all deserves > > that severity level. > > > > A test run with the fixed check showed that no errors have crept in - > > all tests were being run with one or the other. However the fix did > > find a bug in an in-progress change I was working on. > > > > Bug: 1223478 > > Change-Id: Ibb44b5e60e7a7a5de08302f19ee4035cdfac5212 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3674199 > > Auto-Submit: Bruce Dawson <brucedawson@chromium.org> > > Commit-Queue: Fabrice de Gans <fdegans@chromium.org> > > Reviewed-by: Fabrice de Gans <fdegans@chromium.org> > > Bug: 1223478 > Change-Id: If4395e90784c3f91692f398b4e5230a51139f78a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3683105 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Bug: 1223478, 1330859 Change-Id: I6a0a78e70db77c9c5fda5bab27960cd4e71279e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3685349Reviewed-by:
Fabrice de Gans <fdegans@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
This reverts commit c03ebf0e. Reason for revert: the original change was not the cause of the test failures. The actual cause was crrev.com/c/3683105 which was reverted. Original change's description: > Revert "Add Python 3 support to GetPythonUnitTests" > > This reverts commit dfc71bbe. > > Reason for revert: Breaks all presubmits that do not have skip_shebang_check=True set. > > Original change's description: > > Add Python 3 support to GetPythonUnitTests > > > > GetPythonUnitTests (and by extension RunPythonUnitTests) always ran > > scripts using Python 2. This change adds a python3=False parameter to > > GetPythonUnitTests to give the option of switching to Python 3, while > > leaving the default as Python 2. The child scripts are run under one or > > the other, based on this parameter. > > > > This change is needed in support of crrev.com/c/3679801. > > > > Bug: 1313804 > > Change-Id: Ic59287352d4941707adaf7981ed7af4201b7d526 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3680099 > > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Bug: 1313804 > Change-Id: I1bd7096b6cfdfed6205e6dc0b5d4498b5b821b97 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3683378 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Christoffer Jansson <jansson@chromium.org> > Owners-Override: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Tomas Gunnarsson <tommi@chromium.org> Bug: 1313804 Change-Id: I15ed90cc35d88ece71eb681acc0acc06cb5c3bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3685229 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com>
-
- 01 Jun, 2022 3 commits
-
-
Aravind Vasudevan authored
This is a reland of commit 6817010e Additional Changes: This reland fixes https://crbug.com/1330995 by stopping gclient from accidentally updating the scheme when one is not present. Original change's description: > Update fetch protocol using --protocol-override flag > > This CL updates gclient sync to use the protocol of the URL specified in the solutions for cloning all the child dependencies of it. > > Bug: chrome-operations:170 > Change-Id: I33588059788b677fbae8c3b434100af5c7979a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3631600 > Reviewed-by: Joanna Wang <jojwang@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Bug: 1330995 Change-Id: I1447a5e884e41d671d8556c35193f1635f2f6936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3684112Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Joanna Wang <jojwang@chromium.org> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
Stephanie Kim authored
Currently cipd packages listed in src/DEPS are being created and installed in symlink mode (see bug for more info). This CL adds `$OverrideInstallMode copy` to the ensure files for cipd packages installed during gclient runhooks. `$OverrideInstallMode` was implemented here, https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3124202, so that every cipd package can be installed directly to the installation target, instead of being symlinked to an executable inside the cache/builder/.cipd dir. The added `$OverrideInstallMode copy` can be removed once all cipd packages themselves or the default mode is updated to be created in copy mode. Bug: 1329641 Change-Id: I68dc718e20f193c384d005c9b6b87603753943d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3673698Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
-
Aravind Vasudevan authored
This reverts commit 6817010e. Reason for revert: Breaks gclient sync for flutter Original change's description: > Update fetch protocol using --protocol-override flag > > This CL updates gclient sync to use the protocol of the URL specified in the solutions for cloning all the child dependencies of it. > > Bug: chrome-operations:170 > Change-Id: I33588059788b677fbae8c3b434100af5c7979a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3631600 > Reviewed-by: Joanna Wang <jojwang@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Bug: chrome-operations:170 Change-Id: I76a49030f48fa266eeea336307e7153b22ded4e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3684110 Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-