• Aleksey Khoroshilov's avatar
    Reland "Make depot_tools scripts return exit codes properly on all platforms." · 544594e0
    Aleksey Khoroshilov authored
    This reverts commit 6754c49e.
    
    Reason for revert: will be relanded with fixed batch comments that triggered parser error.
    
    Original change's description:
    > Revert "Make depot_tools scripts return exit codes properly on all platforms."
    >
    > This reverts commit 7c4f7ec4.
    >
    > Reason for revert: bugs reported by users (see comments in Gerrit).
    > error: block. was unexpected at this time.
    >
    > Original change's description:
    > > Make depot_tools scripts return exit codes properly on all platforms.
    > >
    > > Changes:
    > > 1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation.
    > > 2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation.
    > > 3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure.
    > >
    > > A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations.
    > >
    > > Test case for update_depot_tools changes:
    > > 1. Make a change to depot_tools sources that will conflict with next depot_tools update
    > > 2. Run update_depot_tools either directly or via gclient
    > > 3. Expect a git error is triggered
    > > 4. Inspect %errorlevel% or $? depending on platform
    > > 5. Expected 1, but the actual result is 0.
    > >
    > > Test case for changes in other .bat files:
    > > 1. Make a change to depot_tools sources that will conflict with next depot_tools update
    > > 2. Run cmd /c gclient
    > > 3. Expect a git error is triggered
    > > 4. Inspect %errorlevel%
    > > 5. Expected 1, but the actual result is 0.
    > >
    > > Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632
    > > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
    > > Commit-Queue: Josip Sokcevic <sokcevic@google.com>
    > > Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
    > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    >
    > Change-Id: I85d598af01d75588cdee77165d6af22270ee031d
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3694139
    > Auto-Submit: Josip Sokcevic <sokcevic@google.com>
    > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    
    Change-Id: I377f966ea1b1a567de815caca703b5e124a76b64
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696396Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
    Reviewed-by: 's avatarBruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Josip Sokcevic <sokcevic@google.com>
    Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
    544594e0
Name
Last commit
Last update
bootstrap Loading commit data...
fetch_configs Loading commit data...
git-templates Loading commit data...
infra Loading commit data...
man Loading commit data...
python-bin Loading commit data...
python2-bin Loading commit data...
recipes Loading commit data...
testing_support Loading commit data...
tests Loading commit data...
third_party Loading commit data...
win_toolchain Loading commit data...
zsh-goodies Loading commit data...
.cipd_impl.ps1 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.isort.cfg Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
CROS_OWNERS Loading commit data...
DIR_METADATA Loading commit data...
GOMA_OWNERS Loading commit data...
LICENSE Loading commit data...
LUCI_OWNERS Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.gclient.md Loading commit data...
README.git-cl.md Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
auth.py Loading commit data...
autoninja Loading commit data...
autoninja.bat Loading commit data...
autoninja.py Loading commit data...
bb Loading commit data...
bb.bat Loading commit data...
black Loading commit data...
bootstrap_python3 Loading commit data...
breakpad.py Loading commit data...
cbuildbot Loading commit data...
cipd Loading commit data...
cipd.bat Loading commit data...
cipd_bin_setup.bat Loading commit data...
cipd_bin_setup.sh Loading commit data...
cipd_client_version Loading commit data...
cipd_client_version.digests Loading commit data...
cipd_manifest.txt Loading commit data...
cipd_manifest.versions Loading commit data...
cit Loading commit data...
cit.bat Loading commit data...
cit.py Loading commit data...
clang-format Loading commit data...
clang-format.bat Loading commit data...
clang_format.py Loading commit data...
clang_format_merge_driver Loading commit data...
clang_format_merge_driver.bat Loading commit data...
clang_format_merge_driver.py Loading commit data...
codereview.settings Loading commit data...
compile_single_file Loading commit data...
compile_single_file.bat Loading commit data...
compile_single_file.py Loading commit data...
cpplint.bat Loading commit data...
cpplint.py Loading commit data...
cpplint_chromium.py Loading commit data...
cros Loading commit data...
cros_sdk Loading commit data...
crosjobs Loading commit data...
detect_host_arch.py Loading commit data...
dirmd Loading commit data...
dirmd.bat Loading commit data...
download_from_google_storage Loading commit data...
download_from_google_storage.bat Loading commit data...
download_from_google_storage.py Loading commit data...
ensure_bootstrap Loading commit data...
fetch Loading commit data...
fetch.bat Loading commit data...
fetch.py Loading commit data...
fix_encoding.py Loading commit data...
gclient Loading commit data...
gclient-new-workdir.py Loading commit data...
gclient.bat Loading commit data...
gclient.py Loading commit data...
gclient_completion.sh Loading commit data...
gclient_eval.py Loading commit data...
gclient_paths.py Loading commit data...
gclient_scm.py Loading commit data...
gclient_utils.py Loading commit data...
gerrit_client.py Loading commit data...
gerrit_util.py Loading commit data...
git-cache Loading commit data...
git-cl Loading commit data...
git-crrev-parse Loading commit data...
git-drover Loading commit data...
git-find-releases Loading commit data...
git-footers Loading commit data...
git-freeze Loading commit data...
git-gs Loading commit data...
git-hyper-blame Loading commit data...
git-map Loading commit data...
git-map-branches Loading commit data...
git-mark-merge-base Loading commit data...
git-migrate-default-branch Loading commit data...
git-nav-downstream Loading commit data...
git-nav-upstream Loading commit data...
git-new-branch Loading commit data...
git-number Loading commit data...
git-rebase-update Loading commit data...
git-rename-branch Loading commit data...
git-reparent-branch Loading commit data...
git-retry Loading commit data...
git-runhooks Loading commit data...
git-squash-branch Loading commit data...
git-thaw Loading commit data...
git-upstream-diff Loading commit data...
git_cache.py Loading commit data...
git_cl.py Loading commit data...
git_cl_completion.sh Loading commit data...
git_common.py Loading commit data...
git_dates.py Loading commit data...
git_drover.py Loading commit data...
git_find_releases.py Loading commit data...
git_footers.py Loading commit data...
git_freezer.py Loading commit data...
git_hyper_blame.py Loading commit data...
git_map.py Loading commit data...
git_map_branches.py Loading commit data...
git_mark_merge_base.py Loading commit data...
git_migrate_default_branch.py Loading commit data...
git_nav_downstream.py Loading commit data...
git_new_branch.py Loading commit data...
git_number.py Loading commit data...
git_rebase_update.py Loading commit data...
git_rename_branch.py Loading commit data...
git_reparent_branch.py Loading commit data...
git_retry.py Loading commit data...
git_squash_branch.py Loading commit data...
git_upstream_diff.py Loading commit data...
gn Loading commit data...
gn.bat Loading commit data...
gn.py Loading commit data...
goma_auth Loading commit data...
goma_auth.bat Loading commit data...
goma_ctl Loading commit data...
goma_ctl.bat Loading commit data...
gsutil.py Loading commit data...
gsutil.py.bat Loading commit data...
gsutil.vpython3 Loading commit data...
isort Loading commit data...
led Loading commit data...
led.bat Loading commit data...
lockfile.py Loading commit data...
luci-auth Loading commit data...
luci-auth.bat Loading commit data...
lucicfg Loading commit data...
lucicfg.bat Loading commit data...
mac_toolchain Loading commit data...
metrics.README.md Loading commit data...
metrics.py Loading commit data...
metrics_utils.py Loading commit data...
my_activity.py Loading commit data...
ninja Loading commit data...
ninja-linux64 Loading commit data...
ninja-mac Loading commit data...
ninja.exe Loading commit data...
ninjalog.README.md Loading commit data...
ninjalog_uploader.py Loading commit data...
ninjalog_uploader_wrapper.py Loading commit data...
owners.py Loading commit data...
owners_client.py Loading commit data...
owners_finder.py Loading commit data...
pinpoint Loading commit data...
pinpoint.bat Loading commit data...
post_build_ninja_summary.py Loading commit data...
presubmit_canned_checks.py Loading commit data...
presubmit_canned_checks_test.py Loading commit data...
presubmit_canned_checks_test_mocks.py Loading commit data...
presubmit_support.py Loading commit data...
profile.xml Loading commit data...
prpc Loading commit data...
prpc.bat Loading commit data...
pylint Loading commit data...
pylint-1.5 Loading commit data...
pylint-1.5.bat Loading commit data...
pylint-2.6 Loading commit data...
pylint-2.6.bat Loading commit data...
pylint-2.7 Loading commit data...
pylint-2.7.bat Loading commit data...
pylint.bat Loading commit data...
pylint_main.py Loading commit data...
pylintrc Loading commit data...
python_runner.sh Loading commit data...
rdb Loading commit data...
rdb.bat Loading commit data...
rdb_wrapper.py Loading commit data...
repo Loading commit data...
repo_launcher Loading commit data...
roll-dep Loading commit data...
roll-dep.bat Loading commit data...
roll_dep.py Loading commit data...
rustfmt.py Loading commit data...
scm.py Loading commit data...
setup_color.py Loading commit data...
split_cl.py Loading commit data...
subcommand.py Loading commit data...
subprocess2.py Loading commit data...
swift-format Loading commit data...
swift_format.py Loading commit data...
update_depot_tools Loading commit data...
update_depot_tools.bat Loading commit data...
update_depot_tools_toggle.py Loading commit data...
upload_metrics.py Loading commit data...
upload_to_google_storage.py Loading commit data...
utils.py Loading commit data...
vpython Loading commit data...
vpython.bat Loading commit data...
vpython3 Loading commit data...
vpython3.bat Loading commit data...
watchlists.py Loading commit data...
weekly Loading commit data...
whitespace.txt Loading commit data...
win32imports.py Loading commit data...
wtf Loading commit data...
yapf Loading commit data...
yapf.bat Loading commit data...