- 20 Apr, 2017 1 commit
-
-
Andrii Shyshkalov authored
R=maruel@chromium.org,jrobbins@chromium.org BUG=712060 Change-Id: I16651d9926fe0f3a74549a4c03896220f9a58f94 Reviewed-on: https://chromium-review.googlesource.com/482659Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 11 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
This will hopefully make Rietveld._send retry 500s like it promises to BUG=585632 Review URL: https://codereview.chromium.org/1681333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
BUG=585632 TBR=agable Review URL: https://codereview.chromium.org/1686753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298693 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
This will hopefully make Rietveld._send retry 500s like it promises to BUG= Review URL: https://codereview.chromium.org/1683603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298688 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Nov, 2015 1 commit
-
-
cbentzel@chromium.org authored
Manually generating param strings shows that the 1/2 values do not work. Review URL: https://codereview.chromium.org/1482153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297732 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Oct, 2015 1 commit
-
-
dsansome@chromium.org authored
To fix this flake: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/1216/steps/bot_update/logs/stdio BUG= Review URL: https://codereview.chromium.org/1417963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297234 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2014 1 commit
-
-
sergeyberezin@chromium.org authored
ssl.SSLError does NOT have 'reason' attribute. Use str() to get a reliable string. Fixed the silly bug in another CL: https://codereview.chromium.org/180273003/ The ssl.SSLError does NOT have attribute 'reason', and must use the generic 'strerror' instead. This is what happens when I submit a CL too fast... BUG=346845 R=stip@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/180723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253317 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Feb, 2014 1 commit
-
-
sergeyberezin@chromium.org authored
BUG=345117 Review URL: https://codereview.chromium.org/174313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252452 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 May, 2013 1 commit
-
-
maruel@chromium.org authored
This makes the commit description cleaner. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14061008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199275 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2012 1 commit
-
-
maruel@chromium.org authored
Multiple presubmit checks may call the same function multiple times, so it's worth caching the results to speed up the presubmit check run. Convert presubmit_support, git-cl and gcl to use it. R=dpranke@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11280143 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 May, 2012 1 commit
-
-
maruel@chromium.org authored
Rietveld self-corrupts its status all the time, there is not point in bailing just because of that. So just assume it's an 'M' and it'll work fine. In any case, the diff is properly parsed to detect what was the real operation. Add unit test that correctly process a deleted file with status:null. TBR=nsylvain@chromium.org BUG= TEST=A corrupted patchset can still be committed with the Commit Queue. Review URL: http://codereview.chromium.org/10272024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134733 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jan, 2012 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9172003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117133 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jan, 2012 1 commit
-
-
maruel@chromium.org authored
Fix RAW.NEW_NOT_NULL parsing to detect correctly it's a new file. Add proper Hunk parsing to fix these 2 bugs. R=dpranke@chromium.org BUG=109715 TEST=CQ'ing a patch generated with svn that delete files is applied properly, e.g. the file is deleted and not simple 0-length. Review URL: http://codereview.chromium.org/9167015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117084 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 2 commits
-
-
maruel@chromium.org authored
Add relevant new tests. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8539016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109692 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
The patches needs to by applied 'in-order' to not delete source files. Added more tests. R=dpranke@chromium.org BUG=94330 TEST= Review URL: http://codereview.chromium.org/8038056 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103309 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add search interface for rietveld. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7977030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102191 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Sep, 2011 5 commits
-
-
maruel@chromium.org authored
It's proved to be unreliable. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7857006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100236 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add regression test. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7754020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100209 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Update unit test accordingly. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7754016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100207 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Also verify source_filename properly. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7849015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100205 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6874006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100138 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add support for a few svn:* properties. Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway. More testing. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7840003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
I plan to do some refactoring and these tests will help reduce the likehood of regression. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7739039 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
That means some properties will being to be applied. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7776015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6877038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82406 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
It will be used for: - git cl patch so binary files can be patched - try jobs instead of doing a curl <url> | patch BUG= TEST= Review URL: http://codereview.chromium.org/6792028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80355 0039d316-1c4b-4281-b951-d872f2087c98
-