Commits · b139178fb593a3a6dc0891288cd017fcb789d5cc · Linshizhi / Chromium_Depot_tools

07 Mar, 2019 3 commits

[lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3. · b139178f

Vadim Shtayura authored Mar 07, 2019

Changes:
2019-03-07 dburger@chromium.org Add dummy BuilderConfig proto to lucicfg external protos.
2019-03-06 vadimsh@chromium.org [lucicfg] Forbid "luci.*" bucket names in luci.bucket(...).
2019-03-06 vadimsh@chromium.org [lucicfg] Use 'flatten_buildbucket_cfg' tool to normalize cr-buildbucket.cfg.
2019-03-06 vadimsh@chromium.org [lucicfg] Add 'triggered_by' support to CQ config generator.
2019-03-06 vadimsh@chromium.org [lucicfg] Add "lucicfg semantic-diff" subcommand to aid in the migration.
2019-03-05 vadimsh@chromium.org [lucicfg] Add luci.cq_tryjob_verifier(...).
2019-03-05 vadimsh@chromium.org [lucicfg] Add retry_config support.
2019-03-04 vadimsh@chromium.org [lucicfg] Initial implementation of luci.cq_group(...).
2019-03-02 vadimsh@chromium.org [lucicfg] Make '#!/usr/bin/env lucicfg' work.
2019-02-28 vadimsh@chromium.org [lucicfg] Add luci.cq(...) rule.
2019-02-27 vadimsh@chromium.org [lucicfg] Get rid of `refs_regexps`, always accept regexps via `refs`.
2019-02-27 seanabraham@chromium.org crostesting: Change "BuildCritera" to "TargetCriteria"

R=tandrii@chromium.org

Change-Id: I8477088c50764ba847424eb1e59be34d03d86eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509016
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

b139178f

Revert "Avoid unnecessary invocations of "git fetch"" · 0cec542e

Edward Lesmes authored Mar 07, 2019

This reverts commit 61a1b5f3.

Reason for revert:
It's blocking skia autoroller
https://skia-review.googlesource.com/c/buildbot/+/198700

Original change's description:
> Avoid unnecessary invocations of "git fetch"
> 
> If we already have the correct commit, it is not necessary to fetch.  Any
> fetches can takes minutes due to gerrit problems, and often fail
> completely, so it is helpful to avoid them completely whenever we can.
> 
> Bug: 938627
> 
> Change-Id: I54494cad9b9aa0090f51674b6b9f56bb3e842f12
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
> Commit-Queue: Michael Spang <spang@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=spang@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: If8bd26d74bf84ff0ca69378dbfe6b9369b9988d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 938627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1508980Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0cec542e

gclient: Fetch refs/{branch-heads,tags}/* if needed. · db5c5ade

Edward Lemur authored Mar 07, 2019

If we're asked to sync a repo to branch-heads or tags,
make sure we fetch refs/branch-heads/* and refs/tags/* even if
--with-branch-heads or --with-tags was not passed.

Bug: 938160
Change-Id: I04de8e7762c83322692d9551d057ec803fd2ac9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506420Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

db5c5ade

06 Mar, 2019 4 commits

Roll recipe dependencies (trivial). · ffb1ffb8

recipe-roller authored Mar 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/64b31a70df43a9a0bd220a667a5d7ea500348879 [scheduler] Use buildbucket API instead of props (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If1429732e53693d50841afe097c58916d0b83ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506286Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ffb1ffb8

Roll recipe dependencies (trivial). · 48f640f5

recipe-roller authored Mar 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2009db83ebf1017a34c5390585f3eb9f288c47e3 [run_build] Add skeleton run_build command, testing script, bundle support. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba5af13da6a11ebb79c2a2b459099fe65830f99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1506282Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

48f640f5

Avoid unnecessary invocations of "git fetch" · 61a1b5f3

Michael Spang authored Mar 06, 2019

If we already have the correct commit, it is not necessary to fetch.  Any
fetches can takes minutes due to gerrit problems, and often fail
completely, so it is helpful to avoid them completely whenever we can.

Bug: 938627

Change-Id: I54494cad9b9aa0090f51674b6b9f56bb3e842f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

61a1b5f3

Also redirect stderr from the browser since Chrome recently started using it too · 0668403d

Sergiy Belozorov authored Mar 06, 2019

Example stderr output from Chrome:

  [24599:24650:0306/123817.372418:ERROR:browser_process_sub_thread.cc(209)]
  Waited 3 ms for network service

R=nodir@chromium.org

Change-Id: Idb71c9f3a2c735ee49b886896f55bdede559137c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1505792Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>

0668403d

05 Mar, 2019 5 commits

Roll recipe dependencies (trivial). · 7e68767e

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55876a3b36992bb1cf5984cb136da88de5068fd3 [buildbucket] read hostname (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16b0481fe20159a05b6c523b86776cf17d5119fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504243Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7e68767e

Roll recipe dependencies (trivial). · 314a2f06

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f069044eb4ac5e3050d42898d4f02d491d7e6c4a Reland "[buildbucket] Use RPC protobufs" (nodir@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If22b4f983b3e12eeec0e39b3fedf1b27ea0ae96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503683Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

314a2f06

Roll recipe dependencies (trivial). · d0082247

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)
  https://crrev.com/8925d49937f06510ef00b9469e53bc69c2429da9 Revert "[buildbucket] Use RPC protobufs" (martiniss@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0bbb092974b6611a0c619fd69361ad13ae93581c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503681Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d0082247

Revert "Roll recipe dependencies (trivial)." · 3963d9b2

Stephen Martinis authored Mar 05, 2019

This reverts commit 5b3bf586.

Reason for revert: Broke everything

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
>   https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I8643525a58ddbe3ee51df24493ba8de95fea73a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503678
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: I6b2491ce379298feeff84f694a552aa7d1f3a1ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504096Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

3963d9b2

Roll recipe dependencies (trivial). · 5b3bf586

recipe-roller authored Mar 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/89a54e079cf02c6696ae6cac9052fa7cada7becc [buildbucket] Use RPC protobufs (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8643525a58ddbe3ee51df24493ba8de95fea73a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1503678Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

5b3bf586

04 Mar, 2019 5 commits

Roll recipe dependencies (trivial). · adbf3bef

recipe-roller authored Mar 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aa56edf9619152ce9971d90461d909f215e7fab4 [third_party/logdog] Rev to latest. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8496b82c553fbc52635e781551482a7551f12cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1500916Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

adbf3bef

[bot_update] Downstream change for buildbucket proto update. · cf661acb

Robert Iannucci authored Mar 04, 2019

Downstream counterpart to https://chromium-review.googlesource.com/1481660

R=martiniss@chromium.org, nodir@chromium.org

Bug: 930761, 927716
Change-Id: Ib6390b3d27bed79a01eefa966084233e71aa8235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1496049
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

cf661acb

Add --no-branch-color option to git cl status · a3be9a52

Alan Cutter authored Mar 04, 2019

Change-Id: Ieebdb32ac316a443789e26f3be8d5dcb4f94c4b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1470404Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>

a3be9a52

Roll recipe dependencies (trivial). · 8f418985

recipe-roller authored Mar 04, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ae3604f2d2ae0291ecdc690672cc173e06a965ba [proto_support] Handle unicode filesystem walks. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2ab9ccba317f6a74d1c05748ca7d4cceddd0be28
Reviewed-on: https://chromium-review.googlesource.com/c/1498126Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

8f418985

autoninja: limit j value for mac · da4dbf85

Takuto Ikuta authored Mar 04, 2019

Large parallelism causes too many open files error.
Let me limit to 500 for Mac now.

Bug: 936864
Change-Id: I2fccc8cf14483c6f34d84c84d82c44df6e4f3177
Reviewed-on: https://chromium-review.googlesource.com/c/1496675Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

da4dbf85

03 Mar, 2019 1 commit

Improve error message for missing gerrit credentials in git-cl. · e9e89e3a

William Hesse authored Mar 03, 2019

Bug:
Change-Id: I058fcd85548c6e17f33de71ed2ad04549294e13d
R: dpranke@chromium.org, iannucci@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/558250Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e9e89e3a

02 Mar, 2019 2 commits

Roll recipe dependencies (trivial). · 71bae22f

recipe-roller authored Mar 02, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1a86f54ceba35d31196e8664958e53ba8f64cbd2 cq: fix a comment. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6b5d17b19a7f0c9d5802ba9959abc064f1ad98a3
Reviewed-on: https://chromium-review.googlesource.com/c/1497658Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

71bae22f

Roll recipe dependencies (trivial). · c9031987

recipe-roller authored Mar 02, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0c4c8afe0d49874f5d596697b09057aa3be0a64c [source_manifest] Use PB for source manifest proto. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e0942b4bd9bbe4b32b239aee88ab6c234f1cf07
Reviewed-on: https://chromium-review.googlesource.com/c/1496053Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

c9031987

01 Mar, 2019 2 commits

Roll recipe dependencies (trivial). · 6008eaf2

recipe-roller authored Mar 01, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/921a0d25cc4e1ccc382944bcfadda66e4f04948a Add proper protobuf support to recipe engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0638634da889a2a3413bbf770bbb3caaa9dc5a47
Reviewed-on: https://chromium-review.googlesource.com/c/1496042Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

6008eaf2

[cipd] Update to 2.2.18. · a6d41e23

Vadim Shtayura authored Mar 01, 2019

Includes bug fix for crbug.com/936911 and no other changes.

R=tandrii@chromium.org, iannucci@chromium.org
BUG=936911

Change-Id: I92e6725dc16b513579db87b81e389f9d61bdf62b
Reviewed-on: https://chromium-review.googlesource.com/c/1496034Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

a6d41e23

28 Feb, 2019 2 commits

[led] Roll back to cc015d8903532826f4430b87501a3c542ef468ce. · 51178883

Robert Iannucci authored Feb 28, 2019

The newest version isn't quite ready for prime-time (it drops support for the
`-repository` kitchen flag, which is still passed by buildbucket).

I should be able to reland this later today.

TBR=nodir@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug: 936254
Change-Id: I18d25886cb008dc6f1a32a7ff85ec95b4a055b02
Reviewed-on: https://chromium-review.googlesource.com/c/1495205Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

51178883

Add --current to rebase the current branch · fe83cfa6

Henrique Ferreiro authored Feb 28, 2019

Add a shortcut to extend the branches to be rebased with the current
branch without having to type its name.

Change-Id: If2fa117a6418590cdec5e65430f65dcdc825b611
Reviewed-on: https://chromium-review.googlesource.com/c/1483030Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

fe83cfa6

27 Feb, 2019 1 commit

Add gerrit.abandon_change command · fe34723a

Sergiy Belozorov authored Feb 27, 2019

R=tandrii@chromium.org

Bug: 935715
Change-Id: Ia7b8e2b187b59680270d694b24edf82493d1ed5c
Reviewed-on: https://chromium-review.googlesource.com/c/1487212Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>

fe34723a

26 Feb, 2019 2 commits

[cipd] Rebuild all Go binaries with Go 1.12. · be28670f

Vadim Shtayura authored Feb 26, 2019

Hopefully it works better on OSX 10.14.

R=tandrii@chromium.org
BUG=936067

Change-Id: I097802a053b7f17b81f13a69c1f0c153dc327b10
Reviewed-on: https://chromium-review.googlesource.com/c/1489874Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

be28670f

Roll recipe dependencies (trivial). · 958d88e2

recipe-roller authored Feb 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/81bee2d517dae82881c1193fe9e4860fc7355f5b Implement api.buildbucket.build_url helper property (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6f1e28a0aee6e4bf94ddaf49c30306098e0b46a5
Reviewed-on: https://chromium-review.googlesource.com/c/1489553Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

958d88e2

25 Feb, 2019 3 commits

Check for impossible date ranges · 2afcf22a

Bruce Dawson authored Feb 25, 2019

If you specify the wrong year to the -b flag then you may end up with an
inverted time range that is entirely in the future, and this causes odd
failures. Or at least that's what I've heard. This detects some of these
error cases and halts.

Also a one-line git cl format cleanup.

Change-Id: Iede80faed00d4857443b3a1d853fa2ba69f47023
Reviewed-on: https://chromium-review.googlesource.com/c/1487744
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

2afcf22a

Roll recipe dependencies (trivial). · d13a3a7a

recipe-roller authored Feb 25, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/03539506d1955ecf403784d0e900dd4d71011d97 scheduler: allow to opt-out of default tags in BuildbucketTrigger. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic82acdf0eb4d5972ec6f96a93e64aff0a227160c
Reviewed-on: https://chromium-review.googlesource.com/c/1487334Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d13a3a7a

Roll recipe dependencies (trivial). · 18f119bb

recipe-roller authored Feb 25, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/79f79017de52c70f04314d85e2ed4d8b89546a17 cq: don't emit property when no new builds have been triggered. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I159fba67df2724083d737ea369144243d1b7e03b
Reviewed-on: https://chromium-review.googlesource.com/c/1485296Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

18f119bb

23 Feb, 2019 3 commits

Roll recipe dependencies (trivial). · 95ea36ed

recipe-roller authored Feb 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2a09b5794c3305f9ec315ac948ee097095d17d90 [doc] Change default to "gen". (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d56d79c6a5523555d559d209336a31015cc0502
Reviewed-on: https://chromium-review.googlesource.com/c/1484465Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

95ea36ed

Revert "Pass target branch from tryserver in bot_update module" · 5585c87a

Andrii Shyshkalov authored Feb 23, 2019

This reverts commit 245337d6.

Reason for revert: broke presubmit builders running run_presubmit.py recipe.

Original change's description:
> Pass target branch from tryserver in bot_update module
> 
> Change-Id: I9d250c87355833ddc6c7d8f41e9e43575713925f
> 
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: skia
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: release_scripts
> Change-Id: I9d250c87355833ddc6c7d8f41e9e43575713925f
> Reviewed-on: https://chromium-review.googlesource.com/c/1420977
> Commit-Queue: William Hesse <whesse@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=whesse@google.com,ehmaldonado@chromium.org

Change-Id: I89513b5bb053788291e79340c1685189adc794ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1484655Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

5585c87a

Roll recipe dependencies (trivial). · 54cc6049

recipe-roller authored Feb 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/16dfe87b81be9acfd9e1763b20bd028f81d28e13 cq: add API to track triggered_build_ids. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If06ae07e84bc2e729fc22adc0a08c5cba5a5abfa
Reviewed-on: https://chromium-review.googlesource.com/c/1484453Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

54cc6049

22 Feb, 2019 7 commits

[lucicfg] Bump lucicfg version 1.2.0 -> 1.3.2. · d7f7a3eb

Vadim Shtayura authored Feb 22, 2019

Change log: https://chromium.googlesource.com/infra/luci/luci-go/+log/ea41200b..1d348dee/lucicfg

R=tandrii@chromium.org
CC=andrewlamb@google.com

Change-Id: I37b8a33971348b24db53ddf384ec3f5d7088e283
Reviewed-on: https://chromium-review.googlesource.com/c/1483872Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

d7f7a3eb

git cl: Print a clear error message when we fail to find the remote url. · 298f2cf8

Edward Lemur authored Feb 22, 2019

Bug: 914655
Change-Id: I06a3ff39d884327fd407a5c50cc9730a375bef0b
Reviewed-on: https://chromium-review.googlesource.com/c/1382974
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

298f2cf8

CppLint changes for VSCode cpplint plugin · 91a32c5e

Jordan Bayles authored Feb 22, 2019

This patch makes some changes to the cpplint.py script for integration
with the VSCode cpplint plugin, available here:

https://marketplace.visualstudio.com/items?itemName=mine.cpplint

Specifically, the "--repository" and "--headers" options currently cause
our version of cpplint to crash, when we should at worst ignore them. A
minor messaging tweak outputting the contents of the GetoptError, to
make debugging input argument bugs easier, is included

Change-Id: Id78616f5e2fdecb7da650042f0658623477ef9cb
Reviewed-on: https://chromium-review.googlesource.com/c/1481938Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>

91a32c5e

Roll recipe dependencies (trivial). · ac0cb2c1

recipe-roller authored Feb 22, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6605f1b0db4ddee8e7f40b73fe60cf5f8cbe794f Make StatusFailure work for non-exceptional failures only (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5515d64ea9f9f1d0c40f6b59a7f95bab774c625
Reviewed-on: https://chromium-review.googlesource.com/c/1483759Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ac0cb2c1

[cpplint] Ignore fn_size check for macros with digits · 4809957b

Quinten Yearsley authored Feb 22, 2019

In the cpplint fn_size check, there's a part where it explicitly
says to ignore macros, BUT the check for macro names didn't allow
for digits, which are present in the IPC_* macro names, which
look like "IPC_SYNC_MESSAGE_CONTROL4_1".

There are two interesting things about this:

1. This bug was filed in 2011! Yay for fixing a 5-digit crbug with
one-line fix!
2. This is a great example of how cpplint's regex-based checking is
error-prone compared to something that actually has access to an
abstract syntax tree.

Bug: 83036
Change-Id: I49acd80c265d7f7bc633f2092388525b4518ae23
Reviewed-on: https://chromium-review.googlesource.com/c/1483283Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

4809957b

Replace post-process checks with ones that are not deprecated · 151c3484

Sergiy Belozorov authored Feb 22, 2019

R=iannucci@chromium.org

Bug: 899266
Change-Id: Ia9b1f38590d636fa2858a2bd0bbf75d6b2cfe8fa
Reviewed-on: https://chromium-review.googlesource.com/c/1483033Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>

151c3484

Pass target branch from tryserver in bot_update module · 245337d6

William Hesse authored Feb 22, 2019

Change-Id: I9d250c87355833ddc6c7d8f41e9e43575713925f

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: release_scripts
Change-Id: I9d250c87355833ddc6c7d8f41e9e43575713925f
Reviewed-on: https://chromium-review.googlesource.com/c/1420977
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

245337d6