- 01 Jun, 2017 3 commits
-
-
Dan Jacques authored
Second attempt at landing. Fix quotes around python in "gclient.bat". Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I0fceb99c8adb96e72dac706819be032d400aad37 Reviewed-on: https://chromium-review.googlesource.com/521704 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
Daniel Jacques authored
This reverts commit 2f5f0b7a. Reason for revert: <INSERT REASONING HERE> Original change's description: > [.bat] Remove "depot_tools" override. > > Currently, all ".bat" entry points use "~dp0python" to ensure that the > Python that is used to execute the tool is the one in depot_tools. This > prevents any sort of system override. > > Remove this override so that PATH solely determines which Python is > used. To accommodate users who invoked these tools without Python on the > PATH, we still still add "depot_tools" as a catch-all PATH suffix. > > Some tools were also not using DOS-style line endings. This CL fixes > this. > > BUG=chromium:714293, chromium:724902 > TEST=None > > Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 > Reviewed-on: https://chromium-review.googlesource.com/517236 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > TBR=maruel@chromium.org,iannucci@chromium.org,vadimsh@chromium.org,dnj@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:714293, chromium:724902 Change-Id: I822abdd4e02abd32d2f4789fb16d5a7f78fdd02d Reviewed-on: https://chromium-review.googlesource.com/521867Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Dan Jacques authored
Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 Reviewed-on: https://chromium-review.googlesource.com/517236 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
- 24 May, 2017 1 commit
-
-
Dan Jacques authored
Several boilerplate batch files include a provision to prepend "depot_tools" to PATH prior to running those tools. This undermines the utility of PATH overrides, since these tools specifically force their "depot_tools" sub-paths to be used regardless of environment. The origin of this behavior is likely limited to a specific fix for a specific problem, but was then perpetuated by the copy/paste of boilerplate bootstrap code as more bootstraps were added. This is important in upcoming configurations, where core tools such as Python and Git will be overridden via PATH on the bots. Cygwin users who depended on this behavior should just add "depot_tools" to their PATH in the appropriate location (i.e. in their .bashrc). BUG=chromium:714293, chromium:724902 TEST=None Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537 Reviewed-on: https://chromium-review.googlesource.com/510290 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 27 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Set svn:eol-style=CRLF for all .bat files and everything in bootstrap/win/ Set svn:eol-style=LF for everything else. Also delete depot_tools/git_cl/ since it's not used anymore. Review URL: http://codereview.chromium.org/8055016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103051 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2009 1 commit
-
-
sgk@google.com authored
Review URL: http://codereview.chromium.org/201062 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25751 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2009 1 commit
-
-
maruel@chromium.org authored
so you can type only cpplint in console like the other scripts(gclient, gcl, etc) BUG=None TEST=None Patch contributed by thiago.farina@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22576 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/113205 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15757 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 May, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/115064 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15503 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Apr, 2009 1 commit
-
-
maruel@google.com authored
Review URL: http://codereview.chromium.org/92087 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
-